Linux Documentation
 help / color / mirror / Atom feed
* [PATCH 1/2] Documentation: kunit: Test Kconfig entries shouldn't select other configs
@ 2026-06-27  8:29 David Gow
  2026-06-27  8:29 ` [PATCH 2/2] Documentation: kunit: Fix outdated FAQ entries David Gow
  2026-06-29 16:11 ` [PATCH 1/2] Documentation: kunit: Test Kconfig entries shouldn't select other configs Geert Uytterhoeven
  0 siblings, 2 replies; 3+ messages in thread
From: David Gow @ 2026-06-27  8:29 UTC (permalink / raw)
  To: Brendan Higgins, Rae Moar, Jonathan Corbet, Shuah Khan
  Cc: David Gow, linux-kselftest, kunit-dev, linux-doc, linux-kernel,
	Geert Uytterhoeven

Add a note to the Kconfig section of style.rst to use 'depends on' rather
than 'selects' for dependencies, as this can cause users of
CONFIG_KUNIT_ALL_TESTS to suddenly grow unexpected dependencies.

Signed-off-by: David Gow <david@davidgow.net>
---
 Documentation/dev-tools/kunit/style.rst | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/Documentation/dev-tools/kunit/style.rst b/Documentation/dev-tools/kunit/style.rst
index eac81a714a29..449f9f816fc7 100644
--- a/Documentation/dev-tools/kunit/style.rst
+++ b/Documentation/dev-tools/kunit/style.rst
@@ -164,9 +164,10 @@ This Kconfig entry must:
 * be visible only if ``CONFIG_KUNIT_ALL_TESTS`` is not enabled.
 * have a default value of ``CONFIG_KUNIT_ALL_TESTS``.
 * have a brief description of KUnit in the help text.
-
-If we are not able to meet above conditions (for example, the test is unable to
-be built as a module), Kconfig entries for tests should be tristate.
+* depend on the feature being tested, rather than selecting it (so that
+  enabling ``CONFIG_KUNIT_ALL_TESTS`` does not enable unrelated functionality).
+* be ``tristate``, unless there is a specific reason that the test cannot be
+  built as a module.
 
 For example, a Kconfig entry might look like:
 
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-06-29 16:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-27  8:29 [PATCH 1/2] Documentation: kunit: Test Kconfig entries shouldn't select other configs David Gow
2026-06-27  8:29 ` [PATCH 2/2] Documentation: kunit: Fix outdated FAQ entries David Gow
2026-06-29 16:11 ` [PATCH 1/2] Documentation: kunit: Test Kconfig entries shouldn't select other configs Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox