From: "Pradhan, Sanman" <sanman.pradhan@hpe.com>
To: "conor@kernel.org" <conor@kernel.org>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"corbet@lwn.net" <corbet@lwn.net>,
"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sanman Pradhan <psanman@juniper.net>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: pmbus: Add Analog Devices MAX16545/MAX16550 and Volterra VT7505
Date: Thu, 23 Jul 2026 16:46:25 +0000 [thread overview]
Message-ID: <20260723164600.200995-1-sanman.pradhan@hpe.com> (raw)
In-Reply-To: <20260722-everglade-nickname-cdd52d3842a5@spud>
From: Sanman Pradhan <psanman@juniper.net>
On Wed, Jul 22, 2026 at 17:34:00 +0100, Conor Dooley wrote:
> On Wed, Jul 22, 2026 at 03:03:37PM +0000, Pradhan, Sanman wrote:
> > + adi,ocp-severe-filter:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description:
> > + Deglitch time applied to the severe overcurrent-protection comparator,
> > + programmed into the MFR_CONFIG[15:14] field. The MAX16550 and VT7505
> > + expose this field; it decodes as 0 = 0 us, 1 = 1 us, 2 = 2 us and
> > + 3 = 10 us. On the MAX16545 the severe overcurrent delay is fixed and
>
> Please represent this property in microseconds.
> pw-bot: changes-requested
>
> Otherwise, I think this looks fine.
>
> Thanks,
> Conor.
>
> > + these bits are reserved.
> > + enum: [0, 1, 2, 3]
Thanks for the review. I've tried to address your comment in v2.
Thank you.
Regards,
Sanman Pradhan
next prev parent reply other threads:[~2026-07-23 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 15:03 [PATCH 0/2] hwmon: (pmbus) Add Analog Devices MAX16545/MAX16550 and Volterra VT7505 driver Pradhan, Sanman
2026-07-22 15:03 ` [PATCH 1/2] dt-bindings: hwmon: pmbus: Add Analog Devices MAX16545/MAX16550 and Volterra VT7505 Pradhan, Sanman
2026-07-22 16:34 ` Conor Dooley
2026-07-23 16:46 ` Pradhan, Sanman [this message]
2026-07-22 15:03 ` [PATCH 2/2] hwmon: (pmbus/vt7505) Add driver for " Pradhan, Sanman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723164600.200995-1-sanman.pradhan@hpe.com \
--to=sanman.pradhan@hpe.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=psanman@juniper.net \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox