Linux Documentation
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: Babu Moger <babu.moger@amd.com>,
	"Luck, Tony" <tony.luck@intel.com>,
	"Moger, Babu" <bmoger@amd.com>, "x86@kernel.org" <x86@kernel.org>,
	"Dave.Martin@arm.com" <Dave.Martin@arm.com>,
	"james.morse@arm.com" <james.morse@arm.com>,
	"corbet@lwn.net" <corbet@lwn.net>,
	"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
	"tglx@kernel.org" <tglx@kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"Eranian, Stephane" <eranian@google.com>,
	"peternewman@google.com" <peternewman@google.com>
Subject: Re: [PATCH 1/2] x86/resctrl, Documentation: Keep mbm_assign_mode "default" on boot
Date: Tue, 4 Aug 2026 15:47:03 -0700	[thread overview]
Message-ID: <20260804224703.GFanJr52UbKBrCOTij@fat_crate.local> (raw)
In-Reply-To: <98be93cc-f2d8-4bad-bbb0-f309e912054c@intel.com>

On Tue, Aug 04, 2026 at 03:10:18PM -0700, Reinette Chatre wrote:
> > So, long story short - and I appreciate the explaining - we should switch
> > AMD's default behavior back to RMID + 64 counters - exactly like it is on
> > Intel - and the ABMC thing will be explicitly selectable by the user.
> 
> nit: s/exactly like it is on Intel//

What does that mean?

What's the difference between Intel's RMID mode + 64 counters and AMD's?

> 
> ok. 
> 
> > This way there are no surprises when running any tools on either vendor and if
> > one wants something special, one selects it.
> This patch, once minimized for easier backporting and marked for stable, would
> accomplish this.  
> 
> Two nitpicks:
> * "no surprises" should be "no surprises (as long as AMD hardware does not return
>   "Unavailable")".

AFAIK, Babu was unable to reproduce that.

>    There is the known issue with the default mode on AMD where return of "Unavailable"
>    is treated as wraparound by pqos.

I guess Babu can address that.

> * "one wants something special" should be "one wants accurate data".
>    Caveat: User does not know how inaccurate data is in default mode. Users need to learn
>    about existence of accurate data from outside resctrl via external sources, possibly
>    leaving it up to the tools considered here.

With my simple thinking, I would expect that accurate data means, the number
of counters being in use is not hitting the arch limit. The moment that
happens, I guess one could deem that measurement innacurate.

> What is the plan with https://github.com/intel/intel-cmt-cat/issues/311 ?

I guess that should be closed once we switch back the default.

> sidenote:
> Separate from this I again would like to propose that AMD work with pqos folks on
> how pqos should handle the various text return values to fix the wraparound
> issue.

Agreed.

> For example, is the preference for counting to stall at a number until the
> hardware reports data again (so that user space always just sees numbers and not
> be surprised by text) or should the text value (for example "Unavailable") be passed
> on to user space or ...? The current wraparound issue should be fixed but it is
> difficult for me to gauge what solution users would find least surprising. My
> expectations from users do seem to be on the high side.

I'd go for "the least surprises possible" approach here. But I'd let Babu
comment here about the specifics.

Thx!

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2026-08-04 22:47 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 21:13 [PATCH 1/2] x86/resctrl, Documentation: Keep mbm_assign_mode "default" on boot Babu Moger
2026-07-17 21:13 ` [PATCH 2/2] x86/resctrl: Fix ABMC counter programming for extended counter ranges Babu Moger
2026-07-17 22:56 ` [PATCH 1/2] x86/resctrl, Documentation: Keep mbm_assign_mode "default" on boot Reinette Chatre
2026-07-20 17:00   ` Babu Moger
2026-07-20 18:27     ` Reinette Chatre
2026-07-20 19:15       ` Babu Moger
2026-07-21 20:54         ` Reinette Chatre
2026-07-23 18:03           ` Babu Moger
2026-07-23 21:46             ` Reinette Chatre
2026-07-24 20:57               ` Moger, Babu
2026-07-24 22:28                 ` Reinette Chatre
2026-07-24 23:12                   ` Borislav Petkov
2026-07-24 23:53                     ` Reinette Chatre
2026-07-27 14:05                       ` Borislav Petkov
2026-07-27 15:25                         ` Reinette Chatre
2026-07-27 17:24                           ` Babu Moger
2026-07-27 18:12                             ` Reinette Chatre
2026-07-27 20:17                               ` Babu Moger
2026-07-27 21:42                                 ` Reinette Chatre
2026-07-27 22:44                                   ` Moger, Babu
2026-07-27 23:29                                     ` Moger, Babu
2026-07-28  0:29                                       ` Reinette Chatre
2026-07-28 17:04                                         ` Borislav Petkov
2026-07-28 17:25                                         ` Babu Moger
2026-07-20 20:12 ` Babu Moger
2026-07-28 19:18 ` Borislav Petkov
2026-07-28 19:46   ` Babu Moger
2026-07-28 19:58     ` Luck, Tony
2026-07-28 20:18       ` Babu Moger
2026-07-28 20:24         ` Luck, Tony
2026-07-28 20:43           ` Babu Moger
2026-07-28 21:58             ` Reinette Chatre
2026-07-28 22:20               ` Moger, Babu
2026-07-30 18:46                 ` Borislav Petkov
2026-07-30 19:39                   ` Babu Moger
2026-07-30 19:43                     ` Borislav Petkov
2026-07-30 19:49                       ` Babu Moger
2026-07-30 20:40                         ` Luck, Tony
2026-07-30 20:59                           ` Babu Moger
2026-07-31  0:34                           ` Borislav Petkov
2026-07-31 14:59                             ` Reinette Chatre
2026-08-01  1:22                               ` Borislav Petkov
2026-08-01 23:47                                 ` Reinette Chatre
2026-08-04 19:16                                   ` Borislav Petkov
2026-08-04 22:10                                     ` Reinette Chatre
2026-08-04 22:47                                       ` Borislav Petkov [this message]
2026-08-04 23:05                                         ` Luck, Tony
2026-08-04 23:40                                           ` Borislav Petkov
2026-08-05  0:02                                             ` Luck, Tony
2026-08-05  0:21                                               ` Borislav Petkov
2026-08-04 23:35                                         ` Reinette Chatre
2026-08-05  0:12                                           ` Reinette Chatre
2026-08-05 22:40                                           ` Moger, Babu
2026-08-04 23:44                                       ` Moger, Babu
2026-08-05  5:03                                         ` Reinette Chatre
2026-07-31 15:34                             ` Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260804224703.GFanJr52UbKBrCOTij@fat_crate.local \
    --to=bp@alien8.de \
    --cc=Dave.Martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=bmoger@amd.com \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=eranian@google.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peternewman@google.com \
    --cc=reinette.chatre@intel.com \
    --cc=skhan@linuxfoundation.org \
    --cc=tglx@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox