From: Md Haris Iqbal <haris.iqbal@linux.dev>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Md Haris Iqbal <haris.iqbal@linux.dev>
Subject: [RFC for-next 0/3] block: delay support for error injection
Date: Thu, 27 Aug 2026 02:01:12 +0200 [thread overview]
Message-ID: <20260827000115.128093-1-haris.iqbal@linux.dev> (raw)
Error injection can only fail a bio today. This adds a delay_us option so
that a rule can hold a bio back first, to model a slow device.
The delay happens above the driver, so it is invisible to the I/O
statistics and never reaches the blk-mq timeout handler or SCSI error
handling. What it does exercise is the code waiting above the block
layer: io_uring cancellation, hung task detection, and filesystem or
userspace timeouts.
Two things are worth a look. A delayed bio is resubmitted below the
injection hook, so the rules are not applied to it again and it can never
pick up a status from another rule. And holding a bio back reorders it
against bios submitted later, which breaks sequential write ordering on
zoned devices. Both are documented in patch 3.
Patch 1 is a prep cleanup. It moves the rejection of an unknown status
tag into the parser, because patch 2 makes a rule without a status valid.
Tested in a VM.
Md Haris Iqbal (3):
block: reject unknown status tags in error injection rules
block: allow error injection rules to delay bios
Documentation: block: document error injection delays
Documentation/block/error-injection.rst | 56 ++++++++-
block/blk-core.c | 13 +-
block/blk.h | 1 +
block/error-injection.c | 154 +++++++++++++++++++++---
4 files changed, 201 insertions(+), 23 deletions(-)
--
2.53.0
next reply other threads:[~2026-08-27 0:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 0:01 Md Haris Iqbal [this message]
2026-08-27 0:01 ` [RFC for-next 1/3] block: reject unknown status tags in error injection rules Md Haris Iqbal
2026-08-27 0:01 ` [RFC for-next 2/3] block: allow error injection rules to delay bios Md Haris Iqbal
2026-08-27 13:02 ` Haris Iqbal
2026-08-27 22:44 ` Haris Iqbal
2026-08-27 0:01 ` [RFC for-next 3/3] Documentation: block: document error injection delays Md Haris Iqbal
2026-08-27 3:49 ` [RFC for-next 0/3] block: delay support for error injection Keith Busch
2026-08-27 22:40 ` Haris Iqbal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827000115.128093-1-haris.iqbal@linux.dev \
--to=haris.iqbal@linux.dev \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox