From: Keith Busch <kbusch@kernel.org>
To: Md Haris Iqbal <haris.iqbal@linux.dev>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>
Subject: Re: [RFC for-next 0/3] block: delay support for error injection
Date: Wed, 26 Aug 2026 21:49:47 -0600 [thread overview]
Message-ID: <ao-z23T9yE6Z2BTZ@kbusch-mbp> (raw)
In-Reply-To: <20260827000115.128093-1-haris.iqbal@linux.dev>
On Thu, Aug 27, 2026 at 02:01:12AM +0200, Md Haris Iqbal wrote:
> Two things are worth a look. A delayed bio is resubmitted below the
> injection hook, so the rules are not applied to it again and it can never
> pick up a status from another rule. And holding a bio back reorders it
> against bios submitted later, which breaks sequential write ordering on
> zoned devices. Both are documented in patch 3.
Would it be possible to do the delay on the completion side instead?
That should avoid those submission order problems.
next prev parent reply other threads:[~2026-08-27 3:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 0:01 [RFC for-next 0/3] block: delay support for error injection Md Haris Iqbal
2026-08-27 0:01 ` [RFC for-next 1/3] block: reject unknown status tags in error injection rules Md Haris Iqbal
2026-08-27 0:01 ` [RFC for-next 2/3] block: allow error injection rules to delay bios Md Haris Iqbal
2026-08-27 13:02 ` Haris Iqbal
2026-08-27 22:44 ` Haris Iqbal
2026-08-27 0:01 ` [RFC for-next 3/3] Documentation: block: document error injection delays Md Haris Iqbal
2026-08-27 3:49 ` Keith Busch [this message]
2026-08-27 22:40 ` [RFC for-next 0/3] block: delay support for error injection Haris Iqbal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao-z23T9yE6Z2BTZ@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=haris.iqbal@linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox