Linux Documentation
 help / color / mirror / Atom feed
* [PATCH v2 3/3] hwmon: (nct6775) Add support for NCT6122D
       [not found] <20260910-bootlin-hwmon-nct6126-v2-0-ee629ab35e49@bootlin.com>
@ 2026-09-10  7:02 ` Paul Louvel
       [not found] ` <20260910-bootlin-hwmon-nct6126-v2-1-ee629ab35e49@bootlin.com>
       [not found] ` <20260910-bootlin-hwmon-nct6126-v2-2-ee629ab35e49@bootlin.com>
  2 siblings, 0 replies; 3+ messages in thread
From: Paul Louvel @ 2026-09-10  7:02 UTC (permalink / raw)
  To: Guenter Roeck, Jonathan Corbet, Shuah Khan, Randy Dunlap
  Cc: Thomas Petazzoni, linux-hwmon, linux-doc, linux-kernel,
	Paul Louvel

The NCT6122D hardware monitor is the same as the NCT6126D, the only
difference if the number of UARTs: two instead of six.
Add it to the driver using the nct6126 chip kind to avoid code
duplication.

Assisted-by: opencode:z-ai/glm-5.3-flash
Signed-off-by: Paul Louvel <paul.louvel@bootlin.com>
---
 drivers/hwmon/nct6775-platform.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/nct6775-platform.c b/drivers/hwmon/nct6775-platform.c
index a8ef58d3a883..d359c28f3e0f 100644
--- a/drivers/hwmon/nct6775-platform.c
+++ b/drivers/hwmon/nct6775-platform.c
@@ -25,7 +25,7 @@ enum sensor_access { access_direct, access_asuswmi };
 static const char * const nct6775_sio_names[] __initconst = {
 	[nct6106] = "NCT6106D",
 	[nct6116] = "NCT6116D",
-	[nct6126] = "NCT6126D",
+	[nct6126] = "NCT6122D/NCT6126D",
 	[nct6775] = "NCT6775F",
 	[nct6776] = "NCT6776D/F",
 	[nct6779] = "NCT6779D",
@@ -77,6 +77,7 @@ MODULE_PARM_DESC(fan_debounce, "Enable debouncing for fan RPM signal");
 
 #define SIO_NCT6106_ID		0xc450
 #define SIO_NCT6116_ID		0xd280
+#define SIO_NCT6122_ID		0xd2a0
 #define SIO_NCT6126_A_ID	0xd283
 #define SIO_NCT6126_B_ID	0xd284
 #define SIO_NCT6775_ID		0xb470
@@ -1035,6 +1036,9 @@ static int __init nct6775_find(int sioaddr, struct nct6775_sio_data *sio_data)
 		else
 			sio_data->kind = nct6116;
 		break;
+	case SIO_NCT6122_ID:
+		sio_data->kind = nct6126;
+		break;
 	case SIO_NCT6775_ID:
 		sio_data->kind = nct6775;
 		break;

-- 
2.55.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/3] Documentation: hwmon: (nct6775) Document NCT6116D/NCT6122D/NCT6126D support
       [not found] ` <20260910-bootlin-hwmon-nct6126-v2-1-ee629ab35e49@bootlin.com>
@ 2026-09-11  1:00   ` Guenter Roeck
  0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2026-09-11  1:00 UTC (permalink / raw)
  To: Paul Louvel
  Cc: Jonathan Corbet, Shuah Khan, Randy Dunlap, Thomas Petazzoni,
	linux-hwmon, linux-doc, linux-kernel

On Thu, Sep 10, 2026 at 09:02:38AM +0200, Paul Louvel wrote:
> The NCT6112D/NCT6114D/NCT6116D family has been supported by the driver
> since commit 29c7cb485b32 ("hwmon: (nct6775) Integrate new model
> nct6116"), but was never added to the list of supported chips in the
> driver documentation.
> 
> Also add the NCT6122D/NCT6126D.
> 
> Assisted-by: opencode:z-ai/glm-5.3-flash
> Signed-off-by: Paul Louvel <paul.louvel@bootlin.com>

Applied.

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 2/3] hwmon: (nct6775) Add support for NCT6126D
       [not found] ` <20260910-bootlin-hwmon-nct6126-v2-2-ee629ab35e49@bootlin.com>
@ 2026-09-11  1:00   ` Guenter Roeck
  0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2026-09-11  1:00 UTC (permalink / raw)
  To: Paul Louvel
  Cc: Jonathan Corbet, Shuah Khan, Randy Dunlap, Thomas Petazzoni,
	linux-hwmon, linux-doc, linux-kernel

On Thu, Sep 10, 2026 at 09:02:39AM +0200, Paul Louvel wrote:
> Add support for the hardware monitoring functionality of the NCT6126D
> Super-I/O chip.
> 
> The NCT6126D hardware monitor is nearly identical to the NCT6116D: the
> fan, PWM, temperature, TSI, alarm.
> 
> The differences are:
> 
> - Device IDs 0xd283 (A version) and 0xd284 (B version), which both fall
>   into the NCT6116D ID range (0xd280) when masked with SIO_ID_MASK.
>   Instead, compare the full value to distinguish from NCT6116D.
> 
> - One additional VIN: VHIF scaled at 16 mV/LSB.
> 
> - The fan count limit registers are documented for all five fans.
>   Also expose fan4_min.
> 
> Assisted-by: opencode:z-ai/glm-5.3-flash
> Signed-off-by: Paul Louvel <paul.louvel@bootlin.com>

Applied.

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-11  1:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20260910-bootlin-hwmon-nct6126-v2-0-ee629ab35e49@bootlin.com>
2026-09-10  7:02 ` [PATCH v2 3/3] hwmon: (nct6775) Add support for NCT6122D Paul Louvel
     [not found] ` <20260910-bootlin-hwmon-nct6126-v2-1-ee629ab35e49@bootlin.com>
2026-09-11  1:00   ` [PATCH v2 1/3] Documentation: hwmon: (nct6775) Document NCT6116D/NCT6122D/NCT6126D support Guenter Roeck
     [not found] ` <20260910-bootlin-hwmon-nct6126-v2-2-ee629ab35e49@bootlin.com>
2026-09-11  1:00   ` [PATCH v2 2/3] hwmon: (nct6775) Add support for NCT6126D Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox