* b53.rst: is the 5325/5365 "no tagging support" section still accurate?
@ 2026-09-11 10:35 Christian Melendez
0 siblings, 0 replies; only message in thread
From: Christian Melendez @ 2026-09-11 10:35 UTC (permalink / raw)
To: Álvaro Fernández Rojas
Cc: Jonas Gorski, Florian Fainelli, netdev, linux-doc
Hi Álvaro,
Documentation/networking/dsa/b53.rst still lists 5325/5365 under
"Configuration without tagging support", saying they "support a
different tag format that is not supported yet". But
b53_get_tag_protocol() assigns them DSA_TAG_PROTO_BRCM_LEGACY_FCS,
which seems to have an implementation in net/dsa/tag_brcm.c
(brcm_leg_fcs_tag_xmit). This looks like it's been true since
c3cf059a4d41.
Separately, ds->untag_bridge_pvid (b53_common.c) is only set when
tag_protocol == DSA_TAG_PROTO_NONE -- which I guess no longer applies
to 5325/5365 -- so the VLAN workaround described right after
(removing the default VLAN 1) may not apply to them either anymore.
Is the doc just stale on both counts, or is there a reason 5325/5365
still belong in that section in practice? I don't have this hardware
to test against. Happy to send a fix once I know which parts still
hold.
Thanks,
Christian
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-11 10:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-11 10:35 b53.rst: is the 5325/5365 "no tagging support" section still accurate? Christian Melendez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox