* [RFC PATCH 0/4] mm/damon/reclaim: enable auto-tuning features by default
@ 2026-11-20 6:07 SJ Park
2026-11-20 6:07 ` [RFC PATCH 4/4] Docs/admin-guide/mm/damon/reclaim: update for changed default parameters SJ Park
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: SJ Park @ 2026-11-20 6:07 UTC (permalink / raw)
Cc: SJ Park, Andrew Morton, Jonathan Corbet, Randy Dunlap, Shuah Khan,
damon, linux-doc, linux-mm
The initial version of DAMON_RECLAIM was supposed to be used after
manual tuning of its parameters. Among the parameters, the monitoring
intervals (sample_interval and aggr_interval) and the coldness threshold
(min_age) are particularly important to be optimally tuned. The optimum
values for the parameters tend to be highly dependent on the workload
and the system. Hence no small amount of tuning efforts are required to
each DAMON_RECLAIM use case.
To reduce the tuning efforts, we recently introduced two auto-tuning
features. Intervals auto-tuning (autotune_monitoring_intervals)
automatically tunes monitoring intervals to provide practical and
efficient monitoring results. PSI-driven quota auto-tuning
(quota_autotune_feedback) automatically tunes the coldness threshold.
Because the auto-tuning features were introduced after the initial
version, the features are disabled by default. That is to keep the
default behaviors unchanged. However, enabling the auto-tuning features
is only expected to provide more benefit to the users. Disabling those
by default only makes the adoption of the features slow. Also, it is
difficult to imagine real users who use DAMON_RECLAIM with its default
parameter values.
Enable the auto-tuning features by default. For PSI-driven coldness
threshold auto-tuning, set 0.05% memory pressure ratio as the target.
Free memory ratio based reclaim watermarks were introduced as a safe
guard for unoptimized coldness threshold. Because it is now reasonably
auto-tuned, disable the watermark feature by default.
Enable the monitoring intervals auto-tuning and PSI-driven coldness
threshold auto-tuning via patches 1 and 2, respectively. Disable the
free memory ratio based watermarks via patch 3. Finally update the user
document to reflect the changed default values, via patch 4.
SJ Park (4):
mm/damon/reclaim: enable monitoring intervals auto-tune by default
mm/damon/reclaim: set memory PSI 0.05% as default quota goal
mm/damon/reclaim: disable watermarks by default
Docs/admin-guide/mm/damon/reclaim: update for changed default
parameters
Documentation/admin-guide/mm/damon/reclaim.rst | 7 ++++---
mm/damon/reclaim.c | 15 ++++++++-------
2 files changed, 12 insertions(+), 10 deletions(-)
base-commit: 0ec5c1c237bdf91ae93b3efe32767aad9a670f8a
--
2.47.3
^ permalink raw reply [flat|nested] 5+ messages in thread* [RFC PATCH 4/4] Docs/admin-guide/mm/damon/reclaim: update for changed default parameters 2026-11-20 6:07 [RFC PATCH 0/4] mm/damon/reclaim: enable auto-tuning features by default SJ Park @ 2026-11-20 6:07 ` SJ Park 2026-11-21 1:53 ` [RFC PATCH 0/4] mm/damon/reclaim: enable auto-tuning features by default SJ Park [not found] ` <20261120060741.92121-3-sj@kernel.org> 2 siblings, 0 replies; 5+ messages in thread From: SJ Park @ 2026-11-20 6:07 UTC (permalink / raw) Cc: SJ Park, Jonathan Corbet, Randy Dunlap, Shuah Khan, damon, linux-doc, linux-mm Update DAMON_RECLAIM user documentation to reflect the changed default parameter values. Intervals and PSI-driven coldness threshold auto-tuning features are enabled by default. The free memory ratio based watermarks feature is disabled by default. Signed-off-by: SJ Park <sj@kernel.org> --- Documentation/admin-guide/mm/damon/reclaim.rst | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/admin-guide/mm/damon/reclaim.rst b/Documentation/admin-guide/mm/damon/reclaim.rst index 0ef784df98680..79d24e3819cea 100644 --- a/Documentation/admin-guide/mm/damon/reclaim.rst +++ b/Documentation/admin-guide/mm/damon/reclaim.rst @@ -95,7 +95,7 @@ amount of access events in each DAMON-snapshot, while keeping the sampling interval 5 milliseconds in minimum, and 10 seconds in maximum. Setting this to ``N`` disables the auto-tuning. -Disabled by default. +Enabled by default. quota_ms -------- @@ -145,7 +145,7 @@ per quota reset interval (``quota_reset_interval_ms``) is collected and compared to this value to see if the aim is satisfied. Value zero means disabling this auto-tuning feature. -Disabled by default. +500 microseconds (0.05 percent of default quota reset interval) by default. quota_autotune_feedback ----------------------- @@ -196,7 +196,8 @@ granularity reclamation logic. To keep DAMON_RECLAIM always active regardless of the free memory rate, set ``wmarks_high``, ``wmarks_mid`` and ``wmarks_low`` to ``1000``, ``1000`` and -``0``, respectively. +``0``, respectively. Use of watermarks is not recommended and therefore +disabled by default. sample_interval --------------- -- 2.47.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RFC PATCH 0/4] mm/damon/reclaim: enable auto-tuning features by default 2026-11-20 6:07 [RFC PATCH 0/4] mm/damon/reclaim: enable auto-tuning features by default SJ Park 2026-11-20 6:07 ` [RFC PATCH 4/4] Docs/admin-guide/mm/damon/reclaim: update for changed default parameters SJ Park @ 2026-11-21 1:53 ` SJ Park [not found] ` <20261120060741.92121-3-sj@kernel.org> 2 siblings, 0 replies; 5+ messages in thread From: SJ Park @ 2026-11-21 1:53 UTC (permalink / raw) To: SJ Park Cc: Andrew Morton, Jonathan Corbet, Randy Dunlap, Shuah Khan, damon, linux-doc, linux-mm, arijit.desaii On Thu, 19 Nov 2026 22:07:34 -0800 SJ Park <sj@kernel.org> wrote: > The initial version of DAMON_RECLAIM was supposed to be used after > manual tuning of its parameters. Among the parameters, the monitoring > intervals (sample_interval and aggr_interval) and the coldness threshold > (min_age) are particularly important to be optimally tuned. The optimum > values for the parameters tend to be highly dependent on the workload > and the system. Hence no small amount of tuning efforts are required to > each DAMON_RECLAIM use case. > > To reduce the tuning efforts, we recently introduced two auto-tuning > features. Intervals auto-tuning (autotune_monitoring_intervals) > automatically tunes monitoring intervals to provide practical and > efficient monitoring results. PSI-driven quota auto-tuning > (quota_autotune_feedback) automatically tunes the coldness threshold. > > Because the auto-tuning features were introduced after the initial > version, the features are disabled by default. That is to keep the > default behaviors unchanged. However, enabling the auto-tuning features > is only expected to provide more benefit to the users. Disabling those > by default only makes the adoption of the features slow. Also, it is > difficult to imagine real users who use DAMON_RECLAIM with its default > parameter values. > > Enable the auto-tuning features by default. My colleague, Arijit, found this is not a good idea. He is now working on proving the theory and making a patch. DAMON_RECLAIM receives the coldness throughput via 'min_age' parameter, which has 2 minutes as the default value. DAMON_RECLAIM converts that into the number of aggregation intervals for the time, and set it as the min_age_region of the damos_access_pattern for its reclamation DAMOS scheme. DAMON_RECLAIM does the conversion when it starts working, or a parameter is updated online, using commit_inputs parameter. It doesn't update the min_age_region value when the aggregation interval is auto-tuned. This patchset enables the intervals auto-tuning features so that the aggregation intervals span from 100 milliseconds to 200 seconds (up to 2,000 x). As a result, the effective min_age can span from 2 minutes to 4,000 minutes. In usual real workload, the auto-tuning converges the aggregation interval to a few seconds (20-200x). The effective min_age will be about 40 minutes to 400 minutes. Even on long term real world workload, that could be too much threshold. The user will show DAMON_RECLAIM is reclaiming only unexpectedly small amount of memory. PSI-driven coldness threshold auto-tuning can make the effective min_age only longer, so it doesn't help. One strightforward workaround would be setting the min_age a small value, like 2-4 aggregation intervals (200-400 milliseconds). Then, in usual case, the effective min_age becomes 4 seconds to 40 seconds. It might feel like too small threshold. PSI-driven coldness threshold auto-tuning will make it better. Yet another workaround would be monitoring the auto-tuned interval and update the min_age online, using the commit_inputs parameter. We introduced age_ms DAMOS filter type [1] to fix this kind of issue. Long term solution for DAMON_RECLAIM would be modifying it to use the age_ms DAMOS filter instead of the aggregation interval based min_age_region. My colleague, Arijit, is working on the long term solution. Until it is arrived, I will keep the RFC tag of this patch series. [1] https://lore.kernel.org/20261106020559.98352-1-sj@kernel.org Thanks, SJ [...] ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20261120060741.92121-3-sj@kernel.org>]
* Re: [RFC PATCH 2/4] mm/damon/reclaim: set memory PSI 0.05% as default quota goal [not found] ` <20261120060741.92121-3-sj@kernel.org> @ 2026-11-21 12:39 ` Aveline Noir 2026-11-21 17:23 ` SJ Park 0 siblings, 1 reply; 5+ messages in thread From: Aveline Noir @ 2026-11-21 12:39 UTC (permalink / raw) To: SJ Park Cc: Andrew Morton, arijit.desaii, Jonathan Corbet, damon, linux-doc, linux-mm, Randy Dunlap, sashiko-bot, sashiko-reviews, Shuah Khan Hi SJ, On Thu, 19 Nov 2026 22:07:36 -0800 SJ Park wrote: > Set 0.5 milliseconds per second > (0.5%) as the default auto-tuning target memory pressure ratio. 0.5 ms per second comes out to 0.05%. > +static unsigned long quota_mem_pressure_us __read_mostly = 500; With a fixed 500 us target, maybe a longer aggregation interval also lengthen the PSI measurement window. For example, if the quota ends up being reset every 2 s, should 1000 us of stalls still be compared against 500 us? If so, the tuner would drop the effective quota to 1 byte, skipping pageout for the next quota window. Thanks, Aveline Noir ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC PATCH 2/4] mm/damon/reclaim: set memory PSI 0.05% as default quota goal 2026-11-21 12:39 ` [RFC PATCH 2/4] mm/damon/reclaim: set memory PSI 0.05% as default quota goal Aveline Noir @ 2026-11-21 17:23 ` SJ Park 0 siblings, 0 replies; 5+ messages in thread From: SJ Park @ 2026-11-21 17:23 UTC (permalink / raw) To: Aveline Noir Cc: SJ Park, Andrew Morton, arijit.desaii, Jonathan Corbet, damon, linux-doc, linux-mm, Randy Dunlap, sashiko-bot, sashiko-reviews, Shuah Khan Hi Aveline, On Sat, 21 Nov 2026 23:39:16 +1100 Aveline Noir <jm5905938@gmail.com> wrote: > Hi SJ, > > On Thu, 19 Nov 2026 22:07:36 -0800 SJ Park wrote: > > > Set 0.5 milliseconds per second > > (0.5%) as the default auto-tuning target memory pressure ratio. > > 0.5 ms per second comes out to 0.05%. > > > +static unsigned long quota_mem_pressure_us __read_mostly = 500; > > With a fixed 500 us target, maybe a longer aggregation interval also > lengthen the PSI measurement window. For example, if the quota ends up > being reset every 2 s, should 1000 us of stalls still be compared > against 500 us? If so, the tuner would drop the effective quota > to 1 byte, skipping pageout for the next quota window. DAMOS quota is not reset for aggregation interval. It has a separate interval for quota reset. It is exposed to users via quotqa_reset_interval_ms parameter. The default value is 1 second. The quota reset interval is evaluated for every sampling interval, though. If the sampling interval is tuned to be larger than 1 second, the problem Aveline mentioned could happen. But, I'm not sure if it could be a real problem. Reclaiming more than expected is a definite problem that can degrade the system performance. Reclaiming less than expected is less concerning, as long as the extent is not too much. It doesn't regress something. Anyway this is a best effort proactive reclamation. We could revisit this if it becomes clear some real users find it as a problem. Thanks, SJ [...] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-11-21 17:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 6:07 [RFC PATCH 0/4] mm/damon/reclaim: enable auto-tuning features by default SJ Park
2026-11-20 6:07 ` [RFC PATCH 4/4] Docs/admin-guide/mm/damon/reclaim: update for changed default parameters SJ Park
2026-11-21 1:53 ` [RFC PATCH 0/4] mm/damon/reclaim: enable auto-tuning features by default SJ Park
[not found] ` <20261120060741.92121-3-sj@kernel.org>
2026-11-21 12:39 ` [RFC PATCH 2/4] mm/damon/reclaim: set memory PSI 0.05% as default quota goal Aveline Noir
2026-11-21 17:23 ` SJ Park
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox