Linux Documentation
 help / color / mirror / Atom feed
From: Pratyush Yadav <pratyush@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Pratyush Yadav <pratyush@kernel.org>,
	 Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Michael Walle <mwalle@kernel.org>,
	 Takahiro Kuwano <takahiro.kuwano@infineon.com>,
	 Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Jonathan Corbet <corbet@lwn.net>,
	 Shuah Khan <skhan@linuxfoundation.org>,
	 Sean Anderson <sean.anderson@linux.dev>,
	 Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	 Steam Lin <STLin2@winbond.com>,
	linux-mtd@lists.infradead.org,  linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org,  stable@kernel.org
Subject: Re: [PATCH v5 04/28] mtd: spi-nor: swp: Improve locking user experience
Date: Tue, 26 May 2026 17:20:06 +0200	[thread overview]
Message-ID: <2vxzcxyi42qh.fsf@kernel.org> (raw)
In-Reply-To: <87v7cakz7u.fsf@bootlin.com> (Miquel Raynal's message of "Tue, 26 May 2026 16:44:05 +0200")

On Tue, May 26 2026, Miquel Raynal wrote:

> Hi Pratyush,
>
>> And here's what I am thinking: the first 9 patches are reviewed and good
>> to go. I want to land them in this merge window so we cut down your
>> patchset and land stuff sooner.
>>
>> Unfortunately I just can't seem to find time to review this series so I
>> hope this helps some at least.
>
> I know what the maintainer load can be, sometimes it does not play well
> with the rest of the your personal and professional duties. But the
> series has already been on the list for about 8 months, it's been looked
> at by other people, the ones who had enough time to dedicate to it. From
> my perspective, asking such contributions to wait indefinitely and then
> suggesting partial application without a technical reason is not a
> sustainable way to handle contributions. This series has not moved much,
> it could have been applied *much* earlier. I've now addressed most of
> the comments from Sashiko, v6 is coming, further improving the quality
> for sure, as there were bugs - there are always. I am of course happy to
> address further technical concerns, if there are any, but I would
> strongly prefer merging the series as the coherent set it was intended
> to be, rather than only taking the preparatory parts.

Unfortunately I am only a patch monkey for SPI NOR these days and do not
have any time to do reviews, especially for big series. I mainly check
for reviewed patches and try to apply them. Even that is becoming harder
these days since I am more busy at new $DAYJOB.

I understand your frustration, and do take the blame for this, but
unfortunately can't promise anything better in the future. We pretty
much don't have any active reviewers in SPI NOR. Michael and Tudor are
also short on time these days. If your employer cares about SPI NOR,
perhaps you can encourage them to support developers in helping out with
reviews and maintenance.

Applying the reviewed patches reduces the total patchset size and does
make things easier to review and land. So I don't get why you are so
opposed to the idea.

But anyway, I'll bite the bullet here and apply the series. You
generally have high quality patches so I am not super worried about this
to begin with. We can deal with the bugs or shortcomings later I
suppose...

>
> On top of that, as mentioned previously, I now have additional spi-nor
> improvements and cleanups waiting behind this series. Keeping such a
> large stack of out of tree patches for months is becoming painful to
> maintain.
>
> Thanks,
> Miquèl

-- 
Regards,
Pratyush Yadav

  reply	other threads:[~2026-05-26 15:20 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07 16:46 [PATCH v5 00/28] mtd: spi-nor: Enhance software protection Miquel Raynal
2026-05-07 16:46 ` [PATCH v5 01/28] mtd: spi-nor: Drop duplicate Kconfig dependency Miquel Raynal
2026-05-07 16:46 ` [PATCH v5 02/28] mtd: spi-nor: debugfs: Fix the flags list Miquel Raynal
2026-05-07 16:46 ` [PATCH v5 03/28] mtd: spi-nor: Make sure the QE bit is kept enabled if useful Miquel Raynal
2026-05-26 10:31   ` Pratyush Yadav
2026-05-07 16:46 ` [PATCH v5 04/28] mtd: spi-nor: swp: Improve locking user experience Miquel Raynal
2026-05-22  9:10   ` Tudor Ambarus
2026-05-22 15:55     ` Miquel Raynal
2026-05-22 16:07       ` Tudor Ambarus
2026-05-22 16:39         ` Miquel Raynal
2026-05-26 10:39           ` Pratyush Yadav
2026-05-26 14:44             ` Miquel Raynal
2026-05-26 15:20               ` Pratyush Yadav [this message]
2026-05-07 16:46 ` [PATCH v5 05/28] mtd: spi-nor: Improve opcodes documentation Miquel Raynal
2026-05-07 16:46 ` [PATCH v5 06/28] mtd: spi-nor: debugfs: Align variable access with the rest of the file Miquel Raynal
2026-05-07 16:46 ` [PATCH v5 07/28] mtd: spi-nor: debugfs: Enhance output Miquel Raynal
2026-05-07 16:46 ` [PATCH v5 08/28] mtd: spi-nor: swp: Explain the MEMLOCK ioctl implementation behaviour Miquel Raynal
2026-05-07 16:46 ` [PATCH v5 09/28] mtd: spi-nor: swp: Clarify a comment Miquel Raynal
2026-05-07 16:46 ` [PATCH v5 10/28] mtd: spi-nor: swp: Use a pointer for SR instead of a single byte Miquel Raynal
2026-05-07 16:46 ` [PATCH v5 11/28] mtd: spi-nor: swp: Create a helper that writes SR, CR and checks Miquel Raynal
2026-05-07 16:46 ` [PATCH v5 12/28] mtd: spi-nor: swp: Rename a mask Miquel Raynal
2026-05-22  9:37   ` Tudor Ambarus
2026-05-07 16:46 ` [PATCH v5 13/28] mtd: spi-nor: swp: Create a TB intermediate variable Miquel Raynal
2026-05-22  9:39   ` Tudor Ambarus
2026-05-22 16:06     ` Miquel Raynal
2026-05-22 16:19       ` Tudor Ambarus
2026-05-07 16:46 ` [PATCH v5 14/28] mtd: spi-nor: swp: Create helpers for building the SR register Miquel Raynal
2026-05-22  9:56   ` Tudor Ambarus
2026-05-22 16:35     ` Miquel Raynal
2026-05-07 16:46 ` [PATCH v5 15/28] mtd: spi-nor: swp: Simplify checking the locked/unlocked range Miquel Raynal
2026-05-07 16:46 ` [PATCH v5 16/28] mtd: spi-nor: swp: Cosmetic changes Miquel Raynal
2026-05-07 16:46 ` [PATCH v5 17/28] mtd: spi-nor: Create a local SR cache Miquel Raynal
2026-05-07 16:46 ` [PATCH v5 18/28] mtd: spi-nor: debugfs: Add locking support Miquel Raynal
2026-05-07 16:47 ` [PATCH v5 19/28] mtd: spi-nor: debugfs: Add a locked sectors map Miquel Raynal
2026-05-07 16:47 ` [PATCH v5 20/28] mtd: spi-nor: Add steps for testing locking support Miquel Raynal
2026-05-07 16:47 ` [PATCH v5 21/28] mtd: spi-nor: swp: Add support for the complement feature Miquel Raynal
2026-05-07 16:47 ` [PATCH v5 22/28] mtd: spi-nor: Add steps for testing locking with CMP Miquel Raynal
2026-05-07 16:47 ` [PATCH v5 23/28] mtd: spi-nor: winbond: Add W25H512NWxxAM CMP locking support Miquel Raynal
2026-05-07 16:47 ` [PATCH v5 24/28] mtd: spi-nor: winbond: Add W25H01NWxxAM " Miquel Raynal
2026-05-07 16:47 ` [PATCH v5 25/28] mtd: spi-nor: winbond: Add W25H02NWxxAM " Miquel Raynal
2026-05-07 16:47 ` [PATCH v5 26/28] mtd: spi-nor: winbond: Add W25H01NWxxIQ " Miquel Raynal
2026-05-07 16:47 ` [PATCH v5 27/28] mtd: spi-nor: winbond: Add W25Q01NWxxIM " Miquel Raynal
2026-05-07 16:47 ` [PATCH v5 28/28] mtd: spi-nor: winbond: Add W25Q02NWxxIM " Miquel Raynal
2026-05-22  9:07 ` [PATCH v5 00/28] mtd: spi-nor: Enhance software protection Tudor Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2vxzcxyi42qh.fsf@kernel.org \
    --to=pratyush@kernel.org \
    --cc=STLin2@winbond.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mwalle@kernel.org \
    --cc=richard@nod.at \
    --cc=sean.anderson@linux.dev \
    --cc=skhan@linuxfoundation.org \
    --cc=stable@kernel.org \
    --cc=takahiro.kuwano@infineon.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox