From: Aditya Garg <gargaditya08@live.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Aun-Ali Zaidi <admin@kodeit.net>,
Maxime Ripard <mripard@kernel.org>,
"airlied@redhat.com" <airlied@redhat.com>,
Simona Vetter <simona@ffwll.ch>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
"senozhatsky@chromium.org" <senozhatsky@chromium.org>,
Jonathan Corbet <corbet@lwn.net>,
Andrew Morton <akpm@linux-foundation.org>,
"apw@canonical.com" <apw@canonical.com>,
"joe@perches.com" <joe@perches.com>,
"dwaipayanray1@gmail.com" <dwaipayanray1@gmail.com>,
"lukas.bulwahn@gmail.com" <lukas.bulwahn@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Asahi Linux Mailing List <asahi@lists.linux.dev>
Subject: [PATCH 2/2] drm/appletbdm: use %p4cl instead of %p4cc
Date: Wed, 12 Mar 2025 09:06:42 +0000 [thread overview]
Message-ID: <33F3F7E2-24AE-4F29-9053-3B502D075BA8@live.com> (raw)
In-Reply-To: <ABAEA9D0-97CB-4ADD-9606-A12D5815335A@live.com>
From: Aditya Garg <gargaditya08@live.com>
Due to lack of a proper printk format, %p4cc was being used instead of
%p4cl for the purpose of printing FourCCs. But the disadvange was that
they were being printed in a reverse order. %p4cl should correct this
issue.
Signed-off-by: Aditya Garg <gargaditya08@live.com>
---
drivers/gpu/drm/tiny/appletbdrm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tiny/appletbdrm.c b/drivers/gpu/drm/tiny/appletbdrm.c
index 703b9a41a..751b05753 100644
--- a/drivers/gpu/drm/tiny/appletbdrm.c
+++ b/drivers/gpu/drm/tiny/appletbdrm.c
@@ -212,7 +212,7 @@ static int appletbdrm_read_response(struct appletbdrm_device *adev,
}
if (response->msg != expected_response) {
- drm_err(drm, "Unexpected response from device (expected %p4cc found %p4cc)\n",
+ drm_err(drm, "Unexpected response from device (expected %p4cl found %p4cl)\n",
&expected_response, &response->msg);
return -EIO;
}
@@ -286,7 +286,7 @@ static int appletbdrm_get_information(struct appletbdrm_device *adev)
}
if (pixel_format != APPLETBDRM_PIXEL_FORMAT) {
- drm_err(drm, "Encountered unknown pixel format (%p4cc)\n", &pixel_format);
+ drm_err(drm, "Encountered unknown pixel format (%p4cl)\n", &pixel_format);
ret = -EINVAL;
goto free_info;
}
--
2.47.1
next prev parent reply other threads:[~2025-03-12 9:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 9:04 [PATCH 0/2] Use proper printk format in appletbdrm Aditya Garg
2025-03-12 9:05 ` [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc Aditya Garg
2025-03-12 11:46 ` Thomas Zimmermann
2025-03-12 11:49 ` Aditya Garg
2025-03-12 11:58 ` Thomas Zimmermann
2025-03-12 12:03 ` Aditya Garg
2025-03-12 12:07 ` Aditya Garg
2025-03-12 15:34 ` Sven Peter
2025-03-12 19:14 ` Aditya Garg
2025-03-12 19:28 ` Andy Shevchenko
2025-03-12 19:35 ` Aditya Garg
2025-03-12 19:51 ` Andy Shevchenko
2025-03-13 7:26 ` Aditya Garg
2025-03-13 8:48 ` Andy Shevchenko
2025-03-13 8:53 ` Aditya Garg
2025-03-13 8:56 ` Andy Shevchenko
2025-03-13 9:13 ` Aditya Garg
2025-03-13 10:48 ` Petr Mladek
2025-03-13 11:06 ` Aditya Garg
2025-03-13 13:24 ` Andy Shevchenko
2025-03-13 17:40 ` Kees Cook
2025-03-13 17:42 ` Aditya Garg
2025-03-14 0:05 ` Kees Cook
2025-03-12 9:06 ` Aditya Garg [this message]
2025-03-12 11:51 ` [PATCH 2/2] drm/appletbdm: use %p4cl instead of %p4cc Thomas Zimmermann
2025-03-12 14:51 ` andriy.shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33F3F7E2-24AE-4F29-9053-3B502D075BA8@live.com \
--to=gargaditya08@live.com \
--cc=admin@kodeit.net \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=apw@canonical.com \
--cc=asahi@lists.linux.dev \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lukas.bulwahn@gmail.com \
--cc=marcan@marcan.st \
--cc=mripard@kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=simona@ffwll.ch \
--cc=sven@svenpeter.dev \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox