From: "andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Aditya Garg <gargaditya08@live.com>,
Aun-Ali Zaidi <admin@kodeit.net>,
Maxime Ripard <mripard@kernel.org>,
"airlied@redhat.com" <airlied@redhat.com>,
Simona Vetter <simona@ffwll.ch>, Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
"senozhatsky@chromium.org" <senozhatsky@chromium.org>,
Jonathan Corbet <corbet@lwn.net>,
Andrew Morton <akpm@linux-foundation.org>,
"apw@canonical.com" <apw@canonical.com>,
"joe@perches.com" <joe@perches.com>,
"dwaipayanray1@gmail.com" <dwaipayanray1@gmail.com>,
"lukas.bulwahn@gmail.com" <lukas.bulwahn@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Asahi Linux Mailing List <asahi@lists.linux.dev>
Subject: Re: [PATCH 2/2] drm/appletbdm: use %p4cl instead of %p4cc
Date: Wed, 12 Mar 2025 16:51:59 +0200 [thread overview]
Message-ID: <Z9Gfj_f0Ug7vLIfd@smile.fi.intel.com> (raw)
In-Reply-To: <be2f49b5-dcdc-4954-b650-90670dfa70b9@suse.de>
On Wed, Mar 12, 2025 at 12:51:33PM +0100, Thomas Zimmermann wrote:
> Am 12.03.25 um 10:06 schrieb Aditya Garg:
...
> If you want to print out protocol-header tokens, why not use formatting
> macros as we do with DRM mode? There's one for the format string [1] and one
> for the argument. [2] It's not as fancy as the conversion code, but you'll
> get something for your driver that is easily understandable.
The benefit of the specific code formatters as in this patch at least in the
stack usage and hence a lot of code generated again and again. I believe you
can get rid of dozens of (kilo?) bytes in DRM on top of compensating this in
the printf() implementation. This backs us to the discussion on how the best
would be to implement custom printf() specifiers...
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-03-12 14:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 9:04 [PATCH 0/2] Use proper printk format in appletbdrm Aditya Garg
2025-03-12 9:05 ` [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc Aditya Garg
2025-03-12 11:46 ` Thomas Zimmermann
2025-03-12 11:49 ` Aditya Garg
2025-03-12 11:58 ` Thomas Zimmermann
2025-03-12 12:03 ` Aditya Garg
2025-03-12 12:07 ` Aditya Garg
2025-03-12 15:34 ` Sven Peter
2025-03-12 19:14 ` Aditya Garg
2025-03-12 19:28 ` Andy Shevchenko
2025-03-12 19:35 ` Aditya Garg
2025-03-12 19:51 ` Andy Shevchenko
2025-03-13 7:26 ` Aditya Garg
2025-03-13 8:48 ` Andy Shevchenko
2025-03-13 8:53 ` Aditya Garg
2025-03-13 8:56 ` Andy Shevchenko
2025-03-13 9:13 ` Aditya Garg
2025-03-13 10:48 ` Petr Mladek
2025-03-13 11:06 ` Aditya Garg
2025-03-13 13:24 ` Andy Shevchenko
2025-03-13 17:40 ` Kees Cook
2025-03-13 17:42 ` Aditya Garg
2025-03-14 0:05 ` Kees Cook
2025-03-12 9:06 ` [PATCH 2/2] drm/appletbdm: use %p4cl instead of %p4cc Aditya Garg
2025-03-12 11:51 ` Thomas Zimmermann
2025-03-12 14:51 ` andriy.shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9Gfj_f0Ug7vLIfd@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=admin@kodeit.net \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=asahi@lists.linux.dev \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=dwaipayanray1@gmail.com \
--cc=gargaditya08@live.com \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lukas.bulwahn@gmail.com \
--cc=marcan@marcan.st \
--cc=mripard@kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=simona@ffwll.ch \
--cc=sven@svenpeter.dev \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox