Re: [PATCH v6 03/11] dt-bindings: mfd: add documentation for S2MU005 PMIC

[Krzysztof Kozlowski <krzk@kernel.org>]

On 19/05/2026 14:07, Kaustabh Chakraborty wrote:
>>>>
>>>> I don't think the compatible should be here, but I also don't want to
>>>> stall that patchset. I understand that it is inconsistent review from my
>>>> side, because other similar patchsets receive comment to drop the
>>>> compatible. But I don't think we will be fair asking to drop the
>>>> compatible now, when we did not ask for that in the early versions at all.
>>>
>>>
>>> I think you misunderstood, we were talking about the ordering of the
>>> properties in the binding file being alphanumerical, rather than the
>>> more typical approach of approximately following the order of
>>> dts-coding-style.
>>
>>
>> Ah, then I misunderstood and, even though it is a nit, I do care because
>> old code is then used for new patches. Bindings follow DTS rules, thus
>> should be:
>> 1. compatible
>> 2. reg
>> 3. core properties
>> 4. vendor properties
>>
>> Kaustabh, can you change it please?
> 
> Ack, will do that in v8 then.
> 
> While at it, do you also want me to drop the multi-led compatible string?
> So it would be:

Yes

> 
>   multi-led:
>     $ref: /schemas/leds/leds-class-multicolor.yaml#

with "unevaluatedProperties: false"


Best regards,
Krzysztof