From: Jonathan Corbet <corbet@lwn.net>
To: Chen-Shi-Hong <eric039eric@gmail.com>, linux@leemhuis.info
Cc: skhan@linuxfoundation.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Chen-Shi-Hong <eric039eric@gmail.com>
Subject: Re: [PATCH v3] docs: reporting-issues: replace "these advices" with "all of this advice"
Date: Wed, 13 May 2026 13:43:38 -0600 [thread overview]
Message-ID: <874ikbksd1.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20260513174009.1260-1-eric039eric@gmail.com>
Chen-Shi-Hong <eric039eric@gmail.com> writes:
You are getting closer, a couple of other details...
> "Advice" is an uncountable noun, so "these advices" is grammatically
> incorrect.
>
> Replace it with "all of this advice" instead, which keeps the sentence
> grammatical while also making it clear that it refers to the full set of
> recommendations in the paragraph.
>
> Signed-off-by: Chen-Shi-Hong <eric039eric@gmail.com>
>
> v3:
> - resend against the original base as requested
> - replace "these advices" directly with "all of this advice"
>
> v2:
> - use "all of this advice" based on review feedback
It is good to include the changes with each version, but it should go
below the "---" line so that the maintainer doesn't have to edit it out
at apply time.
> ---
> Documentation/admin-guide/reporting-issues.rst | 4 ++--
>
> 1 file changed, 2 insertions(+), 2 deletions(-)
Also, please send new versions as a separate thread rather than as a
response to a previous posting.
Thanks,
jon
prev parent reply other threads:[~2026-05-13 19:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 15:04 [PATCH] docs: reporting-issues: clarify advice wording Chen-Shi-Hong
2026-05-13 8:08 ` Thorsten Leemhuis
2026-05-13 17:39 ` [PATCH v3] docs: reporting-issues: replace "these advices" with "all of this advice" Chen-Shi-Hong
2026-05-13 19:43 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ikbksd1.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=eric039eric@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox