From: Jonathan Corbet <corbet@lwn.net>
To: Yahya Toubali <yahya@yahyatoubali.me>, mpearson-lenovo@squebb.ca
Cc: linux-doc@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, yahya@yahyatoubali.me
Subject: Re: [PATCH] Documentation: wmi: lenovo-wmi-other: Document intentional BIOS misspelling
Date: Sun, 19 Jul 2026 11:44:13 -0600 [thread overview]
Message-ID: <87o6g250ya.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20260719173710.2367930-1-yahya@yahyatoubali.me>
Yahya Toubali <yahya@yahyatoubali.me> writes:
> The spelling "Minumum" in the FanMinSpeed entry is intentionally kept
> as-is because it reflects the actual string returned by the system BIOS.
> Add an explanatory note to prevent future redundant spelling-fix submissions.
>
> Suggested-by: Jonathan Corbet <corbet@lwn.net>
> Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
>
> Thanks Mark and Jon for the context.
>
> That makes total sense. I dropped the housekeeping typo fix for now to avoid
> unnecessary churn, and this v4 keeps the BIOS spelling but adds the explicit
> note documenting the firmware quirk as suggested.
For future reference, text like this does not belong in the changelog.
You can put it below this line:
> ---
...and the maintainer won't have to strip it out when the patch is
applied.
> Documentation/wmi/devices/lenovo-wmi-other.rst | 4 ++++
> 1 file changed, 4 insertions(+)
One other question: are you writing these patches yourself, or using
some sort of LLM to create them?
Thanks,
jon
next prev parent reply other threads:[~2026-07-19 17:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-18 15:19 [PATCH 1/5] Documentation: proc: fix repeated word 'page' Yahya Toubali
2026-07-18 15:19 ` [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst Yahya Toubali
2026-07-18 16:14 ` Weijie Yuan
2026-07-18 16:16 ` Randy Dunlap
2026-07-18 16:32 ` Weijie Yuan
2026-07-18 16:56 ` [PATCH v3] " Yahya Toubali
2026-07-18 17:24 ` Randy Dunlap
2026-07-19 16:44 ` [PATCH 2/5] " Jonathan Corbet
2026-07-19 17:21 ` Weijie Yuan
2026-07-18 15:19 ` [PATCH 4/5] Documentation: fix spelling typos Yahya Toubali
2026-07-18 16:07 ` Weijie Yuan
2026-07-18 16:56 ` [PATCH v3] " Yahya Toubali
2026-07-19 2:00 ` Mark Pearson
2026-07-19 16:46 ` Jonathan Corbet
2026-07-19 17:37 ` [PATCH] Documentation: wmi: lenovo-wmi-other: Document intentional BIOS misspelling Yahya Toubali
2026-07-19 17:44 ` Jonathan Corbet [this message]
2026-07-19 18:02 ` Weijie Yuan
2026-07-19 22:42 ` Yahya Toubali
2026-07-19 22:54 ` Weijie Yuan
2026-07-20 12:51 ` Jonathan Corbet
2026-07-20 21:06 ` Yahya Toubali
2026-07-18 15:19 ` [PATCH 5/5] Documentation: add SPDX license identifiers to RST files Yahya Toubali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6g250ya.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
--cc=yahya@yahyatoubali.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox