[PATCH 1/1] docs: submitting-patches: Emphasise the requirement to Cc: stable when using Fixes: tag

[PATCH 1/1] docs: submitting-patches: Emphasise the requirement to Cc: stable when using Fixes: tag

[Lee Jones]

Clear-up any confusion surrounding the Fixes: tag with regards to the
need to Cc: the stable mailing list when submitting stable patch
candidates.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 Documentation/process/submitting-patches.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
index 7c97ad580e7d0..636ef067c1565 100644
--- a/Documentation/process/submitting-patches.rst
+++ b/Documentation/process/submitting-patches.rst
@@ -554,7 +554,8 @@ is used to make it easy to determine where a bug originated, which can help
 review a bug fix. This tag also assists the stable kernel team in determining
 which stable kernel versions should receive your fix. This is the preferred
 method for indicating a bug fixed by the patch. See :ref:`describe_changes`
-for more details.
+for more details. Attaching a Fixes: tag does not replace the requirement to
+Cc: stable@vger.kernel.org on all stable patch candidates.
 
 .. _the_canonical_patch_format:
 
-- 
2.25.1

Re: [PATCH 1/1] docs: submitting-patches: Emphasise the requirement to Cc: stable when using Fixes: tag

[Greg Kroah-Hartman]

On Wed, Jan 13, 2021 at 02:23:47PM +0000, Lee Jones wrote:
> Clear-up any confusion surrounding the Fixes: tag with regards to the
> need to Cc: the stable mailing list when submitting stable patch
> candidates.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  Documentation/process/submitting-patches.rst | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index 7c97ad580e7d0..636ef067c1565 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -554,7 +554,8 @@ is used to make it easy to determine where a bug originated, which can help
>  review a bug fix. This tag also assists the stable kernel team in determining
>  which stable kernel versions should receive your fix. This is the preferred
>  method for indicating a bug fixed by the patch. See :ref:`describe_changes`
> -for more details.
> +for more details. Attaching a Fixes: tag does not replace the requirement to
> +Cc: stable@vger.kernel.org on all stable patch candidates.

Want to just link to the "stable kernel rules" document here to show
the proper way to do this is documented there?

thanks,

greg k-h

Re: [PATCH 1/1] docs: submitting-patches: Emphasise the requirement to Cc: stable when using Fixes: tag

[Lee Jones]

On Wed, 13 Jan 2021, Greg Kroah-Hartman wrote:

> On Wed, Jan 13, 2021 at 02:23:47PM +0000, Lee Jones wrote:
> > Clear-up any confusion surrounding the Fixes: tag with regards to the
> > need to Cc: the stable mailing list when submitting stable patch
> > candidates.
> > 
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Jonathan Corbet <corbet@lwn.net>
> > Cc: linux-doc@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >  Documentation/process/submitting-patches.rst | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> > index 7c97ad580e7d0..636ef067c1565 100644
> > --- a/Documentation/process/submitting-patches.rst
> > +++ b/Documentation/process/submitting-patches.rst
> > @@ -554,7 +554,8 @@ is used to make it easy to determine where a bug originated, which can help
> >  review a bug fix. This tag also assists the stable kernel team in determining
> >  which stable kernel versions should receive your fix. This is the preferred
> >  method for indicating a bug fixed by the patch. See :ref:`describe_changes`
> > -for more details.
> > +for more details. Attaching a Fixes: tag does not replace the requirement to
> > +Cc: stable@vger.kernel.org on all stable patch candidates.
> 
> Want to just link to the "stable kernel rules" document here to show
> the proper way to do this is documented there?

I think this needs to be clearly stated here.

What if we linked to the rules document *as well*?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 1/1] docs: submitting-patches: Emphasise the requirement to Cc: stable when using Fixes: tag

[Greg Kroah-Hartman]

On Wed, Jan 13, 2021 at 04:08:59PM +0000, Lee Jones wrote:
> On Wed, 13 Jan 2021, Greg Kroah-Hartman wrote:
> 
> > On Wed, Jan 13, 2021 at 02:23:47PM +0000, Lee Jones wrote:
> > > Clear-up any confusion surrounding the Fixes: tag with regards to the
> > > need to Cc: the stable mailing list when submitting stable patch
> > > candidates.
> > > 
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: Jonathan Corbet <corbet@lwn.net>
> > > Cc: linux-doc@vger.kernel.org
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > ---
> > >  Documentation/process/submitting-patches.rst | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> > > index 7c97ad580e7d0..636ef067c1565 100644
> > > --- a/Documentation/process/submitting-patches.rst
> > > +++ b/Documentation/process/submitting-patches.rst
> > > @@ -554,7 +554,8 @@ is used to make it easy to determine where a bug originated, which can help
> > >  review a bug fix. This tag also assists the stable kernel team in determining
> > >  which stable kernel versions should receive your fix. This is the preferred
> > >  method for indicating a bug fixed by the patch. See :ref:`describe_changes`
> > > -for more details.
> > > +for more details. Attaching a Fixes: tag does not replace the requirement to
> > > +Cc: stable@vger.kernel.org on all stable patch candidates.
> > 
> > Want to just link to the "stable kernel rules" document here to show
> > the proper way to do this is documented there?
> 
> I think this needs to be clearly stated here.
> 
> What if we linked to the rules document *as well*?

Sure, that works for me.

thanks,

greg k-h