* Re: [PATCH] firmware: arm_scmi: Clarify Raw per-channel ABI documentation [not found] <20230120122326.1932614-1-cristian.marussi@arm.com> @ 2023-01-20 12:43 ` Bagas Sanjaya 2023-01-20 14:34 ` Cristian Marussi 0 siblings, 1 reply; 2+ messages in thread From: Bagas Sanjaya @ 2023-01-20 12:43 UTC (permalink / raw) To: Cristian Marussi, linux-kernel, linux-arm-kernel, Linux Documentation Cc: sudeep.holla, Vincent Guittot [-- Attachment #1: Type: text/plain, Size: 2030 bytes --] [Also Cc: linux-doc list] On Fri, Jan 20, 2023 at 12:23:26PM +0000, Cristian Marussi wrote: > diff --git a/Documentation/ABI/testing/debugfs-scmi-raw b/Documentation/ABI/testing/debugfs-scmi-raw > index 5468ec08c084..b1c505ed444c 100644 > --- a/Documentation/ABI/testing/debugfs-scmi-raw > +++ b/Documentation/ABI/testing/debugfs-scmi-raw > @@ -80,9 +80,13 @@ Description: SCMI Raw synchronous message injection/snooping facility; write > Each write to the entry causes one command request to be built > and sent while the replies are read back one message at time > (receiving an EOF at each message boundary). > + Channel identifier <m> matches the SCMI protocol number which > + has been associated with this transport channel in the DT > + description, with Base protocol number 0x10 being the default > + channel for this instance. s/Base/base/ > Note that these per-channel entries rooted at <..>/channels > exist only if the transport is configured to have more than > - one channel. > + one default channel. > Users: Debugging, any userspace test suite > > What: /sys/kernel/debug/scmi/<n>/raw/channels/<m>/message_async > @@ -103,7 +107,11 @@ Description: SCMI Raw asynchronous message injection/snooping facility; write > Each write to the entry causes one command request to be built > and sent while the replies are read back one message at time > (receiving an EOF at each message boundary). > + Channel identifier <m> matches the SCMI protocol number which > + has been associated with this transport channel in the DT > + description, with Base protocol number 0x10 being the default > + channel for this instance. Same here. > Note that these per-channel entries rooted at <..>/channels > exist only if the transport is configured to have more than > - one channel. > + one default channel. > Users: Debugging, any userspace test suite Otherwise LGTM. -- An old man doll... just what I always wanted! - Clara [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] firmware: arm_scmi: Clarify Raw per-channel ABI documentation 2023-01-20 12:43 ` [PATCH] firmware: arm_scmi: Clarify Raw per-channel ABI documentation Bagas Sanjaya @ 2023-01-20 14:34 ` Cristian Marussi 0 siblings, 0 replies; 2+ messages in thread From: Cristian Marussi @ 2023-01-20 14:34 UTC (permalink / raw) To: Bagas Sanjaya Cc: linux-kernel, linux-arm-kernel, Linux Documentation, sudeep.holla, Vincent Guittot On Fri, Jan 20, 2023 at 07:43:30PM +0700, Bagas Sanjaya wrote: > [Also Cc: linux-doc list] > Sorry for missing the Cc but get_maintainer.pl did not say anything about this ABI docs patches. > On Fri, Jan 20, 2023 at 12:23:26PM +0000, Cristian Marussi wrote: > > diff --git a/Documentation/ABI/testing/debugfs-scmi-raw b/Documentation/ABI/testing/debugfs-scmi-raw > > index 5468ec08c084..b1c505ed444c 100644 > > --- a/Documentation/ABI/testing/debugfs-scmi-raw > > +++ b/Documentation/ABI/testing/debugfs-scmi-raw > > @@ -80,9 +80,13 @@ Description: SCMI Raw synchronous message injection/snooping facility; write > > Each write to the entry causes one command request to be built > > and sent while the replies are read back one message at time > > (receiving an EOF at each message boundary). > > + Channel identifier <m> matches the SCMI protocol number which > > + has been associated with this transport channel in the DT > > + description, with Base protocol number 0x10 being the default > > + channel for this instance. > > s/Base/base/ > Thought that being an SCMI protocol name definitions would have to be capitalized. > > Note that these per-channel entries rooted at <..>/channels > > exist only if the transport is configured to have more than > > - one channel. > > + one default channel. > > Users: Debugging, any userspace test suite > > > > What: /sys/kernel/debug/scmi/<n>/raw/channels/<m>/message_async > > @@ -103,7 +107,11 @@ Description: SCMI Raw asynchronous message injection/snooping facility; write > > Each write to the entry causes one command request to be built > > and sent while the replies are read back one message at time > > (receiving an EOF at each message boundary). > > + Channel identifier <m> matches the SCMI protocol number which > > + has been associated with this transport channel in the DT > > + description, with Base protocol number 0x10 being the default > > + channel for this instance. > > Same here. > > > Note that these per-channel entries rooted at <..>/channels > > exist only if the transport is configured to have more than > > - one channel. > > + one default channel. > > Users: Debugging, any userspace test suite > > Otherwise LGTM. > Thanks, Cristian ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-20 14:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230120122326.1932614-1-cristian.marussi@arm.com>
2023-01-20 12:43 ` [PATCH] firmware: arm_scmi: Clarify Raw per-channel ABI documentation Bagas Sanjaya
2023-01-20 14:34 ` Cristian Marussi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox