Re: security/landlock/ruleset.c:644: warning: Function parameter or struct member '' not described in 'landlock_init_layer_masks'

Re: security/landlock/ruleset.c:644: warning: Function parameter or struct member '' not described in 'landlock_init_layer_masks'

[Mickaël Salaün]

scripts/kernel-doc definitely has an issue with pointers to array.

On Mon, Jan 06, 2025 at 05:07:32AM +0800, kernel test robot wrote:
> Hi Konstantin,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   9244696b34f2a626d7468864420ab6a47289bf10
> commit: 0e7410112964168a65578002269ae3b80b207936 landlock: Move and rename layer helpers
> date:   1 year, 2 months ago
> config: csky-randconfig-r026-20230729 (https://download.01.org/0day-ci/archive/20250106/202501060543.XG0RGoPB-lkp@intel.com/config)
> compiler: csky-linux-gcc (GCC) 12.4.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250106/202501060543.XG0RGoPB-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202501060543.XG0RGoPB-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    Use of uninitialized value $param in regexp compilation at scripts/kernel-doc line 1532, <IN_FILE> line 182.
>    Use of uninitialized value $actual in substitution (s///) at scripts/kernel-doc line 1484, <IN_FILE> line 182.
>    Use of uninitialized value $actual in substitution (s///) at scripts/kernel-doc line 1484, <IN_FILE> line 182.
>    Use of uninitialized value $param in substitution (s///) at scripts/kernel-doc line 1588, <IN_FILE> line 182.
>    Use of uninitialized value $param in pattern match (m//) at scripts/kernel-doc line 1616, <IN_FILE> line 182.
>    Use of uninitialized value $param in hash element at scripts/kernel-doc line 1626, <IN_FILE> line 182.
>    Use of uninitialized value $param in pattern match (m//) at scripts/kernel-doc line 1626, <IN_FILE> line 182.
>    Use of uninitialized value $param in hash element at scripts/kernel-doc line 1627, <IN_FILE> line 182.
>    Use of uninitialized value $param in pattern match (m//) at scripts/kernel-doc line 1629, <IN_FILE> line 182.
>    Use of uninitialized value $param in concatenation (.) or string at scripts/kernel-doc line 1630, <IN_FILE> line 182.
>    security/landlock/ruleset.c:182: warning: Function parameter or struct member '' not described in 'insert_rule'
>    Use of uninitialized value $param in hash element at scripts/kernel-doc line 1645, <IN_FILE> line 182.
>    Use of uninitialized value $parameterlist[2] in join or string at scripts/kernel-doc line 1806, <IN_FILE> line 182.
>    security/landlock/ruleset.c:182: warning: Excess function parameter 'layers' description in 'insert_rule'
>    Use of uninitialized value $param in regexp compilation at scripts/kernel-doc line 1532, <IN_FILE> line 644.
>    Use of uninitialized value $actual in substitution (s///) at scripts/kernel-doc line 1484, <IN_FILE> line 644.
>    Use of uninitialized value $actual in substitution (s///) at scripts/kernel-doc line 1484, <IN_FILE> line 644.
>    Use of uninitialized value $param in substitution (s///) at scripts/kernel-doc line 1588, <IN_FILE> line 644.
>    Use of uninitialized value $param in pattern match (m//) at scripts/kernel-doc line 1616, <IN_FILE> line 644.
>    Use of uninitialized value $param in hash element at scripts/kernel-doc line 1626, <IN_FILE> line 644.
>    Use of uninitialized value $param in pattern match (m//) at scripts/kernel-doc line 1626, <IN_FILE> line 644.
>    Use of uninitialized value $param in hash element at scripts/kernel-doc line 1627, <IN_FILE> line 644.
>    Use of uninitialized value $param in pattern match (m//) at scripts/kernel-doc line 1629, <IN_FILE> line 644.
>    Use of uninitialized value $param in concatenation (.) or string at scripts/kernel-doc line 1630, <IN_FILE> line 644.
> >> security/landlock/ruleset.c:644: warning: Function parameter or struct member '' not described in 'landlock_init_layer_masks'
>    Use of uninitialized value $param in hash element at scripts/kernel-doc line 1645, <IN_FILE> line 644.
>    Use of uninitialized value $parameterlist[2] in join or string at scripts/kernel-doc line 1806, <IN_FILE> line 644.
> >> security/landlock/ruleset.c:644: warning: Excess function parameter 'layer_masks' description in 'landlock_init_layer_masks'
> 
> 
> vim +644 security/landlock/ruleset.c
> 
>    626	
>    627	/**
>    628	 * landlock_init_layer_masks - Initialize layer masks from an access request
>    629	 *
>    630	 * Populates @layer_masks such that for each access right in @access_request,
>    631	 * the bits for all the layers are set where this access right is handled.
>    632	 *
>    633	 * @domain: The domain that defines the current restrictions.
>    634	 * @access_request: The requested access rights to check.
>    635	 * @layer_masks: The layer masks to populate.
>    636	 *
>    637	 * Returns: An access mask where each access right bit is set which is handled
>    638	 * in any of the active layers in @domain.
>    639	 */
>    640	access_mask_t landlock_init_layer_masks(
>    641		const struct landlock_ruleset *const domain,
>    642		const access_mask_t access_request,
>    643		layer_mask_t (*const layer_masks)[LANDLOCK_NUM_ACCESS_FS])
>  > 644	{
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

Re: security/landlock/ruleset.c:644: warning: Function parameter or struct member '' not described in 'landlock_init_layer_masks'

[Philip Li]

On Mon, Jan 06, 2025 at 05:18:36PM +0100, Mickaël Salaün wrote:
> scripts/kernel-doc definitely has an issue with pointers to array.

Sorry about these false reports, the bot side will filter out these
invalid kernel-doc issues.

> 
> On Mon, Jan 06, 2025 at 05:07:32AM +0800, kernel test robot wrote:
> > Hi Konstantin,
> > 
> > FYI, the error/warning still remains.
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   9244696b34f2a626d7468864420ab6a47289bf10
> > commit: 0e7410112964168a65578002269ae3b80b207936 landlock: Move and rename layer helpers
> > date:   1 year, 2 months ago
> > config: csky-randconfig-r026-20230729 (https://download.01.org/0day-ci/archive/20250106/202501060543.XG0RGoPB-lkp@intel.com/config)
> > compiler: csky-linux-gcc (GCC) 12.4.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250106/202501060543.XG0RGoPB-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202501060543.XG0RGoPB-lkp@intel.com/
> > 
> > All warnings (new ones prefixed by >>):
> > 
> >    Use of uninitialized value $param in regexp compilation at scripts/kernel-doc line 1532, <IN_FILE> line 182.
> >    Use of uninitialized value $actual in substitution (s///) at scripts/kernel-doc line 1484, <IN_FILE> line 182.
> >    Use of uninitialized value $actual in substitution (s///) at scripts/kernel-doc line 1484, <IN_FILE> line 182.
> >    Use of uninitialized value $param in substitution (s///) at scripts/kernel-doc line 1588, <IN_FILE> line 182.
> >    Use of uninitialized value $param in pattern match (m//) at scripts/kernel-doc line 1616, <IN_FILE> line 182.
> >    Use of uninitialized value $param in hash element at scripts/kernel-doc line 1626, <IN_FILE> line 182.
> >    Use of uninitialized value $param in pattern match (m//) at scripts/kernel-doc line 1626, <IN_FILE> line 182.
> >    Use of uninitialized value $param in hash element at scripts/kernel-doc line 1627, <IN_FILE> line 182.
> >    Use of uninitialized value $param in pattern match (m//) at scripts/kernel-doc line 1629, <IN_FILE> line 182.
> >    Use of uninitialized value $param in concatenation (.) or string at scripts/kernel-doc line 1630, <IN_FILE> line 182.
> >    security/landlock/ruleset.c:182: warning: Function parameter or struct member '' not described in 'insert_rule'
> >    Use of uninitialized value $param in hash element at scripts/kernel-doc line 1645, <IN_FILE> line 182.
> >    Use of uninitialized value $parameterlist[2] in join or string at scripts/kernel-doc line 1806, <IN_FILE> line 182.
> >    security/landlock/ruleset.c:182: warning: Excess function parameter 'layers' description in 'insert_rule'
> >    Use of uninitialized value $param in regexp compilation at scripts/kernel-doc line 1532, <IN_FILE> line 644.
> >    Use of uninitialized value $actual in substitution (s///) at scripts/kernel-doc line 1484, <IN_FILE> line 644.
> >    Use of uninitialized value $actual in substitution (s///) at scripts/kernel-doc line 1484, <IN_FILE> line 644.
> >    Use of uninitialized value $param in substitution (s///) at scripts/kernel-doc line 1588, <IN_FILE> line 644.
> >    Use of uninitialized value $param in pattern match (m//) at scripts/kernel-doc line 1616, <IN_FILE> line 644.
> >    Use of uninitialized value $param in hash element at scripts/kernel-doc line 1626, <IN_FILE> line 644.
> >    Use of uninitialized value $param in pattern match (m//) at scripts/kernel-doc line 1626, <IN_FILE> line 644.
> >    Use of uninitialized value $param in hash element at scripts/kernel-doc line 1627, <IN_FILE> line 644.
> >    Use of uninitialized value $param in pattern match (m//) at scripts/kernel-doc line 1629, <IN_FILE> line 644.
> >    Use of uninitialized value $param in concatenation (.) or string at scripts/kernel-doc line 1630, <IN_FILE> line 644.
> > >> security/landlock/ruleset.c:644: warning: Function parameter or struct member '' not described in 'landlock_init_layer_masks'
> >    Use of uninitialized value $param in hash element at scripts/kernel-doc line 1645, <IN_FILE> line 644.
> >    Use of uninitialized value $parameterlist[2] in join or string at scripts/kernel-doc line 1806, <IN_FILE> line 644.
> > >> security/landlock/ruleset.c:644: warning: Excess function parameter 'layer_masks' description in 'landlock_init_layer_masks'
> > 
> > 
> > vim +644 security/landlock/ruleset.c
> > 
> >    626	
> >    627	/**
> >    628	 * landlock_init_layer_masks - Initialize layer masks from an access request
> >    629	 *
> >    630	 * Populates @layer_masks such that for each access right in @access_request,
> >    631	 * the bits for all the layers are set where this access right is handled.
> >    632	 *
> >    633	 * @domain: The domain that defines the current restrictions.
> >    634	 * @access_request: The requested access rights to check.
> >    635	 * @layer_masks: The layer masks to populate.
> >    636	 *
> >    637	 * Returns: An access mask where each access right bit is set which is handled
> >    638	 * in any of the active layers in @domain.
> >    639	 */
> >    640	access_mask_t landlock_init_layer_masks(
> >    641		const struct landlock_ruleset *const domain,
> >    642		const access_mask_t access_request,
> >    643		layer_mask_t (*const layer_masks)[LANDLOCK_NUM_ACCESS_FS])
> >  > 644	{
> > 
> > -- 
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
>