Linux Documentation
 help / color / mirror / Atom feed
From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: I Hsin Cheng <richard120310@gmail.com>
Cc: corbet@lwn.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: scheduler: completion: Update member of struct completion
Date: Sat, 31 Aug 2024 17:10:33 +0800	[thread overview]
Message-ID: <ZtLeCc4GeZbwiJZ9@visitorckw-System-Product-Name> (raw)
In-Reply-To: <20240828165036.178011-1-richard120310@gmail.com>

On Thu, Aug 29, 2024 at 12:50:36AM +0800, I Hsin Cheng wrote:
> The member "wait" in struct completion isn't of type wait_queue_head_t
> anymore, as it is now "struct swait_queue_head", fix it to match with
> the current implementation.
> 
> Signed-off-by: I Hsin Cheng <richard120310@gmail.com>

LGTM. Feel free to add:

Reviewed-by: Kuan-Wei Chiu <visitorckw@gmail.com>

> ---
>  Documentation/scheduler/completion.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/scheduler/completion.rst b/Documentation/scheduler/completion.rst
> index f19aca2062bd..adf0c0a56d02 100644
> --- a/Documentation/scheduler/completion.rst
> +++ b/Documentation/scheduler/completion.rst
> @@ -51,7 +51,7 @@ which has only two fields::
>  
>  	struct completion {
>  		unsigned int done;
> -		wait_queue_head_t wait;
> +		struct swait_queue_head wait;
>  	};
>  
>  This provides the ->wait waitqueue to place tasks on for waiting (if any), and
> -- 
> 2.34.1
> 

  reply	other threads:[~2024-08-31  9:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-28 16:50 [PATCH] docs: scheduler: completion: Update member of struct completion I Hsin Cheng
2024-08-31  9:10 ` Kuan-Wei Chiu [this message]
2024-09-05 20:17 ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZtLeCc4GeZbwiJZ9@visitorckw-System-Product-Name \
    --to=visitorckw@gmail.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard120310@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox