[PATCH] docs: scheduler: completion: Update member of struct completion

[PATCH] docs: scheduler: completion: Update member of struct completion

[I Hsin Cheng]

The member "wait" in struct completion isn't of type wait_queue_head_t
anymore, as it is now "struct swait_queue_head", fix it to match with
the current implementation.

Signed-off-by: I Hsin Cheng <richard120310@gmail.com>
---
 Documentation/scheduler/completion.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/scheduler/completion.rst b/Documentation/scheduler/completion.rst
index f19aca2062bd..adf0c0a56d02 100644
--- a/Documentation/scheduler/completion.rst
+++ b/Documentation/scheduler/completion.rst
@@ -51,7 +51,7 @@ which has only two fields::
 
 	struct completion {
 		unsigned int done;
-		wait_queue_head_t wait;
+		struct swait_queue_head wait;
 	};
 
 This provides the ->wait waitqueue to place tasks on for waiting (if any), and
-- 
2.34.1

Re: [PATCH] docs: scheduler: completion: Update member of struct completion

[Kuan-Wei Chiu]

On Thu, Aug 29, 2024 at 12:50:36AM +0800, I Hsin Cheng wrote:
> The member "wait" in struct completion isn't of type wait_queue_head_t
> anymore, as it is now "struct swait_queue_head", fix it to match with
> the current implementation.
> 
> Signed-off-by: I Hsin Cheng <richard120310@gmail.com>

LGTM. Feel free to add:

Reviewed-by: Kuan-Wei Chiu <visitorckw@gmail.com>

> ---
>  Documentation/scheduler/completion.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/scheduler/completion.rst b/Documentation/scheduler/completion.rst
> index f19aca2062bd..adf0c0a56d02 100644
> --- a/Documentation/scheduler/completion.rst
> +++ b/Documentation/scheduler/completion.rst
> @@ -51,7 +51,7 @@ which has only two fields::
>  
>  	struct completion {
>  		unsigned int done;
> -		wait_queue_head_t wait;
> +		struct swait_queue_head wait;
>  	};
>  
>  This provides the ->wait waitqueue to place tasks on for waiting (if any), and
> -- 
> 2.34.1
> 

Re: [PATCH] docs: scheduler: completion: Update member of struct completion

[Jonathan Corbet]

I Hsin Cheng <richard120310@gmail.com> writes:

> The member "wait" in struct completion isn't of type wait_queue_head_t
> anymore, as it is now "struct swait_queue_head", fix it to match with
> the current implementation.
>
> Signed-off-by: I Hsin Cheng <richard120310@gmail.com>
> ---
>  Documentation/scheduler/completion.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/scheduler/completion.rst b/Documentation/scheduler/completion.rst
> index f19aca2062bd..adf0c0a56d02 100644
> --- a/Documentation/scheduler/completion.rst
> +++ b/Documentation/scheduler/completion.rst
> @@ -51,7 +51,7 @@ which has only two fields::
>  
>  	struct completion {
>  		unsigned int done;
> -		wait_queue_head_t wait;
> +		struct swait_queue_head wait;
>  	};

Applied, thanks.

jon