Re: [PATCH net-next v2 3/3] docs: net: fix minor issues with strparser docs

[Sabrina Dubroca <sd@queasysnail.net>]

2026-06-13, 09:58:46 -0700, Jakub Kicinski wrote:
> Not sure if anyone would read this doc, but the API has evolved
> since it was written. Update to:
> - show the int return type for strp_init()
> - refer to strp_data_ready(), not the old strp_tcp_data_ready() name
> - direct users to strp_msg(skb) for strparser metadata instead of
>   treating skb->cb as struct strp_msg directly
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: corbet@lwn.net
> CC: skhan@linuxfoundation.org
> CC: linux-doc@vger.kernel.org
> ---
>  Documentation/networking/strparser.rst | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)

Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>


> @@ -123,9 +123,9 @@ Callbacks
>      should parse the sk_buff as containing the headers for the
>      next application layer message in the stream.

Last time I had a look at strp, I was thinking about removing half of
the callbacks, since they're never used. Not a big simplification, but
it would remove a few indirections when reading the code.

-- 
Sabrina