Linux Documentation
 help / color / mirror / Atom feed
From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Pratyush Mallick <pratmal@google.com>,
	akpm@linux-foundation.org,  vbabka@kernel.org, sj@kernel.org,
	corbet@lwn.net, skhan@linuxfoundation.org,
	 anshuman.khandual@arm.com, gthelen@google.com,
	surenb@google.com, mhocko@suse.com,  jackmanb@google.com,
	hannes@cmpxchg.org, ziy@nvidia.com, liam@infradead.org,
	 rppt@kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,  linux-doc@vger.kernel.org
Subject: Re: [PATCH v3] mm/page_reporting: Add page_reporting_delay_ms module parameter
Date: Thu, 30 Jul 2026 13:43:26 +0100	[thread overview]
Message-ID: <amtGydvlb2omM4WU@lucifer> (raw)
In-Reply-To: <1acb7ba0-6aff-4d30-9554-283ac8fbc93f@kernel.org>

On Thu, Jul 30, 2026 at 02:39:51PM +0200, David Hildenbrand (Arm) wrote:
> >>> With 2s, we wait 2s before we start reporting immediately by kicking the
> >>> workqueue immediately.
> >>>
> >>> So "0" does not mean "report all the time", rather "start reporting immediately
> >>> as we are notified about a pageblock to report".
> >
> > No, it's whenever pageblock_order is specified, defaulting to a pageblock.
> >
> > But I guess in practice fine.
> >
> > There's fun like this in virtio_balloon.c btw:
> >
> > 		/*
> > 		 * The default page reporting order is @pageblock_order, which
> > 		 * corresponds to 512MB in size on ARM64 when 64KB base page
> > 		 * size is used. The page reporting won't be triggered if the
> > 		 * freeing page can't come up with a free area like that huge.
> > 		 * So we specify the page reporting order to 5, corresponding
> > 		 * to 2MB. It helps to avoid THP splitting if 4KB base page
> > 		 * size is used by host.
> > 		 *
> > 		 * Ideally, the page reporting order is selected based on the
> > 		 * host's base page size. However, it needs more work to report
> > 		 * that value. The hard-coded order would be fine currently.
> > 		 */
> > #if defined(CONFIG_ARM64) && defined(CONFIG_ARM64_64K_PAGES)
> > 		vb->pr_dev_info.order = 5;
> > #endif
>
> Yes, it's really about "a large chunk of memory was freed". On 64k " a large
> chunk" is unfortunately order 5 == 2MiB (so the same as on 4k where a pageblock
> is 2M).

Yup :)

Yeah in general I'm fine then with the timeout being 0, the fact it's batched
like this makes that rather moot!

>
> --
> Cheers,
>
> David

Cheers, Lorenzo

      reply	other threads:[~2026-07-30 12:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27 23:05 [PATCH v3] mm/page_reporting: Add page_reporting_delay_ms module parameter pratmal
2026-07-27 23:59 ` SJ Park
2026-07-28  1:13 ` Andrew Morton
2026-07-28  4:17   ` Pratyush Mallick
2026-07-28 17:27   ` Link Lin
2026-07-28 11:13 ` Lorenzo Stoakes (ARM)
2026-07-28 11:17   ` Lorenzo Stoakes (ARM)
2026-07-28 18:55   ` David Hildenbrand (Arm)
2026-07-28 20:31     ` Pratyush Mallick
2026-07-30  9:40       ` Lorenzo Stoakes (ARM)
2026-07-30 12:39         ` David Hildenbrand (Arm)
2026-07-30 12:43           ` Lorenzo Stoakes (ARM) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amtGydvlb2omM4WU@lucifer \
    --to=ljs@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=corbet@lwn.net \
    --cc=david@kernel.org \
    --cc=gthelen@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=jackmanb@google.com \
    --cc=liam@infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=pratmal@google.com \
    --cc=rppt@kernel.org \
    --cc=sj@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox