[PATCH 0/4] docs: kernel-doc: fix export selection and error handling

[PATCH 0/4] docs: kernel-doc: fix export selection and error handling

[闲逛]

[-- Attachment #1: Type: text/plain, Size: 1556 bytes --]

Hi Jonathan and Mauro,

This series fixes four reproducible kernel-doc issues:

  1. Multi-file export filtering reuses the first input's exports.
  2. Environment warning-as-error settings do not affect the exit status.
  3. YAML error paths call sys.exit() without importing sys.
  4. A separate -export-file triggers a missing-xforms TypeError.

Each fix includes CLI regression coverage. The warning-policy tests also
cover KDOC_WERROR=0, empty overrides, and command-line precedence.

Validation on Windows (Python 3.12) and Ubuntu 24.04 under WSL2
(Python 3.12.3):

  python3 -B -X utf8 -m unittest discover -s tools/unittests

  Ran 131 tests: 127 passed, 4 existing expected failures.

The series is based on mainline commit
b3dfbde62cf1981c4638939c159dfd087b7a72e9. A complete Sphinx
documentation build has not been performed. I could not verify docs-next
because the server's TLS connection failed; checking for equivalent
pending mailing-list patches is also incomplete.

Codex assisted with reproducing the failures, preparing the fixes and
regression tests, and executing the tests. The task was to inspect and
repair kernel-doc behavior in a local Linux source tree. I have reviewed
the changes and requested that my Signed-off-by be recorded.

Thank you for reviewing.

yuehua-meng

yuehua-meng (4):
  docs: kernel-doc: collect exports from all input files
  docs: kernel-doc: honor environment warning error settings
  docs: kernel-doc: import sys for YAML failure diagnostics
  docs: kernel-doc: pass transforms when parsing export files

[-- Attachment #2: 0001-docs-kernel-doc-collect-exports-from-all-input-files.patch --]
[-- Type: application/octet-stream, Size: 4889 bytes --]

From 120f53599b6522b2768811f7b9692c08e8206244 Mon Sep 17 00:00:00 2001
From: yuehua-meng <2368492046@qq.com>
Date: Sat, 14 Nov 2026 13:15:23 +0800
Subject: [PATCH 1/4] docs: kernel-doc: collect exports from all input files

With multiple input files, msg() replaces the default export source
with the first filename and reuses it for the remaining files.
Consequently -export omits later exports, and -internal includes
those exported functions.

Use all input filenames as the default export source. Add CLI
regressions for exported, internal, and unfiltered output.

Fixes: 16740c29dbf3 ("scripts/kernel_doc.py: better handle exported symbols")

AI assistance (Codex) was used to reproduce the failures, prepare
the fixes and regression tests, and execute the tests. The task was
to inspect and repair kernel-doc behavior in a local Linux tree.

Signed-off-by: yuehua-meng <2368492046@qq.com>
---
 tools/lib/python/kdoc/kdoc_files.py  |  6 ++---
 tools/unittests/kdoc_cli_helper.py   | 34 ++++++++++++++++++++++++++++
 tools/unittests/test_kdoc_exports.py | 32 ++++++++++++++++++++++++++
 3 files changed, 69 insertions(+), 3 deletions(-)
 create mode 100644 tools/unittests/kdoc_cli_helper.py
 create mode 100644 tools/unittests/test_kdoc_exports.py

diff --git a/tools/lib/python/kdoc/kdoc_files.py b/tools/lib/python/kdoc/kdoc_files.py
index ed82b6e6a..feaf27b63 100644
--- a/tools/lib/python/kdoc/kdoc_files.py
+++ b/tools/lib/python/kdoc/kdoc_files.py
@@ -339,13 +339,13 @@ class KernelFiles():
 
         glob = GlobSourceFiles(srctree=self.config.src_tree)
 
+        if not export_file:
+            export_file = filenames
+
         for fname in filenames:
             function_table = set()
 
             if internal or export:
-                if not export_file:
-                    export_file = [fname]
-
                 for f in glob.parse_files(export_file, self.file_not_found_cb):
                     function_table |= self.export_table[f]
 
diff --git a/tools/unittests/kdoc_cli_helper.py b/tools/unittests/kdoc_cli_helper.py
new file mode 100644
index 000000000..34400fb8a
--- /dev/null
+++ b/tools/unittests/kdoc_cli_helper.py
@@ -0,0 +1,34 @@
+# SPDX-License-Identifier: GPL-2.0
+"""Helpers for running kernel-doc against temporary source files."""
+
+import os
+from pathlib import Path
+import subprocess
+import sys
+import tempfile
+import unittest
+
+
+class KernelDocCliTest(unittest.TestCase):
+    def setUp(self):
+        temporary = tempfile.TemporaryDirectory()
+        self.addCleanup(temporary.cleanup)
+        self.directory = Path(temporary.name)
+        self.command = Path(__file__).resolve().parent.parent / "docs/kernel-doc"
+
+    def source(self, name, content):
+        path = self.directory / name
+        path.write_text(content, encoding="utf-8")
+        return path
+
+    def run_kdoc(self, *args, environment=None, no_site=False):
+        env = os.environ.copy()
+        for key in ("KCFLAGS", "KDOC_WERROR", "KBUILD_VERBOSE", "SRCTREE"):
+            env.pop(key, None)
+        env.update(environment or {})
+        command = [sys.executable, "-B"]
+        if no_site:
+            command.extend(["-I", "-S"])
+        command.extend([str(self.command), *map(str, args)])
+        return subprocess.run(command, env=env, capture_output=True,
+                              text=True, encoding="utf-8", timeout=30)
diff --git a/tools/unittests/test_kdoc_exports.py b/tools/unittests/test_kdoc_exports.py
new file mode 100644
index 000000000..f65071fe6
--- /dev/null
+++ b/tools/unittests/test_kdoc_exports.py
@@ -0,0 +1,32 @@
+# SPDX-License-Identifier: GPL-2.0
+"""Regression tests for kernel-doc's multi-file export selection."""
+
+from kdoc_cli_helper import KernelDocCliTest
+
+
+class TestKernelDocExports(KernelDocCliTest):
+    def setUp(self):
+        super().setUp()
+        self.files = []
+        for name in ("alpha", "beta"):
+            self.files.append(self.source(name + ".c", (
+                f"/**\n * {name} - example function\n */\n"
+                f"void {name}(void) {{}}\nEXPORT_SYMBOL({name});\n"
+            )))
+
+    def test_exports_from_all_inputs(self):
+        result = self.run_kdoc("-export", *self.files)
+        self.assertEqual(result.returncode, 0, result.stderr)
+        self.assertIn("void alpha", result.stdout)
+        self.assertIn("void beta", result.stdout)
+
+    def test_internal_excludes_all_exports(self):
+        result = self.run_kdoc("-internal", *self.files)
+        self.assertEqual(result.returncode, 0, result.stderr)
+        self.assertEqual(result.stdout.strip(), "")
+
+    def test_unfiltered_output(self):
+        result = self.run_kdoc(*self.files)
+        self.assertEqual(result.returncode, 0, result.stderr)
+        self.assertIn("void alpha", result.stdout)
+        self.assertIn("void beta", result.stdout)
-- 
2.53.0.windows.2


[-- Attachment #3: 0002-docs-kernel-doc-honor-environment-warning-error-sett.patch --]
[-- Type: application/octet-stream, Size: 4907 bytes --]

From adcb44b4ad0cb427bafaa04bd1c0096c94880bc0 Mon Sep 17 00:00:00 2001
From: yuehua-meng <2368492046@qq.com>
Date: Sat, 14 Nov 2026 13:15:23 +0800
Subject: [PATCH 2/4] docs: kernel-doc: honor environment warning error
 settings

KCFLAGS=-Werror does not match the flag expression because it
requires a trailing slash. In addition, the CLI ignores the
resolved policy, so KDOC_WERROR=1 also returns success on warnings.

Remove the extra slash and use the resolved configuration to
choose the exit status. Test the CLI flag, both environment
settings, flag boundaries, and clean input. Preserve the KDOC_WERROR=0
override and the precedence of an explicit command-line -Werror.
Empty KDOC_WERROR also disables the environment-derived policy.

Fixes: 094a4845789b ("scripts/kernel-doc.py: add a Python parser")
Fixes: 802774d8539f ("docs: kdoc: avoid error_count overflows")

AI assistance (Codex) was used to reproduce the failures, prepare
the fixes and regression tests, and execute the tests. The task was
to inspect and repair kernel-doc behavior in a local Linux tree.

Signed-off-by: yuehua-meng <2368492046@qq.com>
---
 tools/docs/kernel-doc               |  2 +-
 tools/lib/python/kdoc/kdoc_files.py |  6 ++---
 tools/unittests/test_kdoc_werror.py | 41 +++++++++++++++++++++++++++++
 3 files changed, 45 insertions(+), 4 deletions(-)
 create mode 100644 tools/unittests/test_kdoc_werror.py

diff --git a/tools/docs/kernel-doc b/tools/docs/kernel-doc
index d9192c3f1..1422bdb37 100755
--- a/tools/docs/kernel-doc
+++ b/tools/docs/kernel-doc
@@ -381,7 +381,7 @@ def main():
     if not error_count:
         sys.exit(0)
 
-    if args.werror:
+    if kfiles.config.werror:
         print("%s warnings as errors" % error_count)    # pylint: disable=C0209
         sys.exit(WERROR_RETURN_CODE)
 
diff --git a/tools/lib/python/kdoc/kdoc_files.py b/tools/lib/python/kdoc/kdoc_files.py
index feaf27b63..8555433bb 100644
--- a/tools/lib/python/kdoc/kdoc_files.py
+++ b/tools/lib/python/kdoc/kdoc_files.py
@@ -251,7 +251,7 @@ class KernelFiles():
         if not werror:
             kcflags = os.environ.get("KCFLAGS", None)
             if kcflags:
-                match = re.search(r"(\s|^)-Werror(\s|$)/", kcflags)
+                match = re.search(r"(\s|^)-Werror(\s|$)", kcflags)
                 if match:
                     werror = True
 
@@ -259,8 +259,8 @@ class KernelFiles():
             # someone was calling it with the variable from outside the
             # kernel's build system
             kdoc_werror = os.environ.get("KDOC_WERROR", None)
-            if kdoc_werror:
-                werror = kdoc_werror
+            if kdoc_werror is not None:
+                werror = kdoc_werror not in ("", "0")
 
         if not logger:
            logger = logging.getLogger("kernel-doc")
diff --git a/tools/unittests/test_kdoc_werror.py b/tools/unittests/test_kdoc_werror.py
new file mode 100644
index 000000000..3823d71ee
--- /dev/null
+++ b/tools/unittests/test_kdoc_werror.py
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: GPL-2.0
+"""Regression tests for kernel-doc warning-policy exit statuses."""
+
+from kdoc_cli_helper import KernelDocCliTest
+
+
+class TestKernelDocWerror(KernelDocCliTest):
+    def test_warning_exit_status(self):
+        source = self.source("warning.c", (
+            "/**\n * example - function with an undocumented parameter\n */\n"
+            "void example(int value) {}\n"
+        ))
+        cases = [
+            ({}, [], 0),
+            ({}, ["-Werror"], 3),
+            ({"KCFLAGS": "-Werror"}, [], 3),
+            ({"KCFLAGS": "-Wall -Werror -O2"}, [], 3),
+            ({"KCFLAGS": "-Wall\t-Werror"}, [], 3),
+            ({"KDOC_WERROR": "1"}, [], 3),
+            ({"KDOC_WERROR": "0"}, [], 0),
+            ({"KCFLAGS": "-Werror", "KDOC_WERROR": "0"}, [], 0),
+            ({"KCFLAGS": "-Werror", "KDOC_WERROR": ""}, [], 0),
+            ({"KDOC_WERROR": "0"}, ["-Werror"], 3),
+            ({"KCFLAGS": "-Werror=unused"}, [], 0),
+            ({"KCFLAGS": "-Wno-error"}, [], 0),
+        ]
+        for environment, args, expected in cases:
+            with self.subTest(environment=environment, args=args):
+                result = self.run_kdoc(*args, source, environment=environment)
+                self.assertIn("not described", result.stderr)
+                self.assertEqual(result.returncode, expected, result.stderr)
+
+    def test_clean_documentation_with_werror(self):
+        source = self.source("clean.c", (
+            "/**\n * example - documented function\n */\n"
+            "void example(void) {}\n"
+        ))
+        for environment in ({"KCFLAGS": "-Werror"}, {"KDOC_WERROR": "1"}):
+            with self.subTest(environment=environment):
+                result = self.run_kdoc(source, environment=environment)
+                self.assertEqual(result.returncode, 0, result.stderr)
-- 
2.53.0.windows.2


[-- Attachment #4: 0003-docs-kernel-doc-import-sys-for-YAML-failure-diagnost.patch --]
[-- Type: application/octet-stream, Size: 3155 bytes --]

From fdf73f6d80748b6e31932ea2cbe17ac40cf1e21b Mon Sep 17 00:00:00 2001
From: yuehua-meng <2368492046@qq.com>
Date: Sat, 14 Nov 2026 13:15:23 +0800
Subject: [PATCH 3/4] docs: kernel-doc: import sys for YAML failure diagnostics

Missing PyYAML and nonexistent output directories reach sys.exit()
without importing sys. This raises NameError instead of reporting
the intended diagnostic.

Import sys and add CLI tests for both failures and successful YAML
generation. The missing-dependency test disables site packages.

Fixes: b37b3cbbb1f1 ("docs: add a new file to write kernel-doc output to a YAML file")

AI assistance (Codex) was used to reproduce the failures, prepare
the fixes and regression tests, and execute the tests. The task was
to inspect and repair kernel-doc behavior in a local Linux tree.

Signed-off-by: yuehua-meng <2368492046@qq.com>
---
 tools/lib/python/kdoc/kdoc_yaml_file.py |  1 +
 tools/unittests/test_kdoc_yaml.py       | 37 +++++++++++++++++++++++++
 2 files changed, 38 insertions(+)
 create mode 100644 tools/unittests/test_kdoc_yaml.py

diff --git a/tools/lib/python/kdoc/kdoc_yaml_file.py b/tools/lib/python/kdoc/kdoc_yaml_file.py
index 0be020d50..eb5e51c36 100644
--- a/tools/lib/python/kdoc/kdoc_yaml_file.py
+++ b/tools/lib/python/kdoc/kdoc_yaml_file.py
@@ -3,6 +3,7 @@
 # Copyright(c) 2026: Mauro Carvalho Chehab <mchehab@kernel.org>.
 
 import os
+import sys
 
 from kdoc.kdoc_output import ManFormat, RestFormat
 
diff --git a/tools/unittests/test_kdoc_yaml.py b/tools/unittests/test_kdoc_yaml.py
new file mode 100644
index 000000000..e38ddd131
--- /dev/null
+++ b/tools/unittests/test_kdoc_yaml.py
@@ -0,0 +1,37 @@
+# SPDX-License-Identifier: GPL-2.0
+"""Regression tests for kernel-doc YAML generation and error handling."""
+
+import yaml
+
+from kdoc_cli_helper import KernelDocCliTest
+
+
+class TestKernelDocYaml(KernelDocCliTest):
+    def setUp(self):
+        super().setUp()
+        self.input = self.source("example.c", (
+            "/**\n * example - documented function\n */\n"
+            "void example(void) {}\n"
+        ))
+
+    def test_missing_dependency(self):
+        result = self.run_kdoc("--yaml", self.directory / "test.yaml",
+                               self.input, no_site=True)
+        self.assertEqual(result.returncode, 1)
+        self.assertIn("yaml package not available", result.stderr)
+        self.assertNotIn("Traceback", result.stderr)
+
+    def test_missing_directory(self):
+        result = self.run_kdoc("--yaml", self.directory / "missing/test.yaml",
+                               self.input)
+        self.assertEqual(result.returncode, 1)
+        self.assertIn("doesn't exist", result.stderr)
+        self.assertNotIn("Traceback", result.stderr)
+
+    def test_valid_output(self):
+        output = self.directory / "test.yaml"
+        result = self.run_kdoc("--yaml", output, self.input)
+        self.assertEqual(result.returncode, 0, result.stderr)
+        data = yaml.safe_load(output.read_text(encoding="utf-8"))
+        self.assertEqual(len(data["tests"]), 1)
+        self.assertEqual(data["tests"][0]["name"], "example")
-- 
2.53.0.windows.2


[-- Attachment #5: 0004-docs-kernel-doc-pass-transforms-when-parsing-export-.patch --]
[-- Type: application/octet-stream, Size: 2645 bytes --]

From 0421e038c5bc7237be09b33243071728ac979881 Mon Sep 17 00:00:00 2001
From: yuehua-meng <2368492046@qq.com>
Date: Sat, 14 Nov 2026 13:15:24 +0800
Subject: [PATCH 4/4] docs: kernel-doc: pass transforms when parsing export
 files

A separate -export-file reaches a KernelDoc constructor call that
does not pass the required xforms argument, raising TypeError.

Pass the configured transforms just as parse_file() does. Add a
regression with declarations in a header and an export in a
separate source file; only the exported declaration is emitted.

Fixes: d842057c4a20 ("docs: kdoc_parser: move transform lists to a separate file")

AI assistance (Codex) was used to reproduce the failures, prepare
the fixes and regression tests, and execute the tests. The task was
to inspect and repair kernel-doc behavior in a local Linux tree.

Signed-off-by: yuehua-meng <2368492046@qq.com>
---
 tools/lib/python/kdoc/kdoc_files.py      |  2 +-
 tools/unittests/test_kdoc_export_file.py | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+), 1 deletion(-)
 create mode 100644 tools/unittests/test_kdoc_export_file.py

diff --git a/tools/lib/python/kdoc/kdoc_files.py b/tools/lib/python/kdoc/kdoc_files.py
index 8555433bb..da78908f0 100644
--- a/tools/lib/python/kdoc/kdoc_files.py
+++ b/tools/lib/python/kdoc/kdoc_files.py
@@ -212,7 +212,7 @@ class KernelFiles():
         if fname in self.export_files:
             return
 
-        doc = KernelDoc(self.config, fname)
+        doc = KernelDoc(self.config, fname, self.xforms)
         export_table = doc.parse_export()
 
         if not export_table:
diff --git a/tools/unittests/test_kdoc_export_file.py b/tools/unittests/test_kdoc_export_file.py
new file mode 100644
index 000000000..9d2790780
--- /dev/null
+++ b/tools/unittests/test_kdoc_export_file.py
@@ -0,0 +1,19 @@
+# SPDX-License-Identifier: GPL-2.0
+"""Regression test for a separate kernel-doc export source file."""
+
+from kdoc_cli_helper import KernelDocCliTest
+
+
+class TestKernelDocExportFile(KernelDocCliTest):
+    def test_explicit_export_file(self):
+        source = self.source("example.h", (
+            "/**\n * alpha - internal function\n */\n"
+            "void alpha(void);\n"
+            "/**\n * beta - exported function\n */\n"
+            "void beta(void);\n"
+        ))
+        exports = self.source("exports.c", "EXPORT_SYMBOL(beta);\n")
+        result = self.run_kdoc("-export", "-export-file", exports, source)
+        self.assertEqual(result.returncode, 0, result.stderr)
+        self.assertNotIn("void alpha", result.stdout)
+        self.assertIn("void beta", result.stdout)
-- 
2.53.0.windows.2

Re: [PATCH 0/4] docs: kernel-doc: fix export selection and error handling

[Weijie Yuan]

On Sat, Nov 14, 2026 at 01:40:28PM +0800, 闲逛 wrote:
> Hi Jonathan and Mauro,
> 
> This series fixes four reproducible kernel-doc issues:
> 
>   1. Multi-file export filtering reuses the first input's exports.
>   2. Environment warning-as-error settings do not affect the exit status.
>   3. YAML error paths call sys.exit() without importing sys.
>   4. A separate -export-file triggers a missing-xforms TypeError.
> 
> Each fix includes CLI regression coverage. The warning-policy tests also
> cover KDOC_WERROR=0, empty overrides, and command-line precedence.
> 
> Validation on Windows (Python 3.12) and Ubuntu 24.04 under WSL2
> (Python 3.12.3):
> 
>   python3 -B -X utf8 -m unittest discover -s tools/unittests
> 
>   Ran 131 tests: 127 passed, 4 existing expected failures.
> 
> The series is based on mainline commit
> b3dfbde62cf1981c4638939c159dfd087b7a72e9.

> A complete Sphinx documentation build has not been performed.

May I ask why? You could just run 'make htmldocs'.

> I could not verify docs-next because the server's TLS connection
> failed; checking for equivalent pending mailing-list patches is also
> incomplete.

I don't believe you can not clone Jon's repo and checkout docs-next
branch. Is there any reason? (Looks like git.lwn.net is doing a pretty
good job of keeping AI crawlers out.;)) And I suspect that this part is
the output of your agent. :)

> Codex assisted with reproducing the failures, preparing the fixes and
> regression tests, and executing the tests. The task was to inspect and
> repair kernel-doc behavior in a local Linux source tree. I have reviewed
> the changes and requested that my Signed-off-by be recorded.

Thanks for the disclosure, but this may not be put in the commit message
of your patches. They should better be under '---'.

And please see also: "no attachments"

https://docs.kernel.org/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text

Thanks.

[PATCH v2 0/4] docs: kernel-doc: fix export selection and error handling

[闲逛]

Hi Weijie,

Thank you for reviewing my submission, and sorry for the mistakes.
Although I have been familiar with and using Linux for nearly ten
years, this is my first time submitting a bug fix to the kernel
community, and I still have a lot to learn about the process.

This v2 series fixes four kernel-doc issues:

  1. Pass the required transforms when parsing separate export files.
  2. Combine input and additional export sources correctly.
  3. Honor environment warning-as-error settings in the exit status.
  4. Import sys for YAML failure diagnostics.

I stopped after the regression tests, which was insufficient
validation. I should have completed the documentation build before
sending v1.

Full documentation builds have now completed on both the unmodified
docs-next base and the revised series, using Ubuntu 24.04 under WSL2
with Python 3.12.3 and Sphinx 7.2.6:

  make -j4 O=../baseline-lf-build htmldocs SPHINXOPTS='-j4'
  make -j4 O=../patched-build htmldocs SPHINXOPTS='-j4'

Both commands returned exit status 0 and generated 4,138 HTML pages.
Both logs contain the same 92 diagnostic lines after normalizing
source and output paths; the revised series adds no new diagnostics.

The failure was specific to my HTTPS attempt. Fetching through
git://git.lwn.net/linux.git, as listed in MAINTAINERS, worked.
My earlier explanation was incomplete.

The revised series is now based on docs-next commit:
2138148bf44fd84d3e0a863f0e8cb3627cdcc606

The follow-up review also identified missing coverage for combining
input and additional export files, and for relative SRCTREE paths.
These cases are now fixed and covered by regression tests. The full
suite on the revised docs-next tree runs 137 tests: 133 pass, with
four pre-existing expected failures.

I have also read the submission instructions you linked. I will send
v2 as separate inline plain-text patch emails, without attachments.

Thank you for your time and guidance.

Best regards,
yuehua-meng

Re: [PATCH v2 0/4] docs: kernel-doc: fix export selection and error handling

[Weijie Yuan]

On Sat, Nov 14, 2026 at 05:05:38PM +0800, 闲逛 wrote:
> Hi Weijie,
> 
> Thank you for reviewing my submission, and sorry for the mistakes.
> Although I have been familiar with and using Linux for nearly ten
> years, this is my first time submitting a bug fix to the kernel
> community, and I still have a lot to learn about the process.

Thanks, you're welcome! No need to worry. And sorry if my previous reply
was a bit straightforward. I was a bit out of form this afternoon. :)

Unfortunately, your actual patches of v2 this time were not sent as
replies to the cover letter. Usually, your actual patch, let's say
[2/4], should have a 'In-Reply-To' email header that points to the
Message-ID of your cover letter [0/4]. But now they do not have that
header, therefore not in a thread. See also:

  https://docs.kernel.org/process/submitting-patches.html#explicit-in-reply-to-headers
  https://docs.kernel.org/translations/zh_CN/process/submitting-patches.html#in-reply-to

If you were using 'git format-patch' and 'git send-email', that should
work well as expected. What did you use to send patches? Is it QQMail
web page? I suspect it would damage the process of sending patches. (But
it seems that your [1/4] can be applied successfully with 'b4 shazam',
so anyway) I had heard before that using QQ email might cause problems,
but I wasn't quite sure either. You may want to take a look at 'git
send-email' or b4.

I'm not familiar with this part, so please wait for others to review.
;-) I suggest that sending out your v3 after receiving some comments,
so you don't need to reroll too often beacause of this format issues.
(But if they want you to tidy it up, that's fine too.)

Yup, the process is not that easy to get familiar with at once. But
please don't be discouraged. If still meet any problems, please feel
free to let me know.

[...]

> Thank you for your time and guidance.
> 
> Best regards,
> yuehua-meng

Thanks. The usual practice is to write it as "Yuehua Meng" in your
From and Signed-off-by. But since I can tell that it's a known identity,
I guess it's fine unless later asked. Or perhaps this is just your
original intention. ;-)

Thanks.