From: <Marius.Cristea@microchip.com>
To: <corbet@lwn.net>, <robh@kernel.org>, <andy@kernel.org>,
<kent@minoris.se>, <Michael.Hennerich@analog.com>,
<lars@metafoo.de>, <conor+dt@kernel.org>,
<skhan@linuxfoundation.org>, <dlechner@baylibre.com>,
<nuno.sa@analog.com>, <janani.sunil@analog.com>,
<krzk+dt@kernel.org>, <p.zabel@pengutronix.de>,
<jic23@kernel.org>, <marcus.folkesson@gmail.com>,
<broonie@kernel.org>
Cc: <linux-spi@vger.kernel.org>, <nedo80@gmail.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-iio@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<jan.sun97@gmail.com>
Subject: Re: [PATCH v7 3/7] iio: adc: mcp3564: Add support for spi-device-addr
Date: Wed, 22 Jul 2026 17:06:07 +0000 [thread overview]
Message-ID: <c6c344e8bc09d49c23bc6bc37b70edb319b37955.camel@microchip.com> (raw)
In-Reply-To: <20260722-ad5529r-driver-v7-3-7781cd74ad75@analog.com>
On Wed, 2026-07-22 at 09:54 +0200, Janani Sunil wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> Read the generic spi-device-addr property when determining the
> hardware
> device address. Fall back to the deprecated microchip,hw-device-
> address
> property to preserve compatibility with existing device trees.
>
> The device address remains 1 when neither property is present.
>
> Signed-off-by: Janani Sunil <janani.sunil@analog.com>
> ---
> drivers/iio/adc/mcp3564.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/mcp3564.c b/drivers/iio/adc/mcp3564.c
> index 36675563829e..71deb05e878e 100644
> --- a/drivers/iio/adc/mcp3564.c
> +++ b/drivers/iio/adc/mcp3564.c
> @@ -1122,7 +1122,9 @@ static int mcp3564_config(struct iio_dev
> *indio_dev, bool *use_internal_vref_att
> * addresses are available when multiple devices are present
> on the same
> * SPI bus with only one Chip Select line for all devices.
> */
> - device_property_read_u32(dev, "microchip,hw-device-address",
> &tmp);
> + ret = device_property_read_u32(dev, "spi-device-addr", &tmp);
> + if (ret)
> + device_property_read_u32(dev, "microchip,hw-device-
> address", &tmp);
>
> if (tmp > 3) {
> dev_err_probe(dev, tmp,
>
> --
> 2.43.0
Reviewed-by: Marius Cristea <marius.cristea@microchip.com>
next prev parent reply other threads:[~2026-07-22 17:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 7:54 [PATCH v7 0/7] iio: dac: Add support for AD5529R DAC Janani Sunil
2026-07-22 7:54 ` [PATCH v7 1/7] spi: dt-bindings: Add spi-device-addr peripheral property Janani Sunil
2026-07-22 16:39 ` Conor Dooley
2026-07-22 7:54 ` [PATCH v7 2/7] dt-bindings: iio: adc: microchip,mcp3564: Add spi-device-addr Janani Sunil
2026-07-22 16:40 ` Conor Dooley
2026-07-22 7:54 ` [PATCH v7 3/7] iio: adc: mcp3564: Add support for spi-device-addr Janani Sunil
2026-07-22 16:45 ` Conor Dooley
2026-07-22 17:02 ` Marius.Cristea
2026-07-22 17:12 ` Conor Dooley
2026-07-22 17:06 ` Marius.Cristea [this message]
2026-07-22 7:54 ` [PATCH v7 4/7] dt-bindings: iio: adc: microchip,mcp3911: Add spi-device-addr Janani Sunil
2026-07-22 16:41 ` Conor Dooley
2026-07-22 7:54 ` [PATCH v7 5/7] iio: adc: mcp3911: Add support for spi-device-addr Janani Sunil
2026-07-22 16:41 ` Conor Dooley
2026-07-22 16:43 ` Conor Dooley
2026-07-22 17:18 ` Marius.Cristea
2026-07-22 17:19 ` Marius.Cristea
2026-07-22 7:54 ` [PATCH v7 6/7] dt-bindings: iio: dac: Add AD5529R Janani Sunil
2026-07-22 16:39 ` Conor Dooley
2026-07-22 7:54 ` [PATCH v7 7/7] iio: dac: Add AD5529R DAC driver support Janani Sunil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6c344e8bc09d49c23bc6bc37b70edb319b37955.camel@microchip.com \
--to=marius.cristea@microchip.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jan.sun97@gmail.com \
--cc=janani.sunil@analog.com \
--cc=jic23@kernel.org \
--cc=kent@minoris.se \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=nedo80@gmail.com \
--cc=nuno.sa@analog.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox