* [PATCH 5/5] docs: fix repeated word 'at' in journalling.rst
@ 2026-05-08 16:38 Adrien Reynard
2026-05-08 17:34 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Adrien Reynard @ 2026-05-08 16:38 UTC (permalink / raw)
To: Jonathan Corbet, Shuah Khan, open list:DOCUMENTATION, open list
Cc: Adrien Reynard
Signed-off-by: Adrien Reynard <reynard.adrien.08@gmail.com>
---
Documentation/filesystems/journalling.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/filesystems/journalling.rst b/Documentation/filesystems/journalling.rst
index 863e93e623f7..2825f6c030c2 100644
--- a/Documentation/filesystems/journalling.rst
+++ b/Documentation/filesystems/journalling.rst
@@ -93,7 +93,7 @@ easily as on jbd2_journal_start().
Try to reserve the right number of blocks the first time. ;-). This will
be the maximum number of blocks you are going to touch in this
-transaction. I advise having a look at at least ext4_jbd.h to see the
+transaction. I advise having a look at least ext4_jbd.h to see the
basis on which ext4 uses to make these decisions.
Another wriggle to watch out for is your on-disk block allocation
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 5/5] docs: fix repeated word 'at' in journalling.rst
2026-05-08 16:38 [PATCH 5/5] docs: fix repeated word 'at' in journalling.rst Adrien Reynard
@ 2026-05-08 17:34 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2026-05-08 17:34 UTC (permalink / raw)
To: Adrien Reynard, Jonathan Corbet, open list:DOCUMENTATION,
open list, Shuah Khan
On 5/8/26 10:38, Adrien Reynard wrote:
Missing change log
> Signed-off-by: Adrien Reynard <reynard.adrien.08@gmail.com>
> ---
> Documentation/filesystems/journalling.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/journalling.rst b/Documentation/filesystems/journalling.rst
> index 863e93e623f7..2825f6c030c2 100644
> --- a/Documentation/filesystems/journalling.rst
> +++ b/Documentation/filesystems/journalling.rst
> @@ -93,7 +93,7 @@ easily as on jbd2_journal_start().
>
> Try to reserve the right number of blocks the first time. ;-). This will
> be the maximum number of blocks you are going to touch in this
> -transaction. I advise having a look at at least ext4_jbd.h to see the
I don't think there is an extra "at" here - the second one "at least"
is in here to emphasize the need to look at ext4_jbd.h
It could be re-written as:
"I advise understanding the basis on which ext4 uses to make these decisions
which is detailed in ext4_jbd.h"
> +transaction. I advise having a look at least ext4_jbd.h to see the
> basis on which ext4 uses to make these decisions.
>
> Another wriggle to watch out for is your on-disk block allocation
With these suggested changes made:
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-08 17:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-08 16:38 [PATCH 5/5] docs: fix repeated word 'at' in journalling.rst Adrien Reynard
2026-05-08 17:34 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox