Linux Documentation
 help / color / mirror / Atom feed
From: Tian Zheng <zhengtian10@huawei.com>
To: Leonardo Bras <leo.bras@arm.com>
Cc: <maz@kernel.org>, <oupton@kernel.org>, <catalin.marinas@arm.com>,
	<will@kernel.org>, <corbet@lwn.net>, <pbonzini@redhat.com>,
	<yuzenghui@huawei.com>, <wangzhou1@hisilicon.com>,
	<yangjinqian1@huawei.com>, <caijian11@h-partners.com>,
	<liuyonglong@huawei.com>, <tangchengchang@huawei.com>,
	<yezhenyu2@huawei.com>, <yubihong@huawei.com>,
	<linuxarm@huawei.com>, <joey.gouly@arm.com>,
	<kvmarm@lists.linux.dev>, <kvm@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <seiden@linux.ibm.com>,
	<suzuki.poulose@arm.com>, <fuad.tabba@linux.dev>,
	<mark.rutland@arm.com>, <seanjc@google.com>,
	<rdunlap@infradead.org>, <linux-doc@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>, <skhan@linuxfoundation.org>
Subject: Re: [PATCH v5 06/15] KVM: arm64: Add support for FEAT_HDBSS
Date: Thu, 19 Nov 2026 15:52:37 +0800	[thread overview]
Message-ID: <ceb91298-3d05-486e-a900-1291963dde24@huawei.com> (raw)
In-Reply-To: <auSml6yTVYIQe7NZ@LeoBrasDK>



On 10/30/2026 10:15 PM, Leonardo Bras wrote:
> On Fri, Oct 30, 2026 at 10:53:57AM +0800, Tian Zheng wrote:
>>
>>
>> On 10/27/2026 2:12 AM, Leonardo Bras wrote:
>>> On Tue, Sep 29, 2026 at 06:36:46PM +0800, Tian Zheng wrote:
>>>> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
>>>> index 32102c3912fa..12fa37328dd2 100644
>>>> --- a/arch/arm64/kernel/cpufeature.c
>>>> +++ b/arch/arm64/kernel/cpufeature.c
>>>> @@ -2158,6 +2158,11 @@ static bool hvhe_possible(const struct arm64_cpu_capabilities *entry,
>>>>    	return arm64_test_sw_feature_override(ARM64_SW_FEATURE_OVERRIDE_HVHE);
>>>>    }
>>>>
>>>> +static bool has_vhe_hdbss(const struct arm64_cpu_capabilities *entry, int scope)
>>>> +{
>>>> +	return is_kernel_in_hyp_mode() && has_cpuid_feature(entry, scope);
>>>> +}
>>>> +
>>>
>>
>> Hi leo,
>>
>>> IIUC you run this on every cpu in the system, to make sure it's matching
>>> the feature. Is there any chance the kernel is in EL2 only on some of the
>>> cpus here?
>>>
>>
>> It's impossible for the system to have only some CPUs in EL2 and others
>>   not.
>>
>>> If not, maybe we can run it on system_supports_hdbss() instead, which would
>>> be easier for the user to understand it only runs in EL2, on top of not
>>> needing the above.
>>>
>>
>> However, The question is whether a cap should mean "this system can use
>> the feature" or "this hardware supports the feature". If the cap only
>> tracks hardware support, users may be confused when the hardware
>> supports HDBSS but the system runs in nVHE mode — they would mistakenly
>> believe they can use the feature.
>>
>> So I think we should keep is_kernel_in_hyp_mode() in has_vhe_hdbss(),
>> and add a comment in system_supports_hdbss() explaining this.
>>
>> Does that work for you? Looking forward to your reply.
> 
> Well,
> That's just my personal view of this:
> 
> If we have a function called "has_hdbss" it should only report if the
> system has the feature available.
> 
> On the "system_supports_*" we have to figure out if the system itself
> supports the feature, which checks the feature bits itself and could mean
> checking for other features being there, such as hyp_mode.
> 
> What do you think?
> 
> Thx,
> Leo

Hi Leo,

Sorry for the slow reply. I've been looking into how other cpufeatures
are configured on arm64, on and off, and that's why it took a while.

My reading is that detected: HDBSS should mean "this system can use
HDBSS", not just "the silicon has it".

Several caps already add conditions beyond the ID bits. CNP returns
false for kdump and under ARM64_WORKAROUND_DISABLE_CNP, NV and pKVM
match on kvm_get_mode(), and can_trap_icv_dir_el1() starts with
is_hyp_mode_available(). So in practice a SYSTEM_FEATURE cap answers
"can this kernel use it on this system".

HDBSS is EL2-only (HDBSSBR_EL2/HDBSSPROD_EL2, VTCR_EL2.HDBSS),
implemented only under hyp/vhe, and used only by KVM, so "the hardware
is there" is not the same as "this kernel can use it". That is why I'd
keep the gate in has_vhe_hdbss() rather than moving it to the consumer.

I'd be interested to hear how you see it.

Thanks,
Tian

  reply	other threads:[~2026-11-19  7:52 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 10:36 [PATCH v5 00/15] KVM: arm64: FEAT_HDBSS support for stage-2 dirty tracking Tian Zheng
2026-09-29 10:36 ` [PATCH v5 01/15] KVM: arm64: pgtables: Change write bit from S2AP_W to DBM Tian Zheng
2026-09-30  0:25   ` Oliver Upton
2026-09-30  2:44     ` Tian Zheng
2026-10-26 15:02       ` Leonardo Bras
2026-10-29  7:08         ` Tian Zheng
2026-09-29 10:36 ` [PATCH v5 02/15] KVM: arm64: Add KVM_PGTABLE_PROT_DIRTY Tian Zheng
2026-09-30  0:35   ` Oliver Upton
2026-09-30  2:57     ` Tian Zheng
2026-09-29 10:36 ` [PATCH v5 03/15] KVM: arm64: Introduce a dedicated walker for stage2 write-protect Tian Zheng
2026-09-29 10:36 ` [PATCH v5 04/15] KVM: arm64: Add KVM_REQ_RELOAD_STAGE2 Tian Zheng
2026-09-29 10:36 ` [PATCH v5 05/15] KVM: arm64: Harvest stage-2 dirty state into the host folio account Tian Zheng
2026-10-26 18:05   ` Leonardo Bras
2026-10-29 14:02     ` Tian Zheng
2026-10-30 12:24       ` Leonardo Bras
2026-11-06  3:16         ` Tian Zheng
2026-11-06 12:04           ` Leonardo Bras
2026-09-29 10:36 ` [PATCH v5 06/15] KVM: arm64: Add support for FEAT_HDBSS Tian Zheng
2026-10-26 18:12   ` Leonardo Bras
2026-10-30  2:53     ` Tian Zheng
2026-10-30 14:15       ` Leonardo Bras
2026-11-19  7:52         ` Tian Zheng [this message]
2026-11-19 17:27           ` Leonardo Bras
2026-09-29 10:36 ` [PATCH v5 07/15] KVM: arm64: Add HDBSS per-vCPU buffer management Tian Zheng
2026-10-26 18:27   ` Leonardo Bras
2026-10-30  3:47     ` Tian Zheng
2026-10-30 14:47       ` Leonardo Bras
2026-11-06  8:49         ` Tian Zheng
2026-11-06 15:21           ` Leonardo Bras
2026-09-29 10:36 ` [PATCH v5 08/15] KVM: arm64: Flush the HDBSS buffer on VM exit Tian Zheng
2026-10-27 18:13   ` Leonardo Bras
2026-10-30  4:57     ` Tian Zheng
2026-10-30 16:52       ` Leonardo Bras
2026-11-06  9:02         ` Tian Zheng
2026-09-29 10:36 ` [PATCH v5 09/15] KVM: arm64: Handle HDBSS faults Tian Zheng
2026-11-02 14:34   ` Leonardo Bras
2026-11-06  9:44     ` Tian Zheng
2026-09-29 10:36 ` [PATCH v5 10/15] KVM: Add kvm_arch_dirty_ring_size_updated() hook Tian Zheng
2026-09-29 10:36 ` [PATCH v5 11/15] KVM: arm64: Reserve dirty ring space for the HDBSS buffer Tian Zheng
2026-11-02 14:54   ` Leonardo Bras
2026-11-06 10:36     ` Tian Zheng
2026-11-06 15:36       ` Leonardo Bras
2026-11-09  4:00         ` Tian Zheng
2026-11-09 18:18           ` Leonardo Bras
2026-11-10  8:54             ` Tian Zheng
2026-11-10 12:49               ` Leonardo Bras
2026-11-12 13:15                 ` Tian Zheng
2026-11-12 15:26                   ` Leonardo Bras
2026-11-19  8:51                     ` Tian Zheng
2026-11-19 18:01                       ` Leonardo Bras
2026-11-06 10:58     ` Tian Zheng
2026-09-29 10:36 ` [PATCH v5 12/15] KVM: arm64: Derive the VM hardware dirty mode from dirty logging Tian Zheng
2026-11-02 15:03   ` Leonardo Bras
2026-11-06 10:46     ` Tian Zheng
2026-11-06 15:37       ` Leonardo Bras
2026-09-29 10:36 ` [PATCH v5 13/15] KVM: arm64: Add HDBSS buffer size ioctl for dirty-bitmap mode Tian Zheng
2026-11-02 15:12   ` Leonardo Bras
2026-11-06 10:27     ` Tian Zheng
2026-11-06 15:37       ` Leonardo Bras
2026-09-29 10:36 ` [PATCH v5 14/15] KVM: arm64: Document HDBSS buffer size ioctl Tian Zheng
2026-09-29 10:36 ` [PATCH v5 15/15] KVM: arm64: selftests: Add HDBSS buffer size ioctl interface test Tian Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ceb91298-3d05-486e-a900-1291963dde24@huawei.com \
    --to=zhengtian10@huawei.com \
    --cc=caijian11@h-partners.com \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=fuad.tabba@linux.dev \
    --cc=joey.gouly@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=leo.bras@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=liuyonglong@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=oupton@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=seanjc@google.com \
    --cc=seiden@linux.ibm.com \
    --cc=skhan@linuxfoundation.org \
    --cc=suzuki.poulose@arm.com \
    --cc=tangchengchang@huawei.com \
    --cc=wangzhou1@hisilicon.com \
    --cc=will@kernel.org \
    --cc=yangjinqian1@huawei.com \
    --cc=yezhenyu2@huawei.com \
    --cc=yubihong@huawei.com \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox