Re: [PATCH v6 14/18] fs/resctrl: Control visibility of global per-CPU kernel mode group files

[Reinette Chatre <reinette.chatre@intel.com>]

Hi Babu,

On 10/21/26 9:59 AM, Babu Moger wrote:
> On 10/19/26 17:00, Reinette Chatre wrote:
>> On 10/19/26 9:31 AM, Babu Moger wrote:
>>> On 10/15/26 10:46, Reinette Chatre wrote:
>>>> On 10/1/26 8:10 AM, Babu Moger wrote:
>>>>> The kmode_cpus and kmode_cpus_list files are specific to the
>>>>> RESCTRL_GLOBAL_ENABLE_PER_CPU kernel mode. These files are created in a
>>>>> hidden state when an rdtgroup is created.
>>>>>
>>>>> Introduce resctrl_kmode_global_files_show() to manage the visibility of
>>>>> these files based on whether the global per-CPU kernel mode is enabled or
>>>>> disabled.

...

>>> per-CPU kernel mode. Hide the files when the group is no longer
>>> associated with the mode.
>> Could the patches be organized so that this becomes a symmetrical change
>> that highlights when files become visible and when they become invisible to support
>> the description within this changelog?
> 
> I didn't quite understand this comment. Could you please elaborate?
> 
The subject claims that this patch "Control visibility of global per-CPU kernel mode
group files". The changelog builds on this by stating that the visibility depends on
"whether the global per-CPU kernel mode is enabled[sic] or disabled[sic]."

The patch delivers only one half of what the subject and changelog describes since it
only contains the change that hides the files when the mode is deactivated, the patch does
not contain the symmetrical change that shows the files when the mode is activated.
Having the "show" and "hide" paths in the same patch would make the change symmetrical and
easier to follow.

Reinette