From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: "Luck, Tony" <tony.luck@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"Lutomirski, Andy" <luto@kernel.org>,
"corbet@lwn.net" <corbet@lwn.net>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"kernel-dev@igalia.com" <kernel-dev@igalia.com>,
"kernel@gpiccoli.net" <kernel@gpiccoli.net>,
Andre Almeida <andrealmeid@igalia.com>,
"Yu, Fenghua" <fenghua.yu@intel.com>,
Joshua Ashton <joshua@froggi.es>, Melissa Wen <mwen@igalia.com>,
Paul Gofman <pgofman@codeweavers.com>,
Pavel Machek <pavel@denx.de>,
Pierre-Loup Griffais <pgriffais@valvesoftware.com>,
Zebediah Figura <zfigura@codeweavers.com>
Subject: Re: [PATCH V2] x86/split_lock: Add sysctl to control the misery mode
Date: Fri, 14 Oct 2022 21:19:11 -0300 [thread overview]
Message-ID: <e08a08dd-6cfe-1550-5d13-b76eef38bb27@igalia.com> (raw)
In-Reply-To: <SJ1PR11MB60832858BA290E844F6C13E9FC249@SJ1PR11MB6083.namprd11.prod.outlook.com>
On 14/10/2022 15:26, Luck, Tony wrote:
> Looks reasonable.
>
> Are these games multi-threaded with split locks happening on multiple CPUs in parallel?
> If they are, then skipping both the 10ms delay and the serialization is needed.
>
> But if split locks are only from one CPU at a time, then possibly it would have
> been enough to just have this mitigation skip the:
>
> + if (msleep_interruptible(10) > 0)
> + return;
>
> Maybe best not to second guess. You have left the default as "mitigation on",
> so I'm happy.
>
> -Tony
Hi Tony, thanks for your review!
Some games are indeed multi-threaded, so as you said, I think it's
better if we skip the whole thing when the sysctl is off - a kind of
fallback to the old "warn" mode before the misery was added heh
Cheers,
Guilherme
next prev parent reply other threads:[~2022-10-15 0:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 18:05 [PATCH V2] x86/split_lock: Add sysctl to control the misery mode Guilherme G. Piccoli
2022-10-14 18:17 ` André Almeida
2022-10-14 18:20 ` Guilherme G. Piccoli
2022-10-14 18:22 ` André Almeida
2022-10-14 18:26 ` Luck, Tony
2022-10-15 0:19 ` Guilherme G. Piccoli [this message]
2022-10-16 3:00 ` Bagas Sanjaya
2022-10-16 12:26 ` Bagas Sanjaya
2022-10-17 13:57 ` Guilherme G. Piccoli
2022-10-21 16:56 ` Guilherme G. Piccoli
2022-10-21 17:27 ` Dave Hansen
2022-10-21 19:03 ` Guilherme G. Piccoli
2022-10-21 19:07 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e08a08dd-6cfe-1550-5d13-b76eef38bb27@igalia.com \
--to=gpiccoli@igalia.com \
--cc=andrealmeid@igalia.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=joshua@froggi.es \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=mwen@igalia.com \
--cc=pavel@denx.de \
--cc=pgofman@codeweavers.com \
--cc=pgriffais@valvesoftware.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=zfigura@codeweavers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox