Linux Documentation
 help / color / mirror / Atom feed
* [PATCH] docs: powerpc: vas-api: Use the uapi structure name in the example
@ 2026-09-05 10:43 Karl Mehltretter
  2026-09-05 17:36 ` Randy Dunlap
  2026-09-06  2:57 ` Ritesh Harjani
  0 siblings, 2 replies; 3+ messages in thread
From: Karl Mehltretter @ 2026-09-05 10:43 UTC (permalink / raw)
  To: Madhavan Srinivasan
  Cc: Karl Mehltretter, Haren Myneni, Michael Ellerman, linuxppc-dev,
	Jonathan Corbet, linux-doc, Shuah Khan, Randy Dunlap

struct vas_setup_attr does not exist; the name is struct
vas_tx_win_open_attr.

Use struct vas_tx_win_open_attr.

Fixes: c12e38b1d52e ("Documentation/powerpc: VAS API")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
 Documentation/arch/powerpc/vas-api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/arch/powerpc/vas-api.rst b/Documentation/arch/powerpc/vas-api.rst
index 1d0d055356e3..00d98cfd95c9 100644
--- a/Documentation/arch/powerpc/vas-api.rst
+++ b/Documentation/arch/powerpc/vas-api.rst
@@ -265,7 +265,7 @@ Simple example
 		{
 			int rc, fd;
 			void *addr;
-			struct vas_setup_attr txattr;
+			struct vas_tx_win_open_attr txattr;
 
 			fd = open("/dev/crypto/nx-gzip", O_RDWR);
 			if (fd < 0) {
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: powerpc: vas-api: Use the uapi structure name in the example
  2026-09-05 10:43 [PATCH] docs: powerpc: vas-api: Use the uapi structure name in the example Karl Mehltretter
@ 2026-09-05 17:36 ` Randy Dunlap
  2026-09-06  2:57 ` Ritesh Harjani
  1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2026-09-05 17:36 UTC (permalink / raw)
  To: Karl Mehltretter, Madhavan Srinivasan
  Cc: Haren Myneni, Michael Ellerman, linuxppc-dev, Jonathan Corbet,
	linux-doc, Shuah Khan



On 9/5/26 3:43 AM, Karl Mehltretter wrote:
> struct vas_setup_attr does not exist; the name is struct
> vas_tx_win_open_attr.
> 
> Use struct vas_tx_win_open_attr.
> 
> Fixes: c12e38b1d52e ("Documentation/powerpc: VAS API")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.

> ---
>  Documentation/arch/powerpc/vas-api.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/arch/powerpc/vas-api.rst b/Documentation/arch/powerpc/vas-api.rst
> index 1d0d055356e3..00d98cfd95c9 100644
> --- a/Documentation/arch/powerpc/vas-api.rst
> +++ b/Documentation/arch/powerpc/vas-api.rst
> @@ -265,7 +265,7 @@ Simple example
>  		{
>  			int rc, fd;
>  			void *addr;
> -			struct vas_setup_attr txattr;
> +			struct vas_tx_win_open_attr txattr;
>  
>  			fd = open("/dev/crypto/nx-gzip", O_RDWR);
>  			if (fd < 0) {

-- 
~Randy

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: powerpc: vas-api: Use the uapi structure name in the example
  2026-09-05 10:43 [PATCH] docs: powerpc: vas-api: Use the uapi structure name in the example Karl Mehltretter
  2026-09-05 17:36 ` Randy Dunlap
@ 2026-09-06  2:57 ` Ritesh Harjani
  1 sibling, 0 replies; 3+ messages in thread
From: Ritesh Harjani @ 2026-09-06  2:57 UTC (permalink / raw)
  To: Karl Mehltretter, Madhavan Srinivasan
  Cc: Karl Mehltretter, Haren Myneni, Michael Ellerman, linuxppc-dev,
	Jonathan Corbet, linux-doc, Shuah Khan, Randy Dunlap

Karl Mehltretter <kmehltretter@gmail.com> writes:

> struct vas_setup_attr does not exist; the name is struct
> vas_tx_win_open_attr.
>
> Use struct vas_tx_win_open_attr.
>
Thanks for fixing this.

> Fixes: c12e38b1d52e ("Documentation/powerpc: VAS API")

yup. Looks like this UAPI name was wrong since day one.

While at it - would you like to fix the ioctl definition too in the same
file?

                #define VAS_MAGIC 'v'
-               #define VAS_TX_WIN_OPEN _IOW(VAS_MAGIC, 1,
+               #define VAS_TX_WIN_OPEN _IOW(VAS_MAGIC, 0x20,
                                                struct vas_tx_win_open_attr)

                struct vas_tx_win_open_attr attr;



-ritesh


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-06  3:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-05 10:43 [PATCH] docs: powerpc: vas-api: Use the uapi structure name in the example Karl Mehltretter
2026-09-05 17:36 ` Randy Dunlap
2026-09-06  2:57 ` Ritesh Harjani

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox