From: Scott Branden <scott.branden@broadcom.com>
To: Shiping Ji <shiping.linux@gmail.com>, Borislav Petkov <bp@alien8.de>
Cc: James Morse <james.morse@arm.com>,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-edac@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
sashal@kernel.org, hangl@microsoft.com,
Lei Wang <lewan@microsoft.com>,
shji@microsoft.com, ruizhao@microsoft.com,
Yuqing Shen <yuqing.shen@broadcom.com>,
ray.jui@broadcom.com, wangglei@gmail.com
Subject: Re: [PATCH v9 2/2] EDAC: add EDAC driver for DMC520
Date: Fri, 17 Jan 2020 10:40:42 -0800 [thread overview]
Message-ID: <1577ee39-2587-4d61-bbfc-a043e201c15a@broadcom.com> (raw)
In-Reply-To: <d5989a4c-8173-2f03-7d20-6fdd32d19591@gmail.com>
On 2020-01-17 10:31 a.m., Shiping Ji wrote:
>
>>> + if (irq >= 0) {
>>> + ret = devm_request_irq(&pdev->dev, irq,
>>> + dmc520_isr, IRQF_SHARED,
>>> + dev_name(&pdev->dev), mci);
>> Align arguments on the opening brace.
> I'm not sure how this can be done perfectly with tabs only :)
tabs are used first, followed by however may spaces (less than 8) needed
to lineup at the end.
>
> All other comments have been addressed in the next patch, many thanks!
>
next prev parent reply other threads:[~2020-01-17 18:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 14:32 [PATCH v9 2/2] EDAC: add EDAC driver for DMC520 Shiping Ji
2020-01-15 21:38 ` Borislav Petkov
2020-01-15 21:49 ` Shiping Ji
2020-01-15 22:05 ` Borislav Petkov
2020-01-15 22:08 ` Shiping Ji
2020-01-17 0:18 ` Borislav Petkov
2020-01-17 18:31 ` Shiping Ji
2020-01-17 18:40 ` Scott Branden [this message]
2020-01-17 18:57 ` Borislav Petkov
2020-01-17 0:31 ` Scott Branden
2020-01-17 18:24 ` Shiping Ji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1577ee39-2587-4d61-bbfc-a043e201c15a@broadcom.com \
--to=scott.branden@broadcom.com \
--cc=bp@alien8.de \
--cc=devicetree@vger.kernel.org \
--cc=hangl@microsoft.com \
--cc=james.morse@arm.com \
--cc=lewan@microsoft.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=ray.jui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=ruizhao@microsoft.com \
--cc=sashal@kernel.org \
--cc=shiping.linux@gmail.com \
--cc=shji@microsoft.com \
--cc=wangglei@gmail.com \
--cc=yuqing.shen@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox