From: Borislav Petkov <bp@alien8.de>
To: Shiping Ji <shiping.linux@gmail.com>
Cc: James Morse <james.morse@arm.com>,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-edac@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
sashal@kernel.org, hangl@microsoft.com,
Lei Wang <lewan@microsoft.com>,
shji@microsoft.com, ruizhao@microsoft.com,
Scott Branden <scott.branden@broadcom.com>,
Yuqing Shen <yuqing.shen@broadcom.com>,
ray.jui@broadcom.com, wangglei@gmail.com
Subject: Re: [PATCH v9 2/2] EDAC: add EDAC driver for DMC520
Date: Fri, 17 Jan 2020 19:57:28 +0100 [thread overview]
Message-ID: <20200117185728.GC31472@zn.tnic> (raw)
In-Reply-To: <d5989a4c-8173-2f03-7d20-6fdd32d19591@gmail.com>
On Fri, Jan 17, 2020 at 10:31:18AM -0800, Shiping Ji wrote:
> This is to protect concurrent writes to the mci->error_desc as
> suggested by James when reviewing the patch v3.
Please comment that in the structure definition so that it is clear what
it is for.
> I'm trying to find a good scheme to make them shorter, at the moment
> they are named according to the TRM.
Yeah, keeping it the same as the documentation is also a good idea. I
leave it up to you to decide as you'll be staring at that code when bugs
happen. :)
> I'm not sure how this can be done perfectly with tabs only :)
Who says you should use only tabs? :-)
> All other comments have been addressed in the next patch, many thanks!
Thanks too.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-01-17 18:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 14:32 [PATCH v9 2/2] EDAC: add EDAC driver for DMC520 Shiping Ji
2020-01-15 21:38 ` Borislav Petkov
2020-01-15 21:49 ` Shiping Ji
2020-01-15 22:05 ` Borislav Petkov
2020-01-15 22:08 ` Shiping Ji
2020-01-17 0:18 ` Borislav Petkov
2020-01-17 18:31 ` Shiping Ji
2020-01-17 18:40 ` Scott Branden
2020-01-17 18:57 ` Borislav Petkov [this message]
2020-01-17 0:31 ` Scott Branden
2020-01-17 18:24 ` Shiping Ji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117185728.GC31472@zn.tnic \
--to=bp@alien8.de \
--cc=devicetree@vger.kernel.org \
--cc=hangl@microsoft.com \
--cc=james.morse@arm.com \
--cc=lewan@microsoft.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=ray.jui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=ruizhao@microsoft.com \
--cc=sashal@kernel.org \
--cc=scott.branden@broadcom.com \
--cc=shiping.linux@gmail.com \
--cc=shji@microsoft.com \
--cc=wangglei@gmail.com \
--cc=yuqing.shen@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox