Linux EDAC development
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: Rounak Das <rounakdas2025@gmail.com>
Cc: bp@alien8.de, tony.luck@intel.com, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] EDAC/altera: use ECC manager compatible to select A10/S10 IRQ layout
Date: Wed, 1 Jul 2026 17:07:21 -0500	[thread overview]
Message-ID: <1acf2543-6773-4dad-a94c-76fe3c11ca8a@kernel.org> (raw)
In-Reply-To: <20260627061723.43014-1-rounakdas2025@gmail.com>

Hi Rounak,

On 6/27/26 01:17, Rounak Das wrote:
> The SDMMC ECC IRQ layout selection uses CONFIG_64BIT to distinguish
> between Arria10 and Stratix10 paths.
> 
> Detect the SoC once at probe via the device match table (.data),
> store it in struct altr_arria10_edac, and use it instead of CONFIG_64BIT.
> 
> This keeps the decision correct for every ECC child device
> (OCRAM, SD/MMC, etc.) and avoids any runtime compatible lookup.
> 
> Signed-off-by: Rounak Das <rounakdas2025@gmail.com>
> ---
> v4:
>   - Carry the A10/S10 distinction in the device match table .data and read
>     it with device_get_match_data(), instead of of_device_is_compatible()
>     at runtime (Dinh).
> 

I tested on both 32-bit and 64-bit platforms and it looks good. However, 
did you want to go ahead and removed the 2 remaining CONFIG_64BIT ifdefs?

DInh

  reply	other threads:[~2026-07-01 22:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-27  6:17 [PATCH v4] EDAC/altera: use ECC manager compatible to select A10/S10 IRQ layout Rounak Das
2026-07-01 22:07 ` Dinh Nguyen [this message]
2026-07-02 15:53   ` Rounak Das
2026-07-06 12:34     ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1acf2543-6773-4dad-a94c-76fe3c11ca8a@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rounakdas2025@gmail.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox