Re: linux-next: Tree for April 21 (i82975x_edac)

Re: linux-next: Tree for April 21 (i82975x_edac)

[Randy Dunlap]

On Thu, 21 Apr 2011 13:20:45 +1000 Stephen Rothwell wrote:

> Changes since 20110420:


on i386:

drivers/edac/i82975x_edac.c:298: warning: integer constant is too large for 'unsigned long' type

which is:

	if (info->xeap & 1)
		page |= 0x100000000ul; <<<<<<<<<<<<<<<

but page is unsigned long (32 bits), while 0x100000000ul is more than 32 bits,
so that line isn't setting a bit in <page>.  Is it a bug, or this driver isn't
applicable to X86_32, or what?


thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: linux-next: Tree for April 21 (i82975x_edac)

[Arvind R]

On Thu, Apr 21, 2011 at 9:21 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> On Thu, 21 Apr 2011 13:20:45 +1000 Stephen Rothwell wrote:
>
>> Changes since 20110420:
>
>
> on i386:
>
> drivers/edac/i82975x_edac.c:298: warning: integer constant is too large for 'unsigned long' type
>
> which is:
>
>        if (info->xeap & 1)
>                page |= 0x100000000ul; <<<<<<<<<<<<<<<
>
> but page is unsigned long (32 bits), while 0x100000000ul is more than 32 bits,
> so that line isn't setting a bit in <page>.  Is it a bug, or this driver isn't
> applicable to X86_32, or what?
>
would defining page variable to unsigned long long solve it for x86_32?

That would still not fix the wrong error-info reported by the driver - this is
fixed by the patch-set titled '[RFC PATCH 2.6.37 0/4] i3000_edac : merge
i82975x support' dated 2011-02-14 in the linux-edac archives.

Please advise on getting the patch into main-stream. The I3000 is a re-labeled
i82975x (or vice-versa). Hence the patch-set to merge the drivers. If separate
i82975x driver is needed - I can provide the patch. The reported bug is not
present in the merge-patched driver.

Thanks,
Arvind.

Re: linux-next: Tree for April 21 (i82975x_edac)

[Randy Dunlap]

On 04/23/11 01:21, Arvind R wrote:
> On Thu, Apr 21, 2011 at 9:21 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>> On Thu, 21 Apr 2011 13:20:45 +1000 Stephen Rothwell wrote:
>>
>>> Changes since 20110420:
>>
>>
>> on i386:
>>
>> drivers/edac/i82975x_edac.c:298: warning: integer constant is too large for 'unsigned long' type
>>
>> which is:
>>
>>        if (info->xeap & 1)
>>                page |= 0x100000000ul; <<<<<<<<<<<<<<<
>>
>> but page is unsigned long (32 bits), while 0x100000000ul is more than 32 bits,
>> so that line isn't setting a bit in <page>.  Is it a bug, or this driver isn't
>> applicable to X86_32, or what?
>>
> would defining page variable to unsigned long long solve it for x86_32?

I think that the goal should be to get your 4-patch series merged.

> That would still not fix the wrong error-info reported by the driver - this is
> fixed by the patch-set titled '[RFC PATCH 2.6.37 0/4] i3000_edac : merge
> i82975x support' dated 2011-02-14 in the linux-edac archives.
> 
> Please advise on getting the patch into main-stream. The I3000 is a re-labeled
> i82975x (or vice-versa). Hence the patch-set to merge the drivers. If separate
> i82975x driver is needed - I can provide the patch. The reported bug is not
> present in the merge-patched driver.

Doug, any plans to merge this 4-patch series from Arvind?

Arvind, was bluesmoke-devel@lists.sourceforge.net copied on this patch series?

and was the I3000 driver maintainer copied?  (added)
I can't tell this from the marc.info archives.

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

------------------------------------------------------------------------------
Fulfilling the Lean Software Promise
Lean software platforms are now widely adopted and the benefits have been 
demonstrated beyond question. Learn why your peers are replacing JEE 
containers with lightweight application servers - and what you can gain 
from the move. http://p.sf.net/sfu/vmware-sfemails

Re: linux-next: Tree for April 21 (i82975x_edac)

[Arvind R]

On Sat, Apr 23, 2011 at 9:15 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> On 04/23/11 01:21, Arvind R wrote:
>> On Thu, Apr 21, 2011 at 9:21 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>>> On Thu, 21 Apr 2011 13:20:45 +1000 Stephen Rothwell wrote:
>>>
>>>> Changes since 20110420:
>>>
>>>
>>> on i386:
>>>
>>> drivers/edac/i82975x_edac.c:298: warning: integer constant is too large for 'unsigned long' type

> I think that the goal should be to get your 4-patch series merged.
>
>> That would still not fix the wrong error-info reported by the driver - this is
>> fixed by the patch-set titled '[RFC PATCH 2.6.37 0/4] i3000_edac : merge
>> i82975x support' dated 2011-02-14 in the linux-edac archives.
>>
>> Please advise on getting the patch into main-stream. The I3000 is a re-labeled
>> i82975x (or vice-versa). Hence the patch-set to merge the drivers. If separate
>> i82975x driver is needed - I can provide the patch. The reported bug is not
>> present in the merge-patched driver.
>
> Doug, any plans to merge this 4-patch series from Arvind?
>
> Arvind, was bluesmoke-devel@lists.sourceforge.net copied on this patch series?
No - thought that the bluesmoke-list had moved to linux-edac.

>
> and was the I3000 driver maintainer copied?  (added)
> I can't tell this from the marc.info archives.
Added myself to the driver maintainer in the i3000_edac.c file. The
patch-set adds support for i82975x in the i3000 driver, which is
better structured.
TODO:
    1. Change Kconfig file - select I3000 for i82975x support
    2. Delete i82975x_edac.c file
    3. Update MAINTAINERS file
>

Arvind

Re: linux-next: Tree for April 21 (i82975x_edac)

[Randy Dunlap]

On Sat, April 23, 2011 11:29 pm, Arvind R wrote:
> On Sat, Apr 23, 2011 at 9:15 PM, Randy Dunlap <randy.dunlap@oracle.com>
> wrote:
>> On 04/23/11 01:21, Arvind R wrote:
>>> On Thu, Apr 21, 2011 at 9:21 PM, Randy Dunlap <randy.dunlap@oracle.com>
>>> wrote:
>>>> On Thu, 21 Apr 2011 13:20:45 +1000 Stephen Rothwell wrote:
>>>>
>>>>> Changes since 20110420:
>>>>
>>>>
>>>> on i386:
>>>>
>>>> drivers/edac/i82975x_edac.c:298: warning: integer constant is too
>>>> large for 'unsigned long' type
>
>> I think that the goal should be to get your 4-patch series merged.
>>
>>> That would still not fix the wrong error-info reported by the driver -
>>> this is
>>> fixed by the patch-set titled '[RFC PATCH 2.6.37 0/4] i3000_edac :
>>> merge
>>> i82975x support' dated 2011-02-14 in the linux-edac archives.
>>>
>>> Please advise on getting the patch into main-stream. The I3000 is a
>>> re-labeled
>>> i82975x (or vice-versa). Hence the patch-set to merge the drivers. If
>>> separate
>>> i82975x driver is needed - I can provide the patch. The reported bug is
>>> not
>>> present in the merge-patched driver.
>>
>> Doug, any plans to merge this 4-patch series from Arvind?
>>
>> Arvind, was bluesmoke-devel@lists.sourceforge.net copied on this patch
>> series?
> No - thought that the bluesmoke-list had moved to linux-edac.
>

If bluesmoke-devel is obsolete, the MAINTAINERS file
needs to be updated.

>>
>> and was the I3000 driver maintainer copied?  (added)
>> I can't tell this from the marc.info archives.
> Added myself to the driver maintainer in the i3000_edac.c file. The
> patch-set adds support for i82975x in the i3000 driver, which is
> better structured.
> TODO:
>     1. Change Kconfig file - select I3000 for i82975x support
>     2. Delete i82975x_edac.c file
>     3. Update MAINTAINERS file

Did the other EDAC-I3000 maintainer respond?

thanks,
-- 
~Randy

Re: linux-next: Tree for April 21 (i82975x_edac)

[Arvind R]

On Mon, Apr 25, 2011 at 7:43 AM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>
> On Sat, April 23, 2011 11:29 pm, Arvind R wrote:
>> On Sat, Apr 23, 2011 at 9:15 PM, Randy Dunlap <randy.dunlap@oracle.com>
>> wrote:
>>> On 04/23/11 01:21, Arvind R wrote:
>>>> On Thu, Apr 21, 2011 at 9:21 PM, Randy Dunlap <randy.dunlap@oracle.com>
>>>> wrote:
>>>>> On Thu, 21 Apr 2011 13:20:45 +1000 Stephen Rothwell wrote:
>>>>>
>>>>>> Changes since 20110420:
>>>>>
>>>>>
>>>>> on i386:
>>>>>
>>>>> drivers/edac/i82975x_edac.c:298: warning: integer constant is too
>>>>> large for 'unsigned long' type
>>
>>> I think that the goal should be to get your 4-patch series merged.
>>>
>>>> That would still not fix the wrong error-info reported by the driver -
>>>> this is
>>>> fixed by the patch-set titled '[RFC PATCH 2.6.37 0/4] i3000_edac :
>>>> merge
>>>> i82975x support' dated 2011-02-14 in the linux-edac archives.
>>>>
>>>> Please advise on getting the patch into main-stream. The I3000 is a
>>>> re-labeled
>>>> i82975x (or vice-versa). Hence the patch-set to merge the drivers. If
>>>> separate
>>>> i82975x driver is needed - I can provide the patch. The reported bug is
>>>> not
>>>> present in the merge-patched driver.
>>>
>>> Doug, any plans to merge this 4-patch series from Arvind?
>>>
>>> Arvind, was bluesmoke-devel@lists.sourceforge.net copied on this patch
>>> series?
>> No - thought that the bluesmoke-list had moved to linux-edac.
>>
>
> If bluesmoke-devel is obsolete, the MAINTAINERS file
> needs to be updated.
>
>>>
>>> and was the I3000 driver maintainer copied?  (added)
>>> I can't tell this from the marc.info archives.
>> Added myself to the driver maintainer in the i3000_edac.c file. The
>> patch-set adds support for i82975x in the i3000 driver, which is
>> better structured.
>> TODO:
>>     1. Change Kconfig file - select I3000 for i82975x support
>>     2. Delete i82975x_edac.c file
>>     3. Update MAINTAINERS file
>
> Did the other EDAC-I3000 maintainer respond?
No, though CC'ed to.

Arvind

------------------------------------------------------------------------------
Fulfilling the Lean Software Promise
Lean software platforms are now widely adopted and the benefits have been 
demonstrated beyond question. Learn why your peers are replacing JEE 
containers with lightweight application servers - and what you can gain 
from the move. http://p.sf.net/sfu/vmware-sfemails

Re: linux-next: Tree for April 21 (i82975x_edac)

[Jason Uhlenkott]

On Sun, Apr 24, 2011 at 21:13:16 -0500, Randy Dunlap wrote:
> > Added myself to the driver maintainer in the i3000_edac.c file. The
> > patch-set adds support for i82975x in the i3000 driver, which is
> > better structured.
> > TODO:
> >     1. Change Kconfig file - select I3000 for i82975x support
> >     2. Delete i82975x_edac.c file
> >     3. Update MAINTAINERS file
> 
> Did the other EDAC-I3000 maintainer respond?

I'm happy to let Arvind take over this driver; I haven't done any edac
work in quite a while.

Acked-by: Jason Uhlenkott <juhlenko@akamai.com>