* [RFC,v2,1/4] EDAC, GHES: Remove unused argument to ghes_edac_report_mem_error
@ 2018-04-16 21:59 Alexandru Gagniuc
0 siblings, 0 replies; 3+ messages in thread
From: Alexandru Gagniuc @ 2018-04-16 21:59 UTC (permalink / raw)
To: linux-acpi, linux-edac
Cc: rjw, lenb, tony.luck, bp, tbaicar, will.deacon, james.morse,
shiju.jose, zjzhang, gengdongjiu, linux-kernel, alex_gagniuc,
austin_bolen, shyam_iyer, devel, mchehab, robert.moore,
erik.schmauss, Alexandru Gagniuc
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
---
drivers/acpi/apei/ghes.c | 2 +-
drivers/edac/ghes_edac.c | 3 +--
include/acpi/ghes.h | 5 ++---
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index 1efefe919555..f9b53a6f55f3 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -481,7 +481,7 @@ static void ghes_do_proc(struct ghes *ghes,
if (guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM)) {
struct cper_sec_mem_err *mem_err = acpi_hest_get_payload(gdata);
- ghes_edac_report_mem_error(ghes, sev, mem_err);
+ ghes_edac_report_mem_error(sev, mem_err);
arch_apei_report_mem_error(sev, mem_err);
ghes_handle_memory_failure(gdata, sev);
diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c
index 68b6ee18bea6..32bb8c5f47dc 100644
--- a/drivers/edac/ghes_edac.c
+++ b/drivers/edac/ghes_edac.c
@@ -172,8 +172,7 @@ static void ghes_edac_dmidecode(const struct dmi_header *dh, void *arg)
}
}
-void ghes_edac_report_mem_error(struct ghes *ghes, int sev,
- struct cper_sec_mem_err *mem_err)
+void ghes_edac_report_mem_error(int sev, struct cper_sec_mem_err *mem_err)
{
enum hw_event_mc_err_type type;
struct edac_raw_error_desc *e;
diff --git a/include/acpi/ghes.h b/include/acpi/ghes.h
index 8feb0c866ee0..e096a4e7f611 100644
--- a/include/acpi/ghes.h
+++ b/include/acpi/ghes.h
@@ -55,15 +55,14 @@ enum {
/* From drivers/edac/ghes_edac.c */
#ifdef CONFIG_EDAC_GHES
-void ghes_edac_report_mem_error(struct ghes *ghes, int sev,
- struct cper_sec_mem_err *mem_err);
+void ghes_edac_report_mem_error(int sev, struct cper_sec_mem_err *mem_err);
int ghes_edac_register(struct ghes *ghes, struct device *dev);
void ghes_edac_unregister(struct ghes *ghes);
#else
-static inline void ghes_edac_report_mem_error(struct ghes *ghes, int sev,
+static inline void ghes_edac_report_mem_error(int sev,
struct cper_sec_mem_err *mem_err)
{
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* [RFC,v2,1/4] EDAC, GHES: Remove unused argument to ghes_edac_report_mem_error
@ 2018-04-17 9:36 Borislav Petkov
0 siblings, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2018-04-17 9:36 UTC (permalink / raw)
To: Alexandru Gagniuc
Cc: linux-acpi, linux-edac, rjw, lenb, tony.luck, tbaicar,
will.deacon, james.morse, shiju.jose, zjzhang, gengdongjiu,
linux-kernel, alex_gagniuc, austin_bolen, shyam_iyer, devel,
mchehab, robert.moore, erik.schmauss
On Mon, Apr 16, 2018 at 04:59:00PM -0500, Alexandru Gagniuc wrote:
<--- Insert commit message here.
A possible candidate would be some blurb about what commit removed the
use of that first arg.
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
> ---
> drivers/acpi/apei/ghes.c | 2 +-
> drivers/edac/ghes_edac.c | 3 +--
> include/acpi/ghes.h | 5 ++---
> 3 files changed, 4 insertions(+), 6 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RFC,v2,1/4] EDAC, GHES: Remove unused argument to ghes_edac_report_mem_error
@ 2018-04-17 16:43 Alexandru Gagniuc
0 siblings, 0 replies; 3+ messages in thread
From: Alexandru Gagniuc @ 2018-04-17 16:43 UTC (permalink / raw)
To: Borislav Petkov
Cc: linux-acpi, linux-edac, rjw, lenb, tony.luck, tbaicar,
will.deacon, james.morse, shiju.jose, zjzhang, gengdongjiu,
linux-kernel, alex_gagniuc, austin_bolen, shyam_iyer, devel,
mchehab, robert.moore, erik.schmauss
On 04/17/2018 04:36 AM, Borislav Petkov wrote:
> On Mon, Apr 16, 2018 at 04:59:00PM -0500, Alexandru Gagniuc wrote:
>
> <--- Insert commit message here.
>
> A possible candidate would be some blurb about what commit removed the
> use of that first arg.
I didn't consider any commit message pork to be necessary when the
summary already explains the triviality of the change. I'll add it in
the next rev.
Thanks,
Alex
>> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
>> ---
>> drivers/acpi/apei/ghes.c | 2 +-
>> drivers/edac/ghes_edac.c | 3 +--
>> include/acpi/ghes.h | 5 ++---
>> 3 files changed, 4 insertions(+), 6 deletions(-)
>
---
To unsubscribe from this list: send the line "unsubscribe linux-edac" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-17 16:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-16 21:59 [RFC,v2,1/4] EDAC, GHES: Remove unused argument to ghes_edac_report_mem_error Alexandru Gagniuc
-- strict thread matches above, loose matches on Subject: below --
2018-04-17 9:36 Borislav Petkov
2018-04-17 16:43 Alexandru Gagniuc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox