From: Borislav Petkov <bp@alien8.de>
To: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Cc: Tony Luck <tony.luck@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Aristeu Rozanski <aris@redhat.com>,
linux-edac@vger.kernel.org
Subject: [2/3] EDAC, sb_edac: Early return on ADDRV bit and address type test
Date: Wed, 5 Sep 2018 16:01:23 +0200 [thread overview]
Message-ID: <20180905140108.GJ2237@zn.tnic> (raw)
On Tue, Sep 04, 2018 at 02:07:58PM -0700, Tony Luck wrote:
> From: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
>
> Current EDAC driver only decodes valid memory physical addresses.
> So move the test for bit 58(ADDRV) into sbridge_mce_check_error(),
> and add a test that the address is the right type (looking as MISC
> bits{8:6}). Get rid of the duplicated test whether it's a memory
> controller error in sbridge_mce_output_error().
So I had to go and look at the code what exactly this patch is fixing.
Above you are explaining *what* this patch changes in the commit message
whereas you should be explaining *why* it is being changed. The *what*
is visible from the diff below.
In general, when writing a commit message, try to structure it somewhat
like this:
Problem is A.
It happens because of B.
Fix it by doing C.
(Potentially do D).
For more detailed info, see
Documentation/process/submitting-patches.rst, Section "2) Describe your
changes".
Thx.
next reply other threads:[~2018-09-05 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 14:01 Borislav Petkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-06 13:18 [2/3] EDAC, sb_edac: Early return on ADDRV bit and address type test Qiuxu Zhuo
2018-09-04 21:07 Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905140108.GJ2237@zn.tnic \
--to=bp@alien8.de \
--cc=aris@redhat.com \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox