* EDAC, sb_edac.c: Fix signedness bugs in *_get_ha() functions.
@ 2018-09-15 10:21 Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2018-09-15 10:21 UTC (permalink / raw)
To: Luck, Tony; +Cc: Dan Carpenter, linux-edac@vger.kernel.org, Zhuo, Qiuxu
On Fri, Sep 14, 2018 at 01:19:05PM -0700, Luck, Tony wrote:
> A static checker gave the following warnings:
>
> drivers/edac/sb_edac.c:1030 ibridge_get_ha() warn: signedness bug returning '(-22)'
> drivers/edac/sb_edac.c:1037 knl_get_ha() warn: signedness bug returning '(-22)'
>
> Both because the functions are declared to return a "u8", but try to return
> -EINVAL for the error case.
>
> Fix by returning 0xff (since the caller doesn't look at, or pass on, the
> return value).
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
> drivers/edac/sb_edac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied,
thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
* EDAC, sb_edac.c: Fix signedness bugs in *_get_ha() functions.
@ 2018-09-14 20:19 Luck, Tony
0 siblings, 0 replies; 2+ messages in thread
From: Luck, Tony @ 2018-09-14 20:19 UTC (permalink / raw)
To: Borislav Petkov; +Cc: Dan Carpenter, linux-edac@vger.kernel.org, Zhuo, Qiuxu
A static checker gave the following warnings:
drivers/edac/sb_edac.c:1030 ibridge_get_ha() warn: signedness bug returning '(-22)'
drivers/edac/sb_edac.c:1037 knl_get_ha() warn: signedness bug returning '(-22)'
Both because the functions are declared to return a "u8", but try to return
-EINVAL for the error case.
Fix by returning 0xff (since the caller doesn't look at, or pass on, the
return value).
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
drivers/edac/sb_edac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
index ada2cc93df58..199b6100846a 100644
--- a/drivers/edac/sb_edac.c
+++ b/drivers/edac/sb_edac.c
@@ -1027,14 +1027,14 @@ static u8 ibridge_get_ha(u8 bank)
case 9 ... 16:
return (bank - 9) / 4;
default:
- return -EINVAL;
+ return 0xff;
}
}
/* Not used, but included for safety/symmetry */
static u8 knl_get_ha(u8 bank)
{
- return -EINVAL;
+ return 0xff;
}
static u64 haswell_get_tolm(struct sbridge_pvt *pvt)
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-15 10:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-15 10:21 EDAC, sb_edac.c: Fix signedness bugs in *_get_ha() functions Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2018-09-14 20:19 Luck, Tony
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox