From: Borislav Petkov <bp@alien8.de>
To: Manish Narani <manish.narani@xilinx.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, mchehab@kernel.org,
michal.simek@xilinx.com, leoyang.li@nxp.com,
sudeep.holla@arm.com, amit.kucheria@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [v7,2/7] edac: synps: Add platform specific structures for ddrc controller
Date: Tue, 18 Sep 2018 09:55:22 +0200 [thread overview]
Message-ID: <20180918075522.GC22202@nazgul.tnic> (raw)
On Mon, Sep 17, 2018 at 07:55:00PM +0530, Manish Narani wrote:
> Add platform specific structures, so that we can add different IP
> support later using quirks.
>
> Signed-off-by: Manish Narani <manish.narani@xilinx.com>
> ---
> drivers/edac/synopsys_edac.c | 91 +++++++++++++++++++++++++++++++-------------
> 1 file changed, 65 insertions(+), 26 deletions(-)
...
> @@ -423,6 +465,7 @@ static void edac_mc_init(struct mem_ctl_info *mci,
> */
> static int synps_edac_mc_probe(struct platform_device *pdev)
> {
> + const struct synps_platform_data *p_data;
> struct edac_mc_layer layers[2];
> struct synps_edac_priv *priv;
> struct mem_ctl_info *mci;
> @@ -435,7 +478,8 @@ static int synps_edac_mc_probe(struct platform_device *pdev)
> if (IS_ERR(baseaddr))
> return PTR_ERR(baseaddr);
>
> - if (!edac_get_eccstate(baseaddr)) {
> + p_data = of_device_get_match_data(&pdev->dev);
> + if (!(p_data->get_eccstate(baseaddr))) {
From last review round:
"Too many parentheses:
if (!p_data->...
is enough."
So I'm going to stop reviewing this patchset until you go through the
old review round again and make sure you've incorporated *all* review
feedback and haven't forgotten some, like the one above.
next reply other threads:[~2018-09-18 7:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 7:55 Borislav Petkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-24 10:16 [v7,2/7] edac: synps: Add platform specific structures for ddrc controller Manish Narani
2018-09-24 10:07 Manish Narani
2018-09-21 9:15 Borislav Petkov
2018-09-21 9:07 Borislav Petkov
2018-09-19 13:33 Manish Narani
2018-09-19 11:15 Borislav Petkov
2018-09-19 5:14 Manish Narani
2018-09-17 14:25 Manish Narani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918075522.GC22202@nazgul.tnic \
--to=bp@alien8.de \
--cc=amit.kucheria@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox