From: Borislav Petkov <bp@alien8.de>
To: Manish Narani <MNARANI@xilinx.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
Michal Simek <michals@xilinx.com>,
"leoyang.li@nxp.com" <leoyang.li@nxp.com>,
"sudeep.holla@arm.com" <sudeep.holla@arm.com>,
"amit.kucheria@linaro.org" <amit.kucheria@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: [v7,2/7] edac: synps: Add platform specific structures for ddrc controller
Date: Fri, 21 Sep 2018 11:15:32 +0200 [thread overview]
Message-ID: <20180921091532.GC30439@nazgul.tnic> (raw)
There's more:
I said:
> > @@ -370,12 +398,12 @@ static int synps_edac_init_csrows(struct mem_ctl_info *mci)
> That function returns 0 unconditionally. Make it a void in a prepatch.
But you've lumped this change together with a bunch more. Maybe my
request wasn't clear so let me rephrase it:
That function returns 0 unconditionally. Make it a void in a *separate* prepatch.
Ok?
next reply other threads:[~2018-09-21 9:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 9:15 Borislav Petkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-24 10:16 [v7,2/7] edac: synps: Add platform specific structures for ddrc controller Manish Narani
2018-09-24 10:07 Manish Narani
2018-09-21 9:07 Borislav Petkov
2018-09-19 13:33 Manish Narani
2018-09-19 11:15 Borislav Petkov
2018-09-19 5:14 Manish Narani
2018-09-18 7:55 Borislav Petkov
2018-09-17 14:25 Manish Narani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921091532.GC30439@nazgul.tnic \
--to=bp@alien8.de \
--cc=MNARANI@xilinx.com \
--cc=amit.kucheria@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=michals@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox