* edac: qcom_edac: uninitialized variable in IRQ handler
@ 2018-10-18 7:38 Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2018-10-18 7:38 UTC (permalink / raw)
To: Channagoud Kadabi
Cc: Venkata Narendra Kumar Gutta, Borislav Petkov,
Mauro Carvalho Chehab, linux-edac, kernel-janitors
We forgot to set "irq_handled" to false, so it's either true or
uninitialized.
Fixes: 27450653f1db ("drivers: edac: Add EDAC driver support for QCOM SoCs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/edac/qcom_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/qcom_edac.c b/drivers/edac/qcom_edac.c
index 82bd775124f2..f8510a024fe5 100644
--- a/drivers/edac/qcom_edac.c
+++ b/drivers/edac/qcom_edac.c
@@ -292,7 +292,7 @@ llcc_ecc_irq_handler(int irq, void *edev_ctl)
struct llcc_drv_data *drv = edac_dev_ctl->pvt_info;
irqreturn_t irq_rc = IRQ_NONE;
u32 drp_error, trp_error, i;
- bool irq_handled;
+ bool irq_handled = false;
int ret;
/* Iterate over the banks and look for Tag RAM or Data RAM errors */
^ permalink raw reply related [flat|nested] 3+ messages in thread
* edac: qcom_edac: uninitialized variable in IRQ handler
@ 2018-10-18 12:27 Borislav Petkov
0 siblings, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2018-10-18 12:27 UTC (permalink / raw)
To: Dan Carpenter
Cc: Channagoud Kadabi, Venkata Narendra Kumar Gutta,
Mauro Carvalho Chehab, linux-edac, kernel-janitors
On Thu, Oct 18, 2018 at 10:38:07AM +0300, Dan Carpenter wrote:
> We forgot to set "irq_handled" to false, so it's either true or
> uninitialized.
>
> Fixes: 27450653f1db ("drivers: edac: Add EDAC driver support for QCOM SoCs")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/edac/qcom_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/qcom_edac.c b/drivers/edac/qcom_edac.c
> index 82bd775124f2..f8510a024fe5 100644
> --- a/drivers/edac/qcom_edac.c
> +++ b/drivers/edac/qcom_edac.c
> @@ -292,7 +292,7 @@ llcc_ecc_irq_handler(int irq, void *edev_ctl)
> struct llcc_drv_data *drv = edac_dev_ctl->pvt_info;
> irqreturn_t irq_rc = IRQ_NONE;
> u32 drp_error, trp_error, i;
> - bool irq_handled;
> + bool irq_handled = false;
That variable is just silly. One can simply do:
if (!ret)
irq_rc = IRQ_HANDLED;
in both places and
return irq_rc;
at the end and remove irq_handled altogether. Problem solved.
^ permalink raw reply [flat|nested] 3+ messages in thread
* edac: qcom_edac: uninitialized variable in IRQ handler
@ 2018-10-18 12:32 Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2018-10-18 12:32 UTC (permalink / raw)
To: Borislav Petkov
Cc: Channagoud Kadabi, Venkata Narendra Kumar Gutta,
Mauro Carvalho Chehab, linux-edac, kernel-janitors
On Thu, Oct 18, 2018 at 02:27:14PM +0200, Borislav Petkov wrote:
> On Thu, Oct 18, 2018 at 10:38:07AM +0300, Dan Carpenter wrote:
> > We forgot to set "irq_handled" to false, so it's either true or
> > uninitialized.
> >
> > Fixes: 27450653f1db ("drivers: edac: Add EDAC driver support for QCOM SoCs")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > drivers/edac/qcom_edac.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/edac/qcom_edac.c b/drivers/edac/qcom_edac.c
> > index 82bd775124f2..f8510a024fe5 100644
> > --- a/drivers/edac/qcom_edac.c
> > +++ b/drivers/edac/qcom_edac.c
> > @@ -292,7 +292,7 @@ llcc_ecc_irq_handler(int irq, void *edev_ctl)
> > struct llcc_drv_data *drv = edac_dev_ctl->pvt_info;
> > irqreturn_t irq_rc = IRQ_NONE;
> > u32 drp_error, trp_error, i;
> > - bool irq_handled;
> > + bool irq_handled = false;
>
> That variable is just silly. One can simply do:
>
> if (!ret)
> irq_rc = IRQ_HANDLED;
>
> in both places and
>
> return irq_rc;
>
> at the end and remove irq_handled altogether. Problem solved.
>
Yeah. That's cleaner. I will resend.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-18 12:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-18 12:27 edac: qcom_edac: uninitialized variable in IRQ handler Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2018-10-18 12:32 Dan Carpenter
2018-10-18 7:38 Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox