From: Borislav Petkov <bp@alien8.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Channagoud Kadabi <ckadabi@codeaurora.org>,
Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [v2] edac: qcom_edac: uninitialized variable in IRQ handler
Date: Thu, 18 Oct 2018 16:24:38 +0200 [thread overview]
Message-ID: <20181018142438.GG20831@zn.tnic> (raw)
On Thu, Oct 18, 2018 at 05:15:22PM +0300, Dan Carpenter wrote:
> We forgot to initialize "irq_handled" to false. But really it's
> cleaner to just get rid of that variable and use "irq_rc" directly
> instead.
>
> Fixes: 27450653f1db ("drivers: edac: Add EDAC driver support for QCOM SoCs")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: Get rid of the "irq_handled" variable.
>
> drivers/edac/qcom_edac.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
Reviewed-by: Borislav Petkov <bp@suse.de>
next reply other threads:[~2018-10-18 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 14:24 Borislav Petkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-11-06 11:06 [v2] edac: qcom_edac: uninitialized variable in IRQ handler Borislav Petkov
2018-10-18 14:15 Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018142438.GG20831@zn.tnic \
--to=bp@alien8.de \
--cc=ckadabi@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=vnkgutta@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox