* [v2] edac: qcom_edac: uninitialized variable in IRQ handler
@ 2018-10-18 14:15 Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2018-10-18 14:15 UTC (permalink / raw)
To: Channagoud Kadabi
Cc: Venkata Narendra Kumar Gutta, Borislav Petkov,
Mauro Carvalho Chehab, linux-edac, kernel-janitors
We forgot to initialize "irq_handled" to false. But really it's
cleaner to just get rid of that variable and use "irq_rc" directly
instead.
Fixes: 27450653f1db ("drivers: edac: Add EDAC driver support for QCOM SoCs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: Get rid of the "irq_handled" variable.
drivers/edac/qcom_edac.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/edac/qcom_edac.c b/drivers/edac/qcom_edac.c
index 82bd775124f2..97a27e42dd61 100644
--- a/drivers/edac/qcom_edac.c
+++ b/drivers/edac/qcom_edac.c
@@ -292,7 +292,6 @@ llcc_ecc_irq_handler(int irq, void *edev_ctl)
struct llcc_drv_data *drv = edac_dev_ctl->pvt_info;
irqreturn_t irq_rc = IRQ_NONE;
u32 drp_error, trp_error, i;
- bool irq_handled;
int ret;
/* Iterate over the banks and look for Tag RAM or Data RAM errors */
@@ -311,7 +310,7 @@ llcc_ecc_irq_handler(int irq, void *edev_ctl)
ret = dump_syn_reg(edev_ctl, LLCC_DRAM_UE, i);
}
if (!ret)
- irq_handled = true;
+ irq_rc = IRQ_HANDLED;
ret = regmap_read(drv->regmap,
drv->offsets[i] + TRP_INTERRUPT_0_STATUS,
@@ -327,12 +326,9 @@ llcc_ecc_irq_handler(int irq, void *edev_ctl)
ret = dump_syn_reg(edev_ctl, LLCC_TRAM_UE, i);
}
if (!ret)
- irq_handled = true;
+ irq_rc = IRQ_HANDLED;
}
- if (irq_handled)
- irq_rc = IRQ_HANDLED;
-
return irq_rc;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [v2] edac: qcom_edac: uninitialized variable in IRQ handler
@ 2018-10-18 14:24 Borislav Petkov
0 siblings, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2018-10-18 14:24 UTC (permalink / raw)
To: Dan Carpenter
Cc: Channagoud Kadabi, Venkata Narendra Kumar Gutta,
Mauro Carvalho Chehab, linux-edac, kernel-janitors
On Thu, Oct 18, 2018 at 05:15:22PM +0300, Dan Carpenter wrote:
> We forgot to initialize "irq_handled" to false. But really it's
> cleaner to just get rid of that variable and use "irq_rc" directly
> instead.
>
> Fixes: 27450653f1db ("drivers: edac: Add EDAC driver support for QCOM SoCs")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: Get rid of the "irq_handled" variable.
>
> drivers/edac/qcom_edac.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
Reviewed-by: Borislav Petkov <bp@suse.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [v2] edac: qcom_edac: uninitialized variable in IRQ handler
@ 2018-11-06 11:06 Borislav Petkov
0 siblings, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2018-11-06 11:06 UTC (permalink / raw)
To: Dan Carpenter
Cc: Channagoud Kadabi, Venkata Narendra Kumar Gutta,
Mauro Carvalho Chehab, linux-edac, kernel-janitors
On Thu, Oct 18, 2018 at 04:24:38PM +0200, Borislav Petkov wrote:
> On Thu, Oct 18, 2018 at 05:15:22PM +0300, Dan Carpenter wrote:
> > We forgot to initialize "irq_handled" to false. But really it's
> > cleaner to just get rid of that variable and use "irq_rc" directly
> > instead.
> >
> > Fixes: 27450653f1db ("drivers: edac: Add EDAC driver support for QCOM SoCs")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > v2: Get rid of the "irq_handled" variable.
> >
> > drivers/edac/qcom_edac.c | 8 ++------
> > 1 file changed, 2 insertions(+), 6 deletions(-)
>
> Reviewed-by: Borislav Petkov <bp@suse.de>
Applied, thx.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-06 11:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-18 14:24 [v2] edac: qcom_edac: uninitialized variable in IRQ handler Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2018-11-06 11:06 Borislav Petkov
2018-10-18 14:15 Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox