From: Borislav Petkov <bp@alien8.de>
To: York Sun <york.sun@nxp.com>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Subject: drivers: edac: fsl: move error injection under CONFIG_EDAC_DEBUG
Date: Tue, 20 Nov 2018 17:44:43 +0100 [thread overview]
Message-ID: <20181120164443.GH2527@zn.tnic> (raw)
On Mon, Nov 19, 2018 at 10:53:40PM +0000, York Sun wrote:
> Gate error injection feature with CONFIG_EDAC_DEBUG.
>
> Signed-off-by: York Sun <york.sun@nxp.com>
> Suggested-by: Borislav Petkov <bp@alien8.de>
> ---
> drivers/edac/fsl_ddr_edac.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/edac/fsl_ddr_edac.c b/drivers/edac/fsl_ddr_edac.c
> index efc8276d1d9c..27826d38b4b7 100644
> --- a/drivers/edac/fsl_ddr_edac.c
> +++ b/drivers/edac/fsl_ddr_edac.c
> @@ -51,6 +51,7 @@ static inline void ddr_out32(void __iomem *addr, u32 value)
> iowrite32be(value, addr);
> }
>
> +#ifdef CONFIG_EDAC_DEBUG
> /************************ MC SYSFS parts ***********************************/
>
> #define to_mci(k) container_of(k, struct mem_ctl_info, dev)
> @@ -151,11 +152,14 @@ static DEVICE_ATTR(inject_data_lo, S_IRUGO | S_IWUSR,
> fsl_mc_inject_data_lo_show, fsl_mc_inject_data_lo_store);
> static DEVICE_ATTR(inject_ctrl, S_IRUGO | S_IWUSR,
> fsl_mc_inject_ctrl_show, fsl_mc_inject_ctrl_store);
> +#endif /* CONFIG_EDAC_DEBUG */
>
> static struct attribute *fsl_ddr_dev_attrs[] = {
> +#ifdef CONFIG_EDAC_DEBUG
> &dev_attr_inject_data_hi.attr,
> &dev_attr_inject_data_lo.attr,
> &dev_attr_inject_ctrl.attr,
> +#endif
> NULL
> };
>
> --
Applied, thanks.
next reply other threads:[~2018-11-20 16:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 16:44 Borislav Petkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-11-19 22:53 drivers: edac: fsl: move error injection under CONFIG_EDAC_DEBUG York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120164443.GH2527@zn.tnic \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=york.sun@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox