* drivers: edac: fsl: move error injection under CONFIG_EDAC_DEBUG
@ 2018-11-20 16:44 Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2018-11-20 16:44 UTC (permalink / raw)
To: York Sun; +Cc: linux-edac@vger.kernel.org
On Mon, Nov 19, 2018 at 10:53:40PM +0000, York Sun wrote:
> Gate error injection feature with CONFIG_EDAC_DEBUG.
>
> Signed-off-by: York Sun <york.sun@nxp.com>
> Suggested-by: Borislav Petkov <bp@alien8.de>
> ---
> drivers/edac/fsl_ddr_edac.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/edac/fsl_ddr_edac.c b/drivers/edac/fsl_ddr_edac.c
> index efc8276d1d9c..27826d38b4b7 100644
> --- a/drivers/edac/fsl_ddr_edac.c
> +++ b/drivers/edac/fsl_ddr_edac.c
> @@ -51,6 +51,7 @@ static inline void ddr_out32(void __iomem *addr, u32 value)
> iowrite32be(value, addr);
> }
>
> +#ifdef CONFIG_EDAC_DEBUG
> /************************ MC SYSFS parts ***********************************/
>
> #define to_mci(k) container_of(k, struct mem_ctl_info, dev)
> @@ -151,11 +152,14 @@ static DEVICE_ATTR(inject_data_lo, S_IRUGO | S_IWUSR,
> fsl_mc_inject_data_lo_show, fsl_mc_inject_data_lo_store);
> static DEVICE_ATTR(inject_ctrl, S_IRUGO | S_IWUSR,
> fsl_mc_inject_ctrl_show, fsl_mc_inject_ctrl_store);
> +#endif /* CONFIG_EDAC_DEBUG */
>
> static struct attribute *fsl_ddr_dev_attrs[] = {
> +#ifdef CONFIG_EDAC_DEBUG
> &dev_attr_inject_data_hi.attr,
> &dev_attr_inject_data_lo.attr,
> &dev_attr_inject_ctrl.attr,
> +#endif
> NULL
> };
>
> --
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread* drivers: edac: fsl: move error injection under CONFIG_EDAC_DEBUG
@ 2018-11-19 22:53 York Sun
0 siblings, 0 replies; 2+ messages in thread
From: York Sun @ 2018-11-19 22:53 UTC (permalink / raw)
To: bp@alien8.de; +Cc: linux-edac@vger.kernel.org, York Sun
Gate error injection feature with CONFIG_EDAC_DEBUG.
Signed-off-by: York Sun <york.sun@nxp.com>
Suggested-by: Borislav Petkov <bp@alien8.de>
---
drivers/edac/fsl_ddr_edac.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/edac/fsl_ddr_edac.c b/drivers/edac/fsl_ddr_edac.c
index efc8276d1d9c..27826d38b4b7 100644
--- a/drivers/edac/fsl_ddr_edac.c
+++ b/drivers/edac/fsl_ddr_edac.c
@@ -51,6 +51,7 @@ static inline void ddr_out32(void __iomem *addr, u32 value)
iowrite32be(value, addr);
}
+#ifdef CONFIG_EDAC_DEBUG
/************************ MC SYSFS parts ***********************************/
#define to_mci(k) container_of(k, struct mem_ctl_info, dev)
@@ -151,11 +152,14 @@ static DEVICE_ATTR(inject_data_lo, S_IRUGO | S_IWUSR,
fsl_mc_inject_data_lo_show, fsl_mc_inject_data_lo_store);
static DEVICE_ATTR(inject_ctrl, S_IRUGO | S_IWUSR,
fsl_mc_inject_ctrl_show, fsl_mc_inject_ctrl_store);
+#endif /* CONFIG_EDAC_DEBUG */
static struct attribute *fsl_ddr_dev_attrs[] = {
+#ifdef CONFIG_EDAC_DEBUG
&dev_attr_inject_data_hi.attr,
&dev_attr_inject_data_lo.attr,
&dev_attr_inject_ctrl.attr,
+#endif
NULL
};
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-20 16:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-20 16:44 drivers: edac: fsl: move error injection under CONFIG_EDAC_DEBUG Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2018-11-19 22:53 York Sun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox