[1/2] firmware: Intel: Add Stratix10 ECC DBE SMC call

[1/2] firmware: Intel: Add Stratix10 ECC DBE SMC call

[thor.thayer]

From: Thor Thayer <thor.thayer@linux.intel.com>

Reserve ECC Double Bit Error SMC call to alert U-Boot that
a DBE has occurred. Moving the call from local EDAC header
file to this common file.

Reviewed-by: Richard Gong <richard.gong@intel.com>
Reviewed-by: Alan Tull <atull@kernel.org>
Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
---
 include/linux/firmware/intel/stratix10-smc.h | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/include/linux/firmware/intel/stratix10-smc.h b/include/linux/firmware/intel/stratix10-smc.h
index 5be5dab50b13..01684d935580 100644
--- a/include/linux/firmware/intel/stratix10-smc.h
+++ b/include/linux/firmware/intel/stratix10-smc.h
@@ -309,4 +309,23 @@ INTEL_SIP_SMC_FAST_CALL_VAL(INTEL_SIP_SMC_FUNCID_FPGA_CONFIG_COMPLETED_WRITE)
 #define INTEL_SIP_SMC_FUNCID_RSU_UPDATE 12
 #define INTEL_SIP_SMC_RSU_UPDATE \
 	INTEL_SIP_SMC_FAST_CALL_VAL(INTEL_SIP_SMC_FUNCID_RSU_UPDATE)
+
+/*
+ * Request INTEL_SIP_SMC_ECC_DBE
+ *
+ * Sync call used by service driver at EL1 to alert EL3 that a Double
+ * Bit ECC error has occurred.
+ *
+ * Call register usage:
+ * a0 INTEL_SIP_SMC_ECC_DBE
+ * a1 SysManager Double Bit Error value
+ * a2-7 not used
+ *
+ * Return status
+ * a0 INTEL_SIP_SMC_STATUS_OK
+ */
+#define INTEL_SIP_SMC_FUNCID_ECC_DBE 13
+#define INTEL_SIP_SMC_ECC_DBE \
+	INTEL_SIP_SMC_FAST_CALL_VAL(INTEL_SIP_SMC_FUNCID_ECC_DBE)
+
 #endif

[1/2] firmware: Intel: Add Stratix10 ECC DBE SMC call

[Borislav Petkov]

On Fri, Mar 29, 2019 at 09:43:58AM -0500, thor.thayer@linux.intel.com wrote:
> From: Thor Thayer <thor.thayer@linux.intel.com>
> 
> Reserve ECC Double Bit Error SMC call to alert U-Boot that
> a DBE has occurred. Moving the call from local EDAC header
> file to this common file.

Is there any particular reason this needs to be two patches or can I
merge them into one?

[1/2] firmware: Intel: Add Stratix10 ECC DBE SMC call

[thor.thayer]

On 4/2/19 3:55 AM, Borislav Petkov wrote:
> On Fri, Mar 29, 2019 at 09:43:58AM -0500, thor.thayer@linux.intel.com wrote:
>> From: Thor Thayer <thor.thayer@linux.intel.com>
>>
>> Reserve ECC Double Bit Error SMC call to alert U-Boot that
>> a DBE has occurred. Moving the call from local EDAC header
>> file to this common file.
> 
> Is there any particular reason this needs to be two patches or can I
> merge them into one?
> 

Yes, they can be merged into one. I split into 2 patches since the 1st 
required the firmware directory sign-off and the 2nd required your EDAC 
sign-off. I see your point, it could have been 1 patch.

Thanks for reviewing,

Thor

[1/2] firmware: Intel: Add Stratix10 ECC DBE SMC call

[Borislav Petkov]

On Tue, Apr 02, 2019 at 08:34:18AM -0500, Thor Thayer wrote:
> Yes, they can be merged into one. I split into 2 patches since the 1st
> required the firmware directory sign-off and the 2nd required your EDAC
> sign-off. I see your point, it could have been 1 patch.

Ok, merged and applied.

Thx.