From: "Luck, Tony" <tony.luck@intel.com>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: Borislav Petkov <bp@alien8.de>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: [RESEND,4/5] x86/MCE: Make number of MCA banks per_cpu
Date: Mon, 8 Apr 2019 16:23:25 -0700 [thread overview]
Message-ID: <20190408232325.GA17000@agluck-desk> (raw)
On Mon, Apr 08, 2019 at 10:48:34PM +0000, Ghannam, Yazen wrote:
> Okay, so drop the export and leave the injector code as-is (it's
> already doing a rdmsrl_on_cpu()).
It's still a globally visible symbol (shared by core.c and amd.c).
So I think it needs a "mce_" prefix.
While it doesn't collide now, there are a bunch of other
subsystems that have "banks" and a variable to count them.
Look at output from "git grep -w num_banks".
-Tony
WARNING: multiple messages have this Message-ID (diff)
From: "Luck, Tony" <tony.luck@intel.com>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: Borislav Petkov <bp@alien8.de>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu
Date: Mon, 8 Apr 2019 16:23:25 -0700 [thread overview]
Message-ID: <20190408232325.GA17000@agluck-desk> (raw)
Message-ID: <20190408232325.qQIzne1NZ7KIv1Z5iCfOibi-CnNNdMLoiiJA0FKhbAQ@z> (raw)
In-Reply-To: <SN6PR12MB2639F3E98157872E7C046705F82C0@SN6PR12MB2639.namprd12.prod.outlook.com>
On Mon, Apr 08, 2019 at 10:48:34PM +0000, Ghannam, Yazen wrote:
> Okay, so drop the export and leave the injector code as-is (it's
> already doing a rdmsrl_on_cpu()).
It's still a globally visible symbol (shared by core.c and amd.c).
So I think it needs a "mce_" prefix.
While it doesn't collide now, there are a bunch of other
subsystems that have "banks" and a variable to count them.
Look at output from "git grep -w num_banks".
-Tony
next prev reply other threads:[~2019-04-08 23:23 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 14:12 [PATCH RESEND 0/5] Handle MCA banks in a per_cpu way Ghannam, Yazen
2019-04-08 14:12 ` [RESEND,1/5] x86/MCE: Make struct mce_banks[] static Yazen Ghannam
2019-04-08 14:12 ` [PATCH RESEND 1/5] " Ghannam, Yazen
2019-04-08 14:12 ` [RESEND,2/5] x86/MCE: Handle MCA controls in a per_cpu way Yazen Ghannam
2019-04-08 14:12 ` [PATCH RESEND 2/5] " Ghannam, Yazen
2019-04-08 17:51 ` [RESEND,2/5] " Borislav Petkov
2019-04-08 17:51 ` [PATCH RESEND 2/5] " Borislav Petkov
2019-04-08 18:55 ` [RESEND,2/5] " Yazen Ghannam
2019-04-08 18:55 ` [PATCH RESEND 2/5] " Ghannam, Yazen
2019-04-09 20:34 ` [RESEND,2/5] " Borislav Petkov
2019-04-09 20:34 ` [PATCH RESEND 2/5] " Borislav Petkov
2019-04-10 16:36 ` [RESEND,2/5] " Yazen Ghannam
2019-04-10 16:36 ` [PATCH RESEND 2/5] " Ghannam, Yazen
2019-04-10 16:40 ` [RESEND,2/5] " Borislav Petkov
2019-04-10 16:40 ` [PATCH RESEND 2/5] " Borislav Petkov
2019-04-10 16:58 ` [RESEND,2/5] " Yazen Ghannam
2019-04-10 16:58 ` [PATCH RESEND 2/5] " Ghannam, Yazen
2019-04-10 17:25 ` [RESEND,2/5] " Borislav Petkov
2019-04-10 17:25 ` [PATCH RESEND 2/5] " Borislav Petkov
2019-04-10 19:41 ` [RESEND,2/5] " Yazen Ghannam
2019-04-10 19:41 ` [PATCH RESEND 2/5] " Ghannam, Yazen
2019-04-10 20:04 ` [RESEND,2/5] " Borislav Petkov
2019-04-10 20:04 ` [PATCH RESEND 2/5] " Borislav Petkov
2019-04-08 14:12 ` [RESEND,4/5] x86/MCE: Make number of MCA banks per_cpu Yazen Ghannam
2019-04-08 14:12 ` [PATCH RESEND 4/5] " Ghannam, Yazen
2019-04-08 20:26 ` [RESEND,4/5] " Luck, Tony
2019-04-08 20:26 ` [PATCH RESEND 4/5] " Luck, Tony
2019-04-08 20:34 ` [RESEND,4/5] " Borislav Petkov
2019-04-08 20:34 ` [PATCH RESEND 4/5] " Borislav Petkov
2019-04-08 20:42 ` [RESEND,4/5] " Luck, Tony
2019-04-08 20:42 ` [PATCH RESEND 4/5] " Luck, Tony
2019-04-08 20:50 ` [RESEND,4/5] " Borislav Petkov
2019-04-08 20:50 ` [PATCH RESEND 4/5] " Borislav Petkov
2019-04-08 22:48 ` [RESEND,4/5] " Yazen Ghannam
2019-04-08 22:48 ` [PATCH RESEND 4/5] " Ghannam, Yazen
2019-04-08 23:23 ` Luck, Tony [this message]
2019-04-08 23:23 ` Luck, Tony
2019-04-08 23:37 ` [RESEND,4/5] " Yazen Ghannam
2019-04-08 23:37 ` [PATCH RESEND 4/5] " Ghannam, Yazen
2019-04-09 11:38 ` [RESEND,4/5] " Borislav Petkov
2019-04-09 11:38 ` [PATCH RESEND 4/5] " Borislav Petkov
2019-04-08 14:12 ` [RESEND,3/5] x86/MCE/AMD: Don't cache block addresses on SMCA systems Yazen Ghannam
2019-04-08 14:12 ` [PATCH RESEND 3/5] " Ghannam, Yazen
2019-04-08 14:12 ` [RESEND,5/5] x86/MCE: Save MCA control bits that get set in hardware Yazen Ghannam
2019-04-08 14:12 ` [PATCH RESEND 5/5] " Ghannam, Yazen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408232325.GA17000@agluck-desk \
--to=tony.luck@intel.com \
--cc=Yazen.Ghannam@amd.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox