From: Borislav Petkov <bp@alien8.de>
To: Mohan Kumar <mohankumar718@gmail.com>
Cc: mchehab@kernel.org, james.morse@arm.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCHv1] drivers: edac: This patch fix the following checkpatch warning.
Date: Sun, 14 Apr 2019 20:49:34 +0200 [thread overview]
Message-ID: <20190414184934.GB569@zn.tnic> (raw)
On Sun, Apr 14, 2019 at 09:41:50PM +0300, Mohan Kumar wrote:
> Use pr_warn instead of printk
>
> WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
> then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
Please read this here first on what to put in your patch title and commit
message:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> Signed-off-by: Mohan Kumar <mohankumar718@gmail.com>
> ---
> drivers/edac/x38_edac.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/edac/x38_edac.c b/drivers/edac/x38_edac.c
> index cc779f3..4c855c0 100644
> --- a/drivers/edac/x38_edac.c
> +++ b/drivers/edac/x38_edac.c
> @@ -14,6 +14,7 @@
> #include <linux/pci.h>
> #include <linux/pci_ids.h>
> #include <linux/edac.h>
> +#include <linux/netdevice.h>
>
> #include <linux/io-64-nonatomic-lo-hi.h>
> #include "edac_module.h"
> @@ -260,7 +261,7 @@ static void __iomem *x38_map_mchbar(struct pci_dev *pdev)
> u.mchbar &= X38_MCHBAR_MASK;
>
> if (u.mchbar != (resource_size_t)u.mchbar) {
> - printk(KERN_ERR
> + pr_err(
> "x38: mmio space beyond accessible range (0x%llx)\n",
Put those two on a single line so that you don't have an ugly linebreak
like that.
Thx.
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Mohan Kumar <mohankumar718@gmail.com>
Cc: mchehab@kernel.org, james.morse@arm.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [PATCHv1] drivers: edac: This patch fix the following checkpatch warning.
Date: Sun, 14 Apr 2019 20:49:34 +0200 [thread overview]
Message-ID: <20190414184934.GB569@zn.tnic> (raw)
Message-ID: <20190414184934.35h0ijUtTd8SBVUfwqlJpFpM-3QH8GRx3v9TSTjH5wA@z> (raw)
In-Reply-To: <1555267310-21510-1-git-send-email-mohankumar718@gmail.com>
On Sun, Apr 14, 2019 at 09:41:50PM +0300, Mohan Kumar wrote:
> Use pr_warn instead of printk
>
> WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
> then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
Please read this here first on what to put in your patch title and commit
message:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> Signed-off-by: Mohan Kumar <mohankumar718@gmail.com>
> ---
> drivers/edac/x38_edac.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/edac/x38_edac.c b/drivers/edac/x38_edac.c
> index cc779f3..4c855c0 100644
> --- a/drivers/edac/x38_edac.c
> +++ b/drivers/edac/x38_edac.c
> @@ -14,6 +14,7 @@
> #include <linux/pci.h>
> #include <linux/pci_ids.h>
> #include <linux/edac.h>
> +#include <linux/netdevice.h>
>
> #include <linux/io-64-nonatomic-lo-hi.h>
> #include "edac_module.h"
> @@ -260,7 +261,7 @@ static void __iomem *x38_map_mchbar(struct pci_dev *pdev)
> u.mchbar &= X38_MCHBAR_MASK;
>
> if (u.mchbar != (resource_size_t)u.mchbar) {
> - printk(KERN_ERR
> + pr_err(
> "x38: mmio space beyond accessible range (0x%llx)\n",
Put those two on a single line so that you don't have an ugly linebreak
like that.
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev reply other threads:[~2019-04-14 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-14 18:41 [PATCHv1] drivers: edac: This patch fix the following checkpatch warning Mohan Kumar
2019-04-14 18:41 ` [PATCH] " Mohan Kumar
2019-04-14 18:49 ` Borislav Petkov [this message]
2019-04-14 18:49 ` Borislav Petkov
[not found] ` <CAKr-_Nj2=t-Oc3iNsnC9jBywftAwY8C6wMH+mdfiMPvgzdpYGA@mail.gmail.com>
2019-04-14 20:16 ` Borislav Petkov
2019-04-14 20:16 ` [PATCH] " Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190414184934.GB569@zn.tnic \
--to=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mohankumar718@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox