From: Borislav Petkov <bp@alien8.de>
To: "Hawa, Hanna" <hhhawa@amazon.com>
Cc: "james.morse@arm.com" <james.morse@arm.com>,
Robert Richter <rrichter@marvell.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"Krupnik, Ronen" <ronenk@amazon.com>,
talel@amazon.com, jonnyc@amazon.com, "Hanoch,
Uri" <hanochu@amazon.com>
Subject: Re: [RFC] Support different block names with same EDAC device
Date: Tue, 12 May 2020 22:01:23 +0200 [thread overview]
Message-ID: <20200512200123.GE6859@zn.tnic> (raw)
In-Reply-To: <d4886b17-3d69-2cd0-2999-6eb10e3d5926@amazon.com>
On Tue, May 12, 2020 at 10:27:07PM +0300, Hawa, Hanna wrote:
> The pci layout on EDAC supports counters for parity/non parity errors. We
> are searching for something more general. To add more error for PCIe layout,
> to have counters, and to control panic flag per error.
Looking at edac_device_alloc_ctl_info(), reading the doc section I
pointed you at earlier and then maybe extending that function - if
needed - is what I'd do. After having looked how the others call it.
But you cannot break the existing drivers - adding new
functionality/sysfs nodes etc should be fine, of course.
> Didn't get your suggestion, where can I add name?
See above.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2020-05-12 20:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 12:59 [RFC] Support different block names with same EDAC device Hawa, Hanna
2020-05-11 13:55 ` Borislav Petkov
2020-05-11 14:21 ` Hawa, Hanna
2020-05-11 14:26 ` Borislav Petkov
2020-05-12 8:47 ` Hawa, Hanna
2020-05-12 10:35 ` Borislav Petkov
2020-05-12 19:27 ` Hawa, Hanna
2020-05-12 20:01 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512200123.GE6859@zn.tnic \
--to=bp@alien8.de \
--cc=dwmw@amazon.co.uk \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=james.morse@arm.com \
--cc=jonnyc@amazon.com \
--cc=linux-edac@vger.kernel.org \
--cc=ronenk@amazon.com \
--cc=rrichter@marvell.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox