* [PATCH] EDAC, mv64x60: Fix error return code in mv64x60_pci_err_probe()
@ 2020-11-24 6:30 Wang ShaoBo
2020-12-02 11:25 ` Borislav Petkov
0 siblings, 1 reply; 4+ messages in thread
From: Wang ShaoBo @ 2020-11-24 6:30 UTC (permalink / raw)
To: bp
Cc: mchehab, james.morse, linux-edac, linux-kernel, huawei.libin,
cj.chengjian
Fix to return -ENODEV error code when edac_pci_add_device() failed instaed
of 0 in mv64x60_pci_err_probe(), as done elsewhere in this function.
Fixes: 4f4aeeabc061 ("drivers-edac: add marvell mv64x60 driver")
Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
---
drivers/edac/mv64x60_edac.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/edac/mv64x60_edac.c b/drivers/edac/mv64x60_edac.c
index 3c68bb525d5d..456b9ca1fe8d 100644
--- a/drivers/edac/mv64x60_edac.c
+++ b/drivers/edac/mv64x60_edac.c
@@ -168,6 +168,7 @@ static int mv64x60_pci_err_probe(struct platform_device *pdev)
if (edac_pci_add_device(pci, pdata->edac_idx) > 0) {
edac_dbg(3, "failed edac_pci_add_device()\n");
+ res = -ENODEV;
goto err;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] EDAC, mv64x60: Fix error return code in mv64x60_pci_err_probe()
2020-11-24 6:30 [PATCH] EDAC, mv64x60: Fix error return code in mv64x60_pci_err_probe() Wang ShaoBo
@ 2020-12-02 11:25 ` Borislav Petkov
2020-12-03 11:27 ` Michael Ellerman
0 siblings, 1 reply; 4+ messages in thread
From: Borislav Petkov @ 2020-12-02 11:25 UTC (permalink / raw)
To: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras
Cc: Wang ShaoBo, mchehab, james.morse, linux-edac, linux-kernel,
huawei.libin, cj.chengjian, linuxppc-dev
On Tue, Nov 24, 2020 at 02:30:09PM +0800, Wang ShaoBo wrote:
> Fix to return -ENODEV error code when edac_pci_add_device() failed instaed
> of 0 in mv64x60_pci_err_probe(), as done elsewhere in this function.
>
> Fixes: 4f4aeeabc061 ("drivers-edac: add marvell mv64x60 driver")
> Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
> ---
> drivers/edac/mv64x60_edac.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/edac/mv64x60_edac.c b/drivers/edac/mv64x60_edac.c
> index 3c68bb525d5d..456b9ca1fe8d 100644
> --- a/drivers/edac/mv64x60_edac.c
> +++ b/drivers/edac/mv64x60_edac.c
> @@ -168,6 +168,7 @@ static int mv64x60_pci_err_probe(struct platform_device *pdev)
>
> if (edac_pci_add_device(pci, pdata->edac_idx) > 0) {
> edac_dbg(3, "failed edac_pci_add_device()\n");
> + res = -ENODEV;
> goto err;
> }
That driver depends on MV64X60 and I don't see anything in the tree
enabling it and I can't select it AFAICT:
config MV64X60
bool
select PPC_INDIRECT_PCI
select CHECK_CACHE_COHERENCY
PPC folks, what do we do here?
If not used anymore, I'd love to have one less EDAC driver.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] EDAC, mv64x60: Fix error return code in mv64x60_pci_err_probe()
2020-12-02 11:25 ` Borislav Petkov
@ 2020-12-03 11:27 ` Michael Ellerman
2020-12-03 11:39 ` Borislav Petkov
0 siblings, 1 reply; 4+ messages in thread
From: Michael Ellerman @ 2020-12-03 11:27 UTC (permalink / raw)
To: Borislav Petkov, Benjamin Herrenschmidt, Paul Mackerras
Cc: Wang ShaoBo, mchehab, james.morse, linux-edac, linux-kernel,
huawei.libin, cj.chengjian, linuxppc-dev
Borislav Petkov <bp@alien8.de> writes:
> On Tue, Nov 24, 2020 at 02:30:09PM +0800, Wang ShaoBo wrote:
>> Fix to return -ENODEV error code when edac_pci_add_device() failed instaed
>> of 0 in mv64x60_pci_err_probe(), as done elsewhere in this function.
>>
>> Fixes: 4f4aeeabc061 ("drivers-edac: add marvell mv64x60 driver")
>> Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
>> ---
>> drivers/edac/mv64x60_edac.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/edac/mv64x60_edac.c b/drivers/edac/mv64x60_edac.c
>> index 3c68bb525d5d..456b9ca1fe8d 100644
>> --- a/drivers/edac/mv64x60_edac.c
>> +++ b/drivers/edac/mv64x60_edac.c
>> @@ -168,6 +168,7 @@ static int mv64x60_pci_err_probe(struct platform_device *pdev)
>>
>> if (edac_pci_add_device(pci, pdata->edac_idx) > 0) {
>> edac_dbg(3, "failed edac_pci_add_device()\n");
>> + res = -ENODEV;
>> goto err;
>> }
>
> That driver depends on MV64X60 and I don't see anything in the tree
> enabling it and I can't select it AFAICT:
>
> config MV64X60
> bool
> select PPC_INDIRECT_PCI
> select CHECK_CACHE_COHERENCY
It was selected by PPC_C2K, but that was dropped in:
92c8c16f3457 ("powerpc/embedded6xx: Remove C2K board support")
> PPC folks, what do we do here?
>
> If not used anymore, I'd love to have one less EDAC driver.
It's dead code, so drop it.
I can send a patch if no one else wants to.
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] EDAC, mv64x60: Fix error return code in mv64x60_pci_err_probe()
2020-12-03 11:27 ` Michael Ellerman
@ 2020-12-03 11:39 ` Borislav Petkov
0 siblings, 0 replies; 4+ messages in thread
From: Borislav Petkov @ 2020-12-03 11:39 UTC (permalink / raw)
To: Michael Ellerman
Cc: Benjamin Herrenschmidt, Paul Mackerras, Wang ShaoBo, mchehab,
james.morse, linux-edac, linux-kernel, huawei.libin, cj.chengjian,
linuxppc-dev
On Thu, Dec 03, 2020 at 10:27:25PM +1100, Michael Ellerman wrote:
> It's dead code, so drop it.
>
> I can send a patch if no one else wants to.
Yes please.
I love patches removing code! :-)
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-03 11:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-24 6:30 [PATCH] EDAC, mv64x60: Fix error return code in mv64x60_pci_err_probe() Wang ShaoBo
2020-12-02 11:25 ` Borislav Petkov
2020-12-03 11:27 ` Michael Ellerman
2020-12-03 11:39 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox