From: Eliav Farber <farbere@amazon.com>
To: <bp@alien8.de>, <mchehab@kernel.org>, <tony.luck@intel.com>,
<james.morse@arm.com>, <rric@kernel.org>,
<linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <talel@amazon.com>, <jonnyc@amazon.com>, <hhhawa@amazon.com>,
<hanochu@amazon.com>, <farbere@amazon.com>, <itamark@amazon.com>,
<shellykz@amazon.com>, <amitlavi@amazon.com>, <dkl@amazon.com>
Subject: [PATCH v2] edac: fix period calculation in edac_device_reset_delay_period()
Date: Thu, 20 Oct 2022 12:44:58 +0000 [thread overview]
Message-ID: <20221020124458.22153-1-farbere@amazon.com> (raw)
Fix period calculation in case user sets a value of 1000.
The input of round_jiffies_relative() should be in jiffies and not in
milli-seconds.
Signed-off-by: Eliav Farber <farbere@amazon.com>
---
v2 --> v1:
- Fix the bug without modifying jiffs which is used to set
edac_dev->delay.
drivers/edac/edac_device.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c
index 19522c568aa5..e944dd9b3593 100644
--- a/drivers/edac/edac_device.c
+++ b/drivers/edac/edac_device.c
@@ -398,13 +398,13 @@ void edac_device_reset_delay_period(struct edac_device_ctl_info *edac_dev,
{
unsigned long jiffs = msecs_to_jiffies(value);
- if (value == 1000)
- jiffs = round_jiffies_relative(value);
-
edac_dev->poll_msec = value;
edac_dev->delay = jiffs;
- edac_mod_work(&edac_dev->work, jiffs);
+ if (value == 1000)
+ edac_mod_work(&edac_dev->work, round_jiffies_relative(jiffs));
+ else
+ edac_mod_work(&edac_dev->work, jiffs);
}
int edac_device_alloc_index(void)
--
2.37.1
next reply other threads:[~2022-10-20 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 12:44 Eliav Farber [this message]
2022-12-29 15:23 ` [PATCH v2] edac: fix period calculation in edac_device_reset_delay_period() Borislav Petkov
2022-12-29 20:17 ` Farber, Eliav
2022-12-30 14:48 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020124458.22153-1-farbere@amazon.com \
--to=farbere@amazon.com \
--cc=amitlavi@amazon.com \
--cc=bp@alien8.de \
--cc=dkl@amazon.com \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=itamark@amazon.com \
--cc=james.morse@arm.com \
--cc=jonnyc@amazon.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=shellykz@amazon.com \
--cc=talel@amazon.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox