From: Borislav Petkov <bp@alien8.de>
To: Eliav Farber <farbere@amazon.com>
Cc: mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
rric@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, talel@amazon.com,
jonnyc@amazon.com, hhhawa@amazon.com, hanochu@amazon.com,
itamark@amazon.com, shellykz@amazon.com, amitlavi@amazon.com,
dkl@amazon.com
Subject: Re: [PATCH v2] edac: fix period calculation in edac_device_reset_delay_period()
Date: Thu, 29 Dec 2022 16:23:47 +0100 [thread overview]
Message-ID: <Y62xA548/wQAggRL@zn.tnic> (raw)
In-Reply-To: <20221020124458.22153-1-farbere@amazon.com>
On Thu, Oct 20, 2022 at 12:44:58PM +0000, Eliav Farber wrote:
> Fix period calculation in case user sets a value of 1000.
> The input of round_jiffies_relative() should be in jiffies and not in
> milli-seconds.
>
> Signed-off-by: Eliav Farber <farbere@amazon.com>
Fixes: c4cf3b454eca ("EDAC: Rework workqueue handling")
I guess.
Also, I think the one-liner below does the same, no?
---
diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c
index 19522c568aa5..88942a6edc2c 100644
--- a/drivers/edac/edac_device.c
+++ b/drivers/edac/edac_device.c
@@ -399,7 +399,7 @@ void edac_device_reset_delay_period(struct edac_device_ctl_info *edac_dev,
unsigned long jiffs = msecs_to_jiffies(value);
if (value == 1000)
- jiffs = round_jiffies_relative(value);
+ jiffs = round_jiffies_relative(jiffs);
edac_dev->poll_msec = value;
edac_dev->delay = jiffs;
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-12-29 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 12:44 [PATCH v2] edac: fix period calculation in edac_device_reset_delay_period() Eliav Farber
2022-12-29 15:23 ` Borislav Petkov [this message]
2022-12-29 20:17 ` Farber, Eliav
2022-12-30 14:48 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y62xA548/wQAggRL@zn.tnic \
--to=bp@alien8.de \
--cc=amitlavi@amazon.com \
--cc=dkl@amazon.com \
--cc=farbere@amazon.com \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=itamark@amazon.com \
--cc=james.morse@arm.com \
--cc=jonnyc@amazon.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=shellykz@amazon.com \
--cc=talel@amazon.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox