Linux EDAC development
 help / color / mirror / Atom feed
From: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
To: <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
	<tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
	<linux-edac@vger.kernel.org>, <qiuxu.zhuo@intel.com>
Cc: <CobeChen@zhaoxin.com>, <TimGuo@zhaoxin.com>,
	<LeoLiu-oc@zhaoxin.com>, Lyle Li <LyleLi@zhaoxin.com>
Subject: [PATCH v5 2/4] x86/mce: Remove functions that disable error reporting
Date: Mon, 14 Oct 2024 15:53:16 +0800	[thread overview]
Message-ID: <20241014075318.1936-3-TonyWWang-oc@zhaoxin.com> (raw)
In-Reply-To: <20241014075318.1936-1-TonyWWang-oc@zhaoxin.com>

From: Lyle Li <LyleLi@zhaoxin.com>

Since all major vendors do not disable MCA_CTL after initialization,
remove the functions that disable error reporting.

Signed-off-by: Lyle Li <LyleLi@zhaoxin.com>
Signed-off-by: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
---
 arch/x86/kernel/cpu/mce/core.c | 50 ----------------------------------
 1 file changed, 50 deletions(-)

diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
index 1b647869c320..f71b33b96b5b 100644
--- a/arch/x86/kernel/cpu/mce/core.c
+++ b/arch/x86/kernel/cpu/mce/core.c
@@ -2383,53 +2383,6 @@ int __init mcheck_init(void)
  * mce_syscore: PM support
  */
 
-/*
- * Disable machine checks on suspend and shutdown. We can't really handle
- * them later.
- */
-static void mce_disable_error_reporting(void)
-{
-	struct mce_bank *mce_banks = this_cpu_ptr(mce_banks_array);
-	int i;
-
-	for (i = 0; i < this_cpu_read(mce_num_banks); i++) {
-		struct mce_bank *b = &mce_banks[i];
-
-		if (b->init)
-			wrmsrl(mca_msr_reg(i, MCA_CTL), 0);
-	}
-	return;
-}
-
-static void vendor_disable_error_reporting(void)
-{
-	/*
-	 * Don't clear on Intel or AMD or Hygon or Zhaoxin CPUs. Some of these
-	 * MSRs are socket-wide. Disabling them for just a single offlined CPU
-	 * is bad, since it will inhibit reporting for all shared resources on
-	 * the socket like the last level cache (LLC), the integrated memory
-	 * controller (iMC), etc.
-	 */
-	if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL ||
-	    boot_cpu_data.x86_vendor == X86_VENDOR_HYGON ||
-	    boot_cpu_data.x86_vendor == X86_VENDOR_AMD ||
-	    boot_cpu_data.x86_vendor == X86_VENDOR_ZHAOXIN)
-		return;
-
-	mce_disable_error_reporting();
-}
-
-static int mce_syscore_suspend(void)
-{
-	vendor_disable_error_reporting();
-	return 0;
-}
-
-static void mce_syscore_shutdown(void)
-{
-	vendor_disable_error_reporting();
-}
-
 /*
  * On resume clear all MCE state. Don't want to see leftovers from the BIOS.
  * Only one CPU is active at this time, the others get re-added later using
@@ -2443,8 +2396,6 @@ static void mce_syscore_resume(void)
 }
 
 static struct syscore_ops mce_syscore_ops = {
-	.suspend	= mce_syscore_suspend,
-	.shutdown	= mce_syscore_shutdown,
 	.resume		= mce_syscore_resume,
 };
 
@@ -2729,7 +2680,6 @@ static void mce_disable_cpu(void)
 	if (!cpuhp_tasks_frozen)
 		cmci_clear();
 
-	vendor_disable_error_reporting();
 }
 
 static void mce_reenable_cpu(void)
-- 
2.34.1


  parent reply	other threads:[~2024-10-14  8:09 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2024090910439.3349-1-TonyWWang-oc@zhaoxin.com>
2024-09-10  9:26 ` [PATCH v2 0/3] x86/mce: Add Zhaoxin MCE support Tony W Wang-oc
2024-09-10  9:26   ` [PATCH v2 1/3] x86/mce: Add centaur vendor to support Zhaoxin MCA Tony W Wang-oc
2024-09-10  9:26   ` [PATCH v2 2/3] x86/mce: Add zhaoxin.c " Tony W Wang-oc
2024-09-10  9:26   ` [PATCH v2 3/3] x86/mce: Add CMCI storm switching support for Zhaoxin Tony W Wang-oc
2024-09-18  5:54   ` [PATCH v3 0/3] x86/mce: Add Zhaoxin MCE support Tony W Wang-oc
2024-09-18  5:54     ` [PATCH v3 1/3] x86/mce: Add centaur vendor to support Zhaoxin MCA Tony W Wang-oc
2024-09-19 13:55       ` Yazen Ghannam
2024-09-20 10:41         ` Tony W Wang-oc
2024-09-18  5:54     ` [PATCH v3 2/3] x86/mce: Add zhaoxin.c " Tony W Wang-oc
2024-09-18  5:54     ` [PATCH v3 3/3] x86/mce: Add CMCI storm switching support for Zhaoxin Tony W Wang-oc
2024-09-19 14:06       ` Yazen Ghannam
2024-09-20 10:42         ` Tony W Wang-oc
2024-09-20 13:23           ` Yazen Ghannam
2024-09-20  9:17       ` Zhuo, Qiuxu
2024-09-20 10:42         ` Tony W Wang-oc
2024-09-20 11:44           ` Zhuo, Qiuxu
2024-09-20 13:36             ` Yazen Ghannam
2024-09-21  5:39               ` Zhuo, Qiuxu
     [not found]             ` <acf35354-ab97-4441-828f-daf7affa20ac@zhaoxin.com>
2024-09-23  3:23               ` Tony W Wang-oc
2024-09-23  7:33     ` [PATCH v4 0/4] x86/mce: Add Zhaoxin MCE support and remove Tony W Wang-oc
2024-09-23  7:33       ` [PATCH v4 1/4] x86/mce: Add centaur vendor to support Zhaoxin MCA Tony W Wang-oc
2024-10-12  3:34         ` Zhuo, Qiuxu
2024-09-23  7:33       ` [PATCH v4 2/4] x86/mce: Remove functions that disable error reporting Tony W Wang-oc
2024-10-12  5:37         ` Zhuo, Qiuxu
2024-09-23  7:33       ` [PATCH v4 3/4] x86/mce: Add zhaoxin.c to support Zhaoxin MCA Tony W Wang-oc
2024-10-12  6:41         ` Zhuo, Qiuxu
2024-10-12  9:06           ` Tony W Wang-oc
2024-10-12 11:27             ` Zhuo, Qiuxu
2024-09-23  7:33       ` [PATCH v4 4/4] x86/mce: Add CMCI storm switching support for Zhaoxin Tony W Wang-oc
2024-10-12  7:13         ` Zhuo, Qiuxu
2024-10-12  7:56           ` Tony W Wang-oc
2024-10-14  7:53       ` [PATCH v5 0/4] x86/mce: Add Zhaoxin MCE support and remove functions that disable error reporting Tony W Wang-oc
2024-10-14  7:53         ` [PATCH v5 1/4] x86/mce: Add Centaur vendor to support Zhaoxin MCA Tony W Wang-oc
2024-10-14  7:53         ` Tony W Wang-oc [this message]
2024-10-14  7:53         ` [PATCH v5 3/4] x86/mce: Add zhaoxin.c " Tony W Wang-oc
2024-10-14  7:53         ` [PATCH v5 4/4] x86/mce: Add CMCI storm switching support for Zhaoxin Tony W Wang-oc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241014075318.1936-3-TonyWWang-oc@zhaoxin.com \
    --to=tonywwang-oc@zhaoxin.com \
    --cc=CobeChen@zhaoxin.com \
    --cc=LeoLiu-oc@zhaoxin.com \
    --cc=LyleLi@zhaoxin.com \
    --cc=TimGuo@zhaoxin.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=qiuxu.zhuo@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox